7315 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
bunnei	85421f3406	Merge pull request #690 from lioncash/move ... core/memory, core/hle/kernel: Use std::move where applicable	2018-07-18 20:55:55 -07:00
Lioncash	88ba94e8a2	savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const member function ... This function doesn't alter class state.	2018-07-18 23:50:07 -04:00
Lioncash	9abc5763b6	partition_filesystem: Ensure all class members of PartitionFilesystem are initialized ... Previously is_hfs and pfs_header members wouldn't be initialized in the constructor, as they were stored in locals instead. This would result in things like GetName() and PrintDebugInfo() behaving incorrectly. While we're at it, initialize the members to deterministic values as well, in case loading ever fails.	2018-07-18 23:45:22 -04:00
bunnei	cf30c4be22	gl_state: Temporarily disable culling and depth test.	2018-07-18 23:21:43 -04:00
Lioncash	4790bb907d	content_archive: Make IsDirectoryExeFS() take a shared_ptr as a const reference ... There's no need to take this by value when it's possible to avoid unnecessary copies entirely like this.	2018-07-18 23:19:28 -04:00
Lioncash	87a9bb392b	content_archive: Add missing standard includes	2018-07-18 23:18:59 -04:00
bunnei	522bd5b736	externals: Update dynarmic to 5a91c94.	2018-07-18 23:14:44 -04:00
Lioncash	0b566f43a1	content_archive: std::move VirtualFile in NCA's constructor ... Gets rid of unnecessary atomic reference count incrementing and decrementing.	2018-07-18 23:13:25 -04:00
Lioncash	5e626c774f	vfs: Deduplicate accumulation code in VfsDirectory's GetSize() ... We can just use a generic lambda to avoid writing the same thing twice.	2018-07-18 23:03:27 -04:00
bunnei	1371e2fb6a	Merge pull request #691 from lioncash/guard ... service/prepo: Add missing header guard	2018-07-18 19:46:14 -07:00
bunnei	b10905c8ae	Merge pull request #686 from lioncash/fmt ... externals: update fmt to version 5.1.0	2018-07-18 19:44:44 -07:00
Lioncash	55ab369043	loader/nro: Resolve sign mismatch warnings	2018-07-18 22:27:22 -04:00
Lioncash	1831b5ef62	loader/nso: Remove unnecessary vector resizes ... We can just initialize these vectors directly via their constructor.	2018-07-18 22:26:41 -04:00
Lioncash	e3a30ccc7c	loader/nso: Resolve sign mismatch warnings	2018-07-18 22:26:37 -04:00
bunnei	90ce935f3d	Merge pull request #688 from lioncash/comma ... vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()	2018-07-18 18:59:09 -07:00
bunnei	3f93279047	Merge pull request #693 from lioncash/unused ... core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()	2018-07-18 18:57:13 -07:00
bunnei	49b0966003	Merge pull request #687 from lioncash/instance ... core: Don't construct instance of Core::System, just to access its live instance	2018-07-18 18:55:58 -07:00
bunnei	89f0acfd36	Merge pull request #680 from bunnei/fix-swizz ... decoders: Fix calc of swizzle image_width_in_gobs.	2018-07-18 18:55:37 -07:00
bunnei	d883d3b64f	Merge pull request #685 from lioncash/build ... hle/filesystem: Amend trace log in OpenSaveData() to compile in debug mode	2018-07-18 18:55:15 -07:00
bunnei	2975f7820e	Merge pull request #684 from lioncash/nonmember ... game_list: Make ContainsAllWords an internally linked non-member function	2018-07-18 18:55:00 -07:00
bunnei	b496a9eefe	decoders: Fix calc of swizzle image_width_in_gobs.	2018-07-18 21:42:52 -04:00
Zach Hilman	29aff8d5ab	Virtual Filesystem 2: Electric Boogaloo (#676) ... * Virtual Filesystem * Fix delete bug and documentate * Review fixes + other stuff * Fix puyo regression	2018-07-18 18:07:11 -07:00
Lioncash	72207577b2	core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()	2018-07-18 19:55:46 -04:00
Lioncash	2cd3141c30	address_arbiter: Correct assignment within an assertion statement in WakeThreads() ... This was introduced within 4f81bc4e1b, and considering there's no comment indicating that this is intentional, this is very likely a bug.	2018-07-18 19:46:46 -04:00
Lioncash	296e68fd43	service/prepo: Add missing header guard	2018-07-18 19:43:28 -04:00
Lioncash	93cba6f699	vm_manager: Add missing commas to string literal array elements in GetMemoryStateName() ... Without these, this would perform concatenation, which is definitely not what we want here.	2018-07-18 19:37:19 -04:00
Lioncash	46458e7284	core/memory, core/hle/kernel: Use std::move where applicable ... Avoids pointless copies	2018-07-18 19:34:31 -04:00
Lioncash	10d2ab8098	core: Make System's default constructor private ... This makes it a compilation error to construct additional instances of the System class directly, preventing accidental wasteful constructions over and over.	2018-07-18 18:18:27 -04:00
Lioncash	3a4841e403	core: Don't construct instance of Core::System, just to access its live instance ... This would result in a lot of allocations and related object construction, just to toss it all away immediately after the call. These are definitely not intentional, and it was intended that all of these should have been accessing the static function GetInstance() through the name itself, not constructed instances.	2018-07-18 18:18:27 -04:00
Lioncash	f5d7706ca1	externals: update fmt to version 5.1.0 ... Previously, we were on 4.1.0, which was a major version behind.	2018-07-18 17:46:17 -04:00
Lioncash	079be8032d	hle/filesystem: Amend trace log in OpenSaveData() to compile in debug mode ... Previously this wouldn't compile, since no such function named SaveStructDebugInfo() exists.	2018-07-18 17:42:44 -04:00
bunnei	924c473bb3	Merge pull request #683 from DarkLordZach/touch ... Touchscreen Support	2018-07-18 14:29:16 -07:00
Lioncash	d17e172d92	game_list: Make ContainsAllWords an internally linked non-member function ... This function actually depends on no internal class state, so it doesn't even need to be a part of the class interface.	2018-07-18 16:52:14 -04:00
Zach Hilman	c337272ca9	Fill in more fields in TouchScreenEntryTouch	2018-07-18 16:33:11 -04:00
Zach Hilman	f2f368014e	Single touch support	2018-07-18 14:06:33 -04:00
bunnei	3d1e8f750c	Merge pull request #681 from lioncash/const ... game_list: Make containsAllWords a const member function	2018-07-18 10:02:58 -07:00
bunnei	e3da9fc367	Merge pull request #682 from lioncash/telemetry ... Telemetry: Minor changes	2018-07-18 10:02:46 -07:00
bunnei	24a55bba42	Merge pull request #679 from lioncash/ctor ... game_list: Remove unnecessary QString initialization in KeyReleaseEater	2018-07-17 22:18:39 -07:00
bunnei	b87a71b3fe	Merge pull request #678 from lioncash/astc ... astc: Minor changes	2018-07-17 22:06:20 -07:00
Lioncash	c65a8fafa0	telemetry: Remove unnecessary Field constructor ... We can just take the value parameter by value which allows both moving into it, and copies at the same time, depending on the calling code.	2018-07-18 00:32:35 -04:00
Lioncash	0aebe6b3d5	telemetry: Make operator== and operator!= const member functions of Field ... These operators don't modify internal class state, so they can be made const member functions. While we're at it, drop the unnecessary inline keywords. Member functions that are defined in the class declaration are already inline by default.	2018-07-18 00:28:47 -04:00
bunnei	7c3cc08957	Merge pull request #677 from bunnei/crop-fb ... Implement buffer cropping and default to handheld mode	2018-07-17 21:26:35 -07:00
Lioncash	3575d367a4	telemetry: Default copy/move constructors and assignment operators ... This provides the equivalent behavior, but without as much boilerplate. While we're at it, explicitly default the move constructor, since we have a move-assignment operator defined.	2018-07-18 00:25:12 -04:00
Lioncash	f4b98a857b	game_list: Upper-case containsAllWords to ContainsAllWords() ... This makes it consistent with most of the other private utility functions.	2018-07-18 00:15:48 -04:00
Lioncash	c8f3fc9a4b	game_list: Make containsAllWords a const member function ... This doesn't actually modify the internal class state, so it can be a const member function. While we're at it, amend the function to take its arguments by const reference.	2018-07-18 00:13:04 -04:00
Lioncash	f4c69149f9	game_list: Remove unnecessary QString initialization in KeyReleaseEater ... QString initializes to an empty string by default, so this does nothing meaningful. While we're at it, use a constructor initializer list for initializing the gamelist member variable.	2018-07-18 00:07:47 -04:00
Lioncash	6a03badcbc	astc: Initialize vector size directly in Decompress ... There's no need to perform a separate resize.	2018-07-17 23:58:14 -04:00
Lioncash	0f148548f3	astc: Mark functions as internally linked where applicable	2018-07-17 23:58:14 -04:00
Lioncash	c5803e30d3	astc: const-correctness changes where applicable ... A few member functions didn't actually modify class state, so these can be amended as necessary.	2018-07-17 23:58:14 -04:00
Lioncash	e3fadb9616	astc: Delete Bits' copy contstructor and assignment operator ... This also potentially avoids warnings, considering the copy assignment operator is supposed to have a return value.	2018-07-17 23:58:14 -04:00