7321 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Lioncash	48733744bb	arm_test_common: Get rid of truncation warnings ... Explicitly cast the value to a u8 to show that this is intentional.	2018-07-20 17:53:53 -04:00
Lioncash	a8bb1eb39f	arm_test_common: Make file static variable a member variable of the testing environment ... Gets rid of file-static behavior.	2018-07-20 17:52:37 -04:00
Lioncash	a44475207c	arm_test_common: Add missing header guard	2018-07-20 17:48:43 -04:00
Lioncash	3268321f4b	param_package: Take std::string by value in string-based Set() function ... Allows avoiding string copies by letting the strings be moved into the function calls.	2018-07-20 17:24:06 -04:00
Lioncash	6279c2dcf4	param_package: Use std::unordered_map's insert_or_assign instead of map indexing ... This avoids a redundant std::string construction if a key doesn't exist in the map already. e.g. data[key] requires constructing a new default instance of the value in the map (but this is wasteful, since we're already setting something into the map over top of it).	2018-07-20 17:24:06 -04:00
Lioncash	474ec2ee5f	param_package: Get rid of file-static std::string construction ... Avoids potential dynamic allocation occuring during program launch	2018-07-20 17:24:02 -04:00
Lioncash	f63ccbd936	logging/filter: Use std::string_view in ParseFilterString() ... Allows avoiding constructing std::string instances, since this only reads an arbitrary sequence of characters. We can also make ParseFilterRule() internal, since it doesn't depend on any private instance state of Filter	2018-07-20 15:58:46 -04:00
Lioncash	7a1a860abe	logging/backend: Add missing standard includes ... A few inclusions were being satisfied indirectly. To prevent breakages in the future, include these directly.	2018-07-20 15:31:27 -04:00
Lioncash	457d1b4490	logging/backend: Use std::string_view in RemoveBackend() and GetBackend() ... These can just use a view to a string since its only comparing against two names in both cases for matches. This avoids constructing std::string instances where they aren't necessary.	2018-07-20 15:27:20 -04:00
bunnei	dffd154d6d	apm: Improve stub for GetPerformanceConfiguration.	2018-07-20 15:20:01 -04:00
Lioncash	0a0b3c4b9f	ipc_helpers: Add PushEnum() member function to ResponseBuilder ... Allows pushing strongly-typed enum members without the need to always cast them at the call sites. Note that we *only* allow strongly-typed enums in this case. The reason for this is that strongly typed enums have a guaranteed defined size, so the size of the data being pushed is always deterministic. With regular enums this can be a little more error-prone, so we disallow them. This function simply uses the underlying type of the enum to determine the size of the data. For example, if an enum is defined as: enum class SomeEnum : u16 { SomeEntry }; if PushEnum(SomeEnum::SomeEntry); is called, then it will push a u16-size amount of data.	2018-07-20 15:00:58 -04:00
bunnei	c1c9ab31e8	Merge pull request #740 from Subv/acc_crash ... HLE/ACC: Stub IManagerForApplication::GetAccountId to return an error.	2018-07-20 09:47:47 -07:00
bunnei	8346541901	Merge pull request #739 from lioncash/glad ... externals: Update glad to version 0.1.25	2018-07-20 09:22:26 -07:00
bunnei	29f49bd3c1	Merge pull request #738 from lioncash/sign ... gl_state: Get rid of mismatched sign conversions in Apply()	2018-07-20 09:21:57 -07:00
bunnei	ffbd51e207	Merge pull request #737 from lioncash/move ... filesys/loader: std::move VirtualFile instances in constructors where applicable	2018-07-20 09:21:15 -07:00
bunnei	701c7cb85c	Merge pull request #736 from lioncash/null ... audout_u/audren_u: Ensure null terminators are written out in ListAudioOutsImpl(), ListAudioDeviceName(), and GetActiveAudioDeviceName()	2018-07-20 09:17:07 -07:00
bunnei	fbc2bcd4a9	Merge pull request #735 from lioncash/video-unused ... maxwell_3d: Remove unused variable within GetStageTextures()	2018-07-20 09:16:15 -07:00
bunnei	741cae1e1d	Merge pull request #734 from lioncash/thread ... thread: Convert ThreadStatus into an enum class	2018-07-20 09:15:52 -07:00
bunnei	a1805ceb0b	Merge pull request #733 from lioncash/dirs ... partition_filesystem: Return pfs_dirs member variable within GetSubdirectories()	2018-07-20 09:15:16 -07:00
bunnei	86d1649b32	Merge pull request #732 from lioncash/unused ... nso: Minor changes	2018-07-20 09:14:10 -07:00
bunnei	204d707ce7	Merge pull request #731 from lioncash/shadow ... gl_shader_decompiler: Eliminate variable and declaration shadowing	2018-07-20 09:13:36 -07:00
Subv	9c7321fe6d	HLE/ACC: Stub IManagerForApplication::GetAccountId to return an error. ... And make IManagerForApplication::CheckAvailability always return false. Returning a bogus id from GetAccountId causes games to crash on boot. We should investigate this with a hwtest and either stub it properly or implement it.	2018-07-20 11:02:25 -05:00
Lioncash	6a9cd17227	externals: Update glad to version 0.1.25 ... Keeps the OpenGL loader library up to date. Previously we were at version 0.1.16	2018-07-20 02:00:05 -04:00
Lioncash	0faa13baeb	gl_state: Make references const where applicable in Apply()	2018-07-20 01:12:29 -04:00
Lioncash	e6b3d3a9ea	gl_state: Get rid of mismatched sign conversions ... While we're at it, amend the loop variable type to be the same width as that returned by the .size() call.	2018-07-20 01:11:20 -04:00
Lioncash	8874d0e657	loader/{nca, nro}: std::move VirtualFile in the constructors where applicable ... This avoids unnecessary atomic reference count increments and decrements	2018-07-20 00:10:24 -04:00
Lioncash	0e9d58e82a	vfs_offset: std::move file and name parameters of OffsetVfsFile ... Avoids potentially unnecessary atomic reference count incrementing and decrementing, as well as string copying.	2018-07-20 00:04:54 -04:00
bunnei	f36affdbe3	Merge pull request #730 from lioncash/string ... gl_shader_decompiler: Remove unnecessary const from return values	2018-07-19 20:46:43 -07:00
bunnei	ce66a188d0	Merge pull request #729 from lioncash/simplify ... pl_u: Simplify WriteBuffer() calls in GetSharedFontInOrderOfPriority()	2018-07-19 20:46:11 -07:00
Lioncash	40c9c5a55c	audren_u: Use a std::array instead of std::string for holding the audio interface/device name ... std::string doesn't include the null-terminator in its data() + size() range. This ensures that the null-terminator will also be written to the buffer	2018-07-19 23:15:27 -04:00
Lioncash	c20cea118b	audout_u: Use a std::array instead of std::string for holding the audio interface name ... Uses a type that doesn't potentially dynamically allocate, and ensures that the name of the interface is properly null-terminated when writing it to the buffer.	2018-07-19 23:15:00 -04:00
Lioncash	8b08f82dc7	maxwell_3d: Remove unused variable within GetStageTextures()	2018-07-19 22:38:28 -04:00
Lioncash	dbfe82773d	thread: Convert ThreadStatus into an enum class ... Makes the thread status strongly typed, so implicit conversions can't happen. It also makes it easier to catch mistakes at compile time.	2018-07-19 22:08:56 -04:00
Lioncash	bbd6429ecb	partition_filesystem: Return pfs_dirs member variable within GetSubdirectories() ... This should be returned here, otherwise pfs_dirs is effectively only ever added to, but never read.	2018-07-19 21:08:50 -04:00
Lioncash	364b950515	nso: Silence implicit sign conversion warnings	2018-07-19 20:51:15 -04:00
Lioncash	a25c5b982a	nso: Remove unused function ReadSegment()	2018-07-19 20:49:27 -04:00
Lioncash	f26866ff6a	gl_shader_decompiler: Eliminate variable and declaration shadowing ... Ensures that no identifiers are being hidden, which also reduces compiler warnings.	2018-07-19 20:32:49 -04:00
Lioncash	c2121cb059	gl_shader_decompiler: Remove unnecessary const from return values ... This adds nothing from a behavioral point of view, and can inhibit the move constructor/RVO	2018-07-19 20:11:04 -04:00
Lioncash	1bdb67440b	pl_u: Simplify WriteBuffer() calls in GetSharedFontInOrderOfPriority() ... With the new overload, we can simply pass the container directly.	2018-07-19 19:50:30 -04:00
bunnei	d3cfaf95c8	Merge pull request #726 from lioncash/overload ... hle_ipc: Introduce generic WriteBuffer overload for multiple container types	2018-07-19 16:18:38 -07:00
bunnei	0b13ce1435	Merge pull request #725 from lioncash/bytes ... pl_u: Specify correct size for buffers in GetSharedFontInOrderOfPriority()	2018-07-19 16:16:30 -07:00
bunnei	af08034c71	Merge pull request #728 from Subv/acc_profile ... HLE/ACC: Change the default user id and small improvements to the way we handle profiles	2018-07-19 16:15:01 -07:00
bunnei	2aeb3355e4	Merge pull request #727 from Subv/acc_users ... HLE/ACC: Write a single whole user id in ListAllUsers and ListOpenUsers.	2018-07-19 16:13:45 -07:00
bunnei	c6352ffc58	Merge pull request #724 from lioncash/printf ... pl_u: Remove printf specifier in log call in a log call in GetSharedFontInOrderOfPriority()	2018-07-19 16:13:07 -07:00
bunnei	ec468c990d	Merge pull request #723 from lioncash/gdb ... gdbstub: Get rid of a few signed/unsigned comparisons	2018-07-19 16:12:40 -07:00
bunnei	f43d8ea523	Merge pull request #722 from lioncash/signed ... hid: Resolve a signed/unsigned comparison warning	2018-07-19 16:12:15 -07:00
bunnei	2194308245	Merge pull request #721 from lioncash/svc ... svc: Correct always true assertion case in SetThreadCoreMask	2018-07-19 16:11:40 -07:00
bunnei	b5c77313de	Merge pull request #719 from lioncash/docs ... loader: Amend Doxygen comments	2018-07-19 16:11:09 -07:00
bunnei	dd0446ff43	Merge pull request #718 from lioncash/read ... loader/nso: Check if read succeeded in IdentifyFile() before checking magic value	2018-07-19 16:10:29 -07:00
bunnei	31413f0d2f	Merge pull request #717 from lioncash/explicit ... hle/service: Make constructors explicit where applicable	2018-07-19 16:08:07 -07:00