tstarr/yuzu
1
0
Fork 0
mirror of https://github.com/starr-dusT/yuzu-mainline synced 2024-03-05 21:12:25 -08:00
Code Issues Packages Projects Releases Wiki Activity
21,593 Commits 1 Branch 0 Tags 72 MiB
096366ead5
Commit Graph

8787 Commits

Author SHA1 Message Date
Lioncash
fc6db97a09 core: Remove usage of unicorn 
Unicorn long-since lost most of its use, due to dynarmic gaining support
for handling most instructions. At this point any further issues
encountered should be used to make dynarmic better.

This also allows us to remove our dependency on Python.
 2020-11-03 20:22:05 -05:00
bunnei
448e4d5c2a
Merge pull request #4878 from bunnei/unload-nrr 
hle: service: ldr: Implement UnloadNrr.
 2020-11-03 08:52:40 -08:00
bunnei
848bdf8a40 fixup! hle service: nvdrv: nvhost_gpu: Update to use SyncpointManager and other improvements. 2020-11-01 01:52:38 -07:00
bunnei
7d2839d7a3 core: Initialize GPU before services. 2020-11-01 01:52:38 -07:00
bunnei
e67b8678f8 hle service: nvdrv: nvhost_gpu: Update to use SyncpointManager and other improvements. 
- Refactor so that SubmitGPFIFO and KickoffPB use shared functionality.
- Implement add_wait and add_increment flags.
 2020-11-01 01:52:38 -07:00
bunnei
1d4cbb92f2 service: hle: nvflinger: Fix potential shutdown crash when GPU is destroyed. 2020-11-01 01:52:38 -07:00
bunnei
66edfd61c6 hle service: nvdrv: nvhost_ctrl: Update to use SyncpointManager. 2020-11-01 01:52:37 -07:00
bunnei
4a3fd97e48 hle service: nvdrv: Update to instantiate SyncpointManager. 2020-11-01 01:52:34 -07:00
bunnei
d567b7e841 hle: service: nvdrv: Implement SyncpointManager, to manage syncpoints. 2020-11-01 01:51:54 -07:00
Levi Behunin
bca9591660
Rename to align with switchbrew and remove gpu function (#4714) 
* Rename to align with switchbrew

* Rename to align with switchbrew and remove gpu function that checks if clearing should be done.
 2020-11-01 01:24:17 -07:00
bunnei
a0e5cccb92 hle: service: ldr: Implement UnloadNrr. 
- Used by Final Fantasy X/X-2 HD Remaster.
 2020-10-31 01:22:53 -07:00
Jan Beich
50e52ade85 video_core: unbreak -Werror in NVDEC with Clang 
src/core/hle/service/nvdrv/devices/nvhost_nvdec_common.cpp:41:15: error: unused variable 'OutOfMemory' [-Werror,-Wunused-const-variable]
constexpr u32 OutOfMemory{static_cast<u32>(-12)};
              ^
 2020-10-30 16:43:10 +00:00
Lioncash
5553bd3ba2 General: Resolve a few missing initializer warnings 
Resolves a few -Wmissing-initializer warnings.
 2020-10-29 19:37:07 -04:00
Morph
9cfc5fee2f kernel/process: Add missing <ctime> include 
Fixes compilation on MSVC
 2020-10-29 03:17:20 -04:00
bunnei
c5134cbf3a
Merge pull request #4835 from lat9nq/rng-default-time 
kernel: Use the current time as the default RNG seed
 2020-10-28 22:51:29 -07:00
bunnei
7af2cb4318
Merge pull request #4846 from lioncash/service-fn 
service: Update function tables
 2020-10-28 13:47:56 -07:00
Lioncash
020519def8 service: Update function tables 
Updates function tables according to info on SwitchBrew.
 2020-10-27 21:19:46 -04:00
bunnei
d33399e1f4
Merge pull request #4729 from ameerj/nvdec-prod 
video_core: NVDEC Implementation
 2020-10-26 23:02:42 -07:00
ReinUsesLisp
ce69ff2890 hle/kernel: Remove unused registered_core_threads to fix data races 
This member was only used on asserts and it triggered data races.
Remove it to fix them.
 2020-10-27 01:55:39 -03:00
bunnei
c7f32931ee
Merge pull request #4832 from bunnei/cpu-manager-microprofile-fix 
core: cpu_manager: Add missing call to MicroProfileOnThreadExit().
 2020-10-26 21:29:09 -07:00
bunnei
1828f82000
Merge pull request #4833 from bunnei/timezonemanager-explicit 
hle: services: TimeZoneContentManager: This can be made explicit.
 2020-10-26 21:28:45 -07:00
ameerj
eb67a45ca8 video_core: NVDEC Implementation 
This commit aims to implement the NVDEC (Nvidia Decoder) functionality, with video frame decoding being handled by the FFmpeg library.

The process begins with Ioctl commands being sent to the NVDEC and VIC (Video Image Composer) emulated devices. These allocate the necessary GPU buffers for the frame data, along with providing information on the incoming video data. A Submit command then signals the GPU to process and decode the frame data.

To decode the frame, the respective codec's header must be manually composed from the information provided by NVDEC, then sent with the raw frame data to the ffmpeg library.

Currently, H264 and VP9 are supported, with VP9 having some minor artifacting issues related mainly to the reference frame composition in its uncompressed header.

Async GPU is not properly implemented at the moment.

Co-Authored-By: David <25727384+ogniK5377@users.noreply.github.com>
 2020-10-26 23:07:36 -04:00
bunnei
9f08cea2c4
Merge pull request #4834 from lioncash/copy-fn 
controller: Pass ControllerParameters by reference in ReconfigureControllers()
 2020-10-26 18:49:26 -07:00
lat9nq
8bd246032a kernel: Use the current time as the default RNG seed 
Use the current time, not zero, as the default RNG seed.
 2020-10-26 21:42:11 -04:00
Lioncash
6b5f565324 controller: Pass ControllerParameters by reference in ReconfigureControllers() 
Prevents unnecessary copies and heap reallocations from occurring.
 2020-10-26 21:06:15 -04:00
bunnei
3984bb6def hle: services: TimeZoneContentManager: This can be made explicit. 2020-10-26 16:11:45 -07:00
bunnei
54aabb00b0 core: cpu_manager: Add missing call to MicroProfileOnThreadExit(). 
- Fixes an occasional crash when trying to launch subsequent games.
 2020-10-26 16:09:15 -07:00
Rodrigo Locatti
ae3a755d13
Merge pull request #4828 from lioncash/lockguard 
general: Use template deduction guides for lock_guard
 2020-10-25 16:55:54 -03:00
Lioncash
98f4c5e7b8 general: Use template deduction guides for lock_guard 
Same behavior, less code.
 2020-10-25 13:53:22 -04:00
bunnei
e7042163c8
Merge pull request #4792 from bunnei/rtc-fix 
service: time: Update current time with changes to RTC setting.
 2020-10-22 20:46:54 -07:00
Lioncash
ea20b5c970 core: Fix clang build pt.3 
Should finally resolve building with clang.
 2020-10-21 22:14:23 -04:00
Lioncash
e408bd3b7c core: Fix clang build pt.2 
Resolves the clang build issue in a more unintrusive way.
 2020-10-20 22:16:03 -04:00
bunnei
3d592972dc
Revert "core: Fix clang build" 2020-10-20 19:07:39 -07:00
Lioncash
fdd9154069 kernel: Fix build with recent compiler flag changes 
This slipped through the cracks due to another change being merged
before the compiler flag changes.
 2020-10-20 20:23:18 -04:00
LC
88d5140cf2
Merge pull request #4796 from lioncash/clang 
core: Fix clang build
 2020-10-20 19:19:12 -04:00
bunnei
940c3bf68d
Merge pull request #4390 from ogniK5377/get-applet-inf-stub 
nifm: GetAppletInfo stub
 2020-10-20 15:59:19 -07:00
David Marcec
298b50e220 Added remaining params 2020-10-20 16:45:01 +11:00
David Marcec
acd35e1b60 nifm: GetAppletInfo stub 
Fixes crash for Catherine Full Body
 2020-10-20 16:42:40 +11:00
bunnei
60bd54776a
Merge pull request #4788 from ReinUsesLisp/lockfree-host-thread 
kernel: Implement host thread register methods without locking
 2020-10-19 22:31:52 -07:00
bunnei
e7a26ecec5
Merge pull request #4785 from Morph1984/fs-hades 
filesystem: Fix CreateDirectory and DeleteFile
 2020-10-19 16:04:01 -07:00
bunnei
598ef6b0b3
Merge pull request #4802 from lioncash/bcat 
core: Add boxcat sources with target_sources
 2020-10-19 12:40:49 -07:00
bunnei
54b977acaa
Merge pull request #4783 from bunnei/nvdrv-freespace 
hle: service: nvdrv: Implement nvhost_as_gpu::FreeSpace.
 2020-10-18 12:41:18 -07:00
Lioncash
0ab7bfdfce core: Add boxcat sources with target_sources 
Same behavior, minus a script variable.
 2020-10-18 08:09:06 -04:00
bunnei
2190f1a2b7
Merge pull request #4801 from lioncash/missing-bound 
mii/manager: Make use of unused lower bound in GetRandomValue()
 2020-10-17 23:32:40 -07:00
Lioncash
be1954e04c core: Fix clang build 
Recent changes to the build system that made more warnings be flagged as
errors caused building via clang to break.

Fixes #4795
 2020-10-17 19:50:39 -04:00
Lioncash
c1577f3448 mii/manager: Make use of unused lower bound in GetRandomValue() 
Previously, the lower bound wasn't being used and zero was being used as
the lower bound every time this function was called.

This affects the outcome of some of the randomized entries a little bit,
for example, the lower-bound for beard and mustache flags was supposed
to be 1, not 0.

Aside from these cases, the bug didn't affect anything else.
 2020-10-17 09:50:04 -04:00
bunnei
363c644730 service: bcat: Check client connection before interacting with socket. 
- Fixes a crash when BCAT service is offline.
 2020-10-16 21:16:56 -07:00
bunnei
dbd1662ae2
Merge pull request #4784 from bunnei/cancelbuffer 
hle: service: vi: Implement BufferQueue::CancelBuffer.
 2020-10-15 19:57:27 -07:00
bunnei
1d714c8c7f service: acc: Stub IManagerForApplication::StoreOpenContext. 
- Used by Super Mario 3D All-Stars.
 2020-10-14 20:06:33 -07:00
bunnei
1f186f34a2 hle: service: vi: Implement BufferQueue::CancelBuffer. 
- This is used by Super Mario 3D All-Stars.
 2020-10-13 22:11:52 -07:00
ReinUsesLisp
b9a9b83bee kernel: Implement host thread register methods without locking 
Locks on GetCurrentHostThreadID were causing performance issues
according to Visual Studio's profiler. It was consuming twice the time
as arm_interface.Run(). The cost was not in the function itself but in
the lockinig it required.

Reimplement these functions using atomics and static storage instead of
an unordered_map. This is a side effect to avoid locking and using linked
lists for reads.

Replace unordered_map with a linear search.
 2020-10-13 18:00:25 -03:00
Lioncash
39c8d18feb core/CMakeLists: Make some warnings errors 
Makes our error coverage a little more consistent across the board by
applying it to Linux side of things as well. This also makes it more
consistent with the warning settings in other libraries in the project.

This also updates httplib to 0.7.9, as there are several warning
cleanups made that allow us to enable several warnings as errors.
 2020-10-13 13:16:49 -04:00
Morph
8db3feae19 filesystem: Fix CreateDirectory and DeleteFile 
Add a check if dir is nullptr (does not exist)

Fixes save game creation in Hades
 2020-10-13 00:57:04 -04:00
bunnei
62c6c9f6a6 service: time: Update current time with changes to RTC setting. 
- This can be used to advance time, e.g. for Pokemon Sword/Shield pokejobs.
 2020-10-12 18:09:15 -07:00
bunnei
d291fc1a51
Merge pull request #3929 from FearlessTobi/ticket-keys 
file_sys/nsp: Make SetTicketKeys actually do something
 2020-10-12 17:58:36 -07:00
bunnei
b260847218 hle: service: nvdrv: Implement nvhost_as_gpu::FreeSpace. 
- This is used by Super Mario 3D All-Stars.
 2020-10-12 17:39:14 -07:00
bunnei
92adb69fa7
Merge pull request #4736 from Morph1984/home-button-input-protection-stub 
hid: Stub HomeButtonInputProtection service commands
 2020-10-07 14:54:05 -07:00
bunnei
cc0dc3280d
Merge pull request #4710 from Morph1984/fix-integrated-updates 
submission_package: Fix updates integrated into cartridge images.
 2020-10-06 22:27:52 -07:00
bunnei
32b4627a9c
Merge pull request #4737 from Morph1984/setshimlibraryversion-stub 
capsrv: Stub 3 variants of SetShimLibraryVersion
 2020-10-06 21:39:38 -07:00
bunnei
614bd0ee8c
Merge pull request #4742 from german77/InputFilter 
HID: Only use inputs corresponding to controller type
 2020-10-05 21:40:09 -07:00
bunnei
182cf7d631
Merge pull request #4734 from german77/motionfusion 
HID: Add Stub for EnableSixAxisSensorFusion
 2020-10-01 22:39:39 -07:00
german
2f47b27654 Only use inputs corresponding to controller type 2020-10-01 19:39:53 -05:00
german
283616dbd8 Stubbed EnableSixAxisSensorFusion 2020-09-30 10:00:24 -05:00
David
4d0ae1a17a
Merge pull request #4291 from german77/ImplementControllerRumble 
input_common: First implementation of controller rumble
 2020-09-30 21:24:11 +10:00
David
f7808f5658
Merge pull request #4726 from lioncash/applet 
frontend/controller: Eliminate dependency on the global system instance
 2020-09-30 21:22:45 +10:00
Morph
91bd2281bf caps_c: Stub SetShimLibraryVersion 
- Used by caps_su SetShimLibraryVersion
 2020-09-30 07:19:46 -04:00
Morph
7d287a6fb0 caps_u: Stub SetShimLibraryVersion 
- Used in Super Smash Bros. Ultimate
 2020-09-30 07:19:46 -04:00
Morph
9a251339dc caps_su: Properly stub SetShimLibraryVersion 2020-09-30 07:19:46 -04:00
Morph
6380731486 hid: Stub HomeButtonInputProtection service commands 
- Used in 1-2 Switch. Given that we do not emulate the functionality of the home button yet, we can stub this for now.
 2020-09-30 06:38:24 -04:00
bunnei
392c1b96bc
Merge pull request #4705 from german77/SplitMotionPoller 
HID: Use different timing for motion
 2020-09-30 01:04:22 -07:00
bunnei
02ea62568f
Merge pull request #1703 from DarkLordZach/nvdec-ioctl 
nvdrv: Stub nvdec/vic ioctls to bypass nvdec movies
 2020-09-29 15:00:48 -07:00
german
ab88c2f611 First implementation of controller rumble 2020-09-29 10:38:25 -04:00
Lioncash
5c4e237902 core: Mark GetInstance() as deprecated 
This way it's obvious that this function shouldn't be used in any future
code.
 2020-09-25 19:23:23 -04:00
Lioncash
3e4a0a13cb frontend/controller: Eliminate dependency on the global system instance 2020-09-25 19:23:20 -04:00
LC
4d4afc1502
Merge pull request #4717 from lioncash/debug 
service: Restore "unused" function
 2020-09-25 00:07:19 -04:00
Lioncash
f3a1bf53f9 service: Restore "unused" function 
Turns out this function is actually used, but within a trace log.
 2020-09-25 00:06:40 -04:00
Morph
3602df7f1f submission_package: Fix updates integrated into cartridge images. 2020-09-24 17:23:14 -04:00
bunnei
fa4294cc6f
Merge pull request #4678 from Morph1984/LoadOpenContext-partial-impl 
acc: Partially implement LoadOpenContext
 2020-09-24 11:21:25 -07:00
german
ddff03cff5 Use different timing for motion 2020-09-23 19:09:33 -05:00
Lioncash
b14d344dfc memory: Resolve a -Wdocumentation warning 
memory doesn't exist as a parameter any more.
 2020-09-23 13:39:27 -04:00
Lioncash
ff45c39578 General: Make use of std::nullopt where applicable 
Allows some implementations to avoid completely zeroing out the internal
buffer of the optional, and instead only set the validity byte within
the structure.

This also makes it consistent how we return empty optionals.
 2020-09-22 17:32:33 -04:00
Lioncash
a881efbf26 ips_layer: Eliminate a redundant copy in Parse() 
Prevents unnecessary copying of the line being parsed.
 2020-09-22 16:38:45 -04:00
bunnei
53829d4cbd
Merge pull request #4675 from Morph1984/fix-boot-multicontent 
submission_package: Account for multi-content NSPs
 2020-09-21 16:36:46 -07:00
Morph
7a504a9365 acc: Stub LoadOpenContext 
This is used in multiple games such as:
- Clubhouse Games: 51 Worldwide Classics
- Grandia HD Collection
- XCOM 2 Collection
- Baldur's Gate 1/2
- Dr Kawashima's Brain Training
- Super Mario 3D All-Stars
 2020-09-21 01:01:02 -04:00
bunnei
754109fd54
Merge pull request #4683 from Morph1984/NpadHandheldActivationMode-impl 
hid: Implement Get/SetNpadHandheldActivationMode
 2020-09-20 12:39:20 -07:00
bunnei
8a85a562ed
Merge pull request #4643 from FearlessTobi/decrease-pad-update-interval 
Test: Decrease pad_update_ns
 2020-09-19 00:39:50 -07:00
Morph
ab961e0701 hid: Implement Get/SetNpadHandheldActivationMode 
- Used in Clubhouse Games: 51 Worldwide Classics
 2020-09-18 10:10:30 -04:00
Morph
40a72e9cd5 am: Stub GetPreviousProgramIndex 
- Used in Super Mario 3D All-Stars
 2020-09-17 22:03:02 -04:00
Morph
41c2f5200c submission_package: Account for multi-content NSPs 
Previously we assumed a submission package can only contain one Program NCA with a single TitleID.
However, Super Mario 3D All-Stars contains four Program NCAs, each with their unique TitleIDs.
This accounts for the existence of multi-content games such as this one.
- Fixes booting Super Mario 3D All-Stars from the games list.
 2020-09-17 20:44:51 -04:00
Rodrigo Locatti
53fc5d0190
Merge pull request #4670 from lioncash/initializer 
arm_dynarmic_cp15: Initialize member variables
 2020-09-17 21:20:53 +00:00
Rodrigo Locatti
9bdca01c27
Merge pull request #4665 from lioncash/sm-kernel 
service/sm: Eliminate dependency on the global system instance
 2020-09-17 21:20:39 +00:00
Rodrigo Locatti
8100275309
Merge pull request #4666 from lioncash/unused-func 
service: Remove unused funcation
 2020-09-17 21:19:48 +00:00
Rodrigo Locatti
131532b570
Merge pull request #4671 from lioncash/nfp-copy 
command_generator/nfp: Eliminate unnecessary copies
 2020-09-17 21:19:12 +00:00
bunnei
3f6d83b27c
Merge pull request #4594 from german77/MotionHID 
hid/configuration: Implement motion controls to HID
 2020-09-17 12:39:01 -07:00
Lioncash
aca3621146 nfp: Eliminate two unnecessary copies 
GetAmiiboBuffer() returns by const reference, so we can use a reference
instead of taking the returned buffer by value.
 2020-09-17 13:35:55 -04:00
Lioncash
1ee9ceb5af arm_dynarmic_cp15: Initialize member variables 
Ensures that the member variables are always initialized to a
deterministic value on creation.
 2020-09-17 13:03:49 -04:00
Lioncash
02b8b6677a control_metadata: Resolve typo in Portuguese language name 
This isn't used anywhere, so this is a trivial fix.
 2020-09-17 11:45:30 -04:00
Lioncash
8bbd82863d service: Remove unused funcation 
This is now completely unused, so it can be removed.
 2020-09-17 11:03:26 -04:00
Lioncash
057aa6275d service/sm: Slightly more efficient string name validation 
We can check the end of the string first for null-termination, rather
than the beginning of the string.
 2020-09-17 10:54:12 -04:00
Lioncash
78b1bc3b61 service/sm: Eliminate dependency on the global system instance 2020-09-17 10:43:54 -04:00
Lioncash
a62c1999c5 file_sys/romfs_factory: Eliminate usage of the global system accessor 2020-09-16 19:15:19 -04:00
Lioncash
0e80567bef file_sys/bis_factory: Eliminate usage of the global system accessor 2020-09-16 18:16:04 -04:00
Lioncash
aa8d6fc041 loader/nso: Remove unnecessary [[maybe_unused]] 2020-09-16 18:09:01 -04:00
Lioncash
113a3972a6 core/loader: Remove dependencies on the global system instance 
Now all that remains is:

18 instances in file_sys code
14 instances in GDB stub code (this can be tossed wholesale)
4 instances in HLE code
2 instances in settings code.
 2020-09-16 08:46:59 -04:00
Rodrigo Locatti
004bfefeb5
Merge pull request #4658 from lioncash/copy3 
nca_patch: Reduce stack usage size within SearchBucketEntry()
 2020-09-16 00:25:11 +00:00
Lioncash
66fc037ef2 nca_patch: Significantly reduce the stack usage size within SearchBucketEntry() 
Previously this function was using ~16KB of stack (16528 bytes), which
was caused by the function arguments being taken by value rather than by
reference.

We can make this significantly lighter on the stack by taking them by
reference.
 2020-09-15 09:10:58 -04:00
Lioncash
99b372a6c5 nca_patch: Make SearchBucketEntry() internally linked 
This is only used internally and doesn't depend on any class state, so
we can make it fully internal.
 2020-09-15 09:06:46 -04:00
Lioncash
3a8464cde2 cheat_engine: Convert ExtractName into a non-template function 
We don't need to create two separate instantiations of the same code, we
can simply make the character template argument a regular function
parameter.
 2020-09-15 03:24:44 -04:00
Lioncash
ba7eb5abf4 cheat_engine: Remove unnecessary system argument to CheatParser's Parse function 
This isn't used within the function at all in any implementations, so we
can remove it entirely.
 2020-09-15 03:20:40 -04:00
Lioncash
33e4a0b6c1 patch_manager: Resolve implicit truncations in FormatTitleVersion() 
We make it explicit that we're truncating arithmetic here to resolve
compiler warnings (even if the sizes weren't u32/u64 arithmetic
generally promotes to int :<)
 2020-09-14 19:19:59 -04:00
Lioncash
a4392c24cf patch_manager: Make use of type aliases 
We can use these to avoid typing the same type redundantly. This way, if
these ever change, only a single location needs to be modified.
 2020-09-14 19:17:50 -04:00
Lioncash
637ab14ae6 patch_manager: Make a few functions internally linked 
These functions are only used within this translation unit, so we can
make them internally linked.
 2020-09-14 19:04:51 -04:00
Lioncash
e0dd440b1f crypto/key_manager: Remove dependency on the global system accessor 
We can supply the content provider as an argument instead of hardcoding
a global accessor in the implementation.
 2020-09-14 16:49:59 -04:00
Lioncash
ec2a6e5ba8 kernel: Remove all dependencies on the global system instance 
With this, the kernel finally doesn't depend directly on the global
system instance anymore.
 2020-09-14 14:03:13 -04:00
bunnei
042567e4b2
Merge pull request #4636 from lioncash/kernel-hle 
service: Remove two usages of the global system accessor
 2020-09-14 09:17:10 -07:00
bunnei
5fc6bf96d8
Merge pull request #4323 from ReinUsesLisp/no-spin 
kernel/scheduler: Use std::mutex instead of spin lock
 2020-09-11 23:23:53 -07:00
bunnei
ec634b6a88
Merge pull request #4634 from lioncash/blocking 
bsd: Resolve a few warnings
 2020-09-11 15:17:34 -07:00
bunnei
324029d4f9
Merge pull request #4310 from ogniK5377/apollo-1-prod 
audio_core: Apollo Part 1, AudioRenderer refactor
 2020-09-11 10:57:27 -04:00
bunnei
03179ecafe
Merge pull request #4597 from Morph1984/mjolnir-p2 
Project Mjölnir: Part 2 - Controller Applet
 2020-09-10 19:28:23 -04:00
FearlessTobi
57162e1df3 Test: Decrease pad_update_ns 
There have been reports of quite heavy input lag in the past.
Compared to Citra for example, our pad_update_ns value is very high.
So let's decrease it and see if it helps with this problem.
 2020-09-10 16:38:53 +02:00
Rodrigo Locatti
663ea382da
Merge pull request #4633 from ReinUsesLisp/gpu-init 
video_core: Remove all Core::System references in renderer
 2020-09-10 02:28:54 +00:00
Lioncash
ffdf8c0cb3 service: Remove two usages of the global system accessor 
Removes more instances of reliance on global state.
 2020-09-07 03:18:45 -04:00
Lioncash
40968e3993 bsd: Resolve unused value within SendToImpl 
Previously the address provided to SendToImpl would never be propagated
to SendTo(). This fixes that.
 2020-09-07 01:06:30 -04:00
Lioncash
cd643ab5c9 bsd: Resolve sign comparison warnings 2020-09-07 01:06:27 -04:00
Lioncash
180fa6859f sockets_translate: Make use of designated initializers 
Same behavior, less typing.
 2020-09-07 00:53:10 -04:00
Lioncash
188a3cf74c blocking_worker: Make use of templated lambda 
We can simplify this a little by explicitly specifying the typename for
the lambda function.
 2020-09-07 00:47:46 -04:00
Lioncash
9652973db2 blocking_worker: Resolve -Wdocumentation warning 2020-09-07 00:45:53 -04:00
ReinUsesLisp
9e87193725 video_core: Remove all Core::System references in renderer 
Now that the GPU is initialized when video backends are initialized,
it's no longer needed to query components once the game is running: it
can be done when yuzu is booting.

This allows us to pass components between constructors and in the
process remove all Core::System references in the video backend.
 2020-09-06 05:28:48 -03:00
bunnei
e126021ffe
Merge pull request #4397 from ReinUsesLisp/bsd 
services: Implement most of bsd:s and GetCurrentIpAddress from nifm
 2020-09-05 22:40:59 -04:00
Morph
5b6268d26a configure_input: Hook up the motion button and checkbox 
This allows toggling motion on or off, and allows access to the motion configuration.
Also changes the [waiting] text for motion buttons to Shake! as this is how motion is connected to a player.
 2020-09-05 09:46:34 -04:00
german
6ee8eab670 Add cemu hook changes related to PR #4609 2020-09-04 21:48:13 -05:00
german
0774b17846 Remove RealMotionDevice 2020-09-04 21:48:13 -05:00
Morph
df3cbd4758 controllers/npad: Simplify motion entry assignment 
Simplifies the motion assignment in the Dual Joycon entry and assigns index 1 of the motion entry (Motion 2) for the right joycon.
 2020-09-04 21:48:13 -05:00
german
ff679f3d17 Include HID and configuration changes related to motion 2020-09-04 21:48:03 -05:00
Morph
0e33b19ae0 hid: Implement MergeSingleJoyasDualJoy 
- Used in multiple games such as Super Mario Odyssey.
 2020-09-04 15:38:33 -04:00
Morph
b65456b958 applets/controller: Resolve several compiler warnings 
Resolves -Wsign-compare and -Wunused-variable
 2020-09-04 12:23:26 -04:00
Morph
076e4d44c3 Address feedback 2020-09-04 12:23:25 -04:00
Morph
f95ea04995 applets/controller: Set min_players to have a minimum value of 1. 
- Some games like Shipped have a minimum requirement of 0 connected players and is undesired behavior. We must require a minimum of 1 player connected regardless of what games may ask.
 2020-09-04 12:23:25 -04:00
Morph
371226448a applets/controller: Modify heuristic to account for certain games 
Now left and right joycons have the same priority (meaning both needs to be supported by the game).

Explanation of the new heuristic:
Assign left joycons to even player indices and right joycons to odd player indices.
We do this since Captain Toad Treasure Tracker expects a left joycon for Player 1 and a right Joycon for Player 2 in 2 Player Assist mode.
 2020-09-04 12:23:25 -04:00
Morph
7299356f37 applets/controller: Implement fallback applet for the SDL frontend 
Implement the fallback applet for the SDL frontend, connecting only the minimum amount of players required.
 2020-09-04 12:23:25 -04:00
Morph
5ce3015945 applets/controller: Implement "Explain Text" 
"Explain Text" is additional text that is shown for each player in the controller applet.
 2020-09-04 12:23:25 -04:00
Morph
5219615418 Project Mjölnir: Part 2 - Controller Applet 
Co-authored-by: Its-Rei <kupfel@gmail.com>
 2020-09-04 12:23:25 -04:00
bunnei
ba5419b965
Merge pull request #4590 from ReinUsesLisp/tsan-sched 
hle/scheduler: Fix data race in is_context_switch_pending
 2020-09-03 14:39:57 -04:00
ReinUsesLisp
827ff077e7 file_sys/patch_manager: Add missing include 
Fixes build issues
 2020-09-03 04:51:49 -03:00
bunnei
38980b2471
Merge pull request #4568 from lioncash/fsp 
fsp_srv: Resolve -Wmaybe_uninitialized warning in OpenSaveDataFileSystem()
 2020-09-02 23:07:03 -04:00
bunnei
57e43682ed
Merge pull request #4564 from lioncash/file-include 
file_sys: Replace inclusions with forward declarations where applicable
 2020-09-02 23:06:38 -04:00
bunnei
3dcccabd1d
Merge pull request #4382 from FearlessTobi/port-udp-config 
yuzu: Add motion and touch configuration from Citra
 2020-09-01 13:56:37 -04:00
bunnei
a1f13a3662
Merge pull request #4589 from ReinUsesLisp/tsan-host 
hle/kernel: Fix data race in GetCurrentHostThreadID
 2020-08-31 21:20:49 -04:00
LC
b5ed2d408c
Merge pull request #4461 from comex/thread-names 
Fix thread naming on Linux, which limits names to 15 bytes.
 2020-08-31 15:31:48 -04:00
FearlessTobi
d1e1ea0fef Address second batch of reviews 2020-08-30 00:43:25 +02:00
FearlessTobi
e6bd1fd1b8 yuzu: Add motion and touch configuration 2020-08-29 18:56:34 +02:00
bunnei
40320a1d84
Merge pull request #4586 from yuzu-emu/tsan-cpu-interrupt 
cpu_interrupt_handler: Make is_interrupted an atomic
 2020-08-28 09:21:47 -04:00
Morph
eb149ec696 controllers/npad: Fix inconsistencies with controller connection statuses 2020-08-26 02:32:32 -04:00
Morph
334ef2efdd controllers/npad: Fix LibNX controller connection statuses 
This allows homebrew applications to be able to properly detect connected controllers.
 2020-08-26 02:32:32 -04:00
Morph
e7c174b426 controllers/npad: Fix LedPattern for P1-4 2020-08-26 02:32:32 -04:00
Morph
f0fac0c7fb Project Mjölnir: Part 1 
Co-authored-by: James Rowe <jroweboy@gmail.com>
Co-authored-by: Its-Rei <kupfel@gmail.com>
 2020-08-26 02:32:32 -04:00
ReinUsesLisp
ccdd84a778 hle/scheduler: Fix data race in is_context_switch_pending 
As reported by tsan, SelectThreads could write to
is_context_switch_pending holding a mutex while SwitchToCurrent reads it
without holding any.

It is assumed that the author didn't want an atomic here, so the code is
reordered so that whenever is_context_switch_pending is read inside
SwitchToContext, the mutex is locked.
 2020-08-26 02:56:05 +00:00
ReinUsesLisp
36eade7f4c hle/kernel: Fix data race in GetCurrentHostThreadID 
As reported by tsan, host_thread_ids could be read while
any of the RegisterHostThread variants were called.

To fix this, lock the register mutex when yuzu is running in multicore
mode and GetCurrentHostThreadID is called.
 2020-08-26 02:52:50 +00:00
ReinUsesLisp
56ac22f737 cpu_interrupt_handler: Misc style changes 2020-08-26 02:43:26 +00:00
ReinUsesLisp
ea7bda25ba cpu_interrupt_handler: Make is_interrupted an atomic 
Fixes a race condition detected from tsan
 2020-08-26 02:43:15 +00:00
bunnei
dd828607e0
Merge pull request #4563 from lioncash/rcache 
registered_cache: Make use of designated initializers
 2020-08-25 10:07:33 -04:00
M&M
43ce33b6cc logging/settings: Increase maximum log size to 100 MB and add extended logging option 
The extended logging option is automatically disabled on boot but can be enabled afterwards, allowing the log file to go up to 1 GB during that session.
This commit also fixes a few errors that are present in the general debug menu.
 2020-08-24 21:39:56 -07:00
bunnei
6fd3a1bf85
Merge pull request #4562 from lioncash/loop 
cpu_manager: Make use of ranged for where applicable
 2020-08-24 17:58:41 -04:00
bunnei
ab350b8975
Merge pull request #4561 from lioncash/key-constexpr 
key_manager: Make data arrays constexpr
 2020-08-23 20:41:05 -04:00
bunnei
42a00877a2
Merge pull request #4549 from lioncash/files 
vfs_real: Avoid redundant map lookups
 2020-08-23 19:08:36 -04:00
Lioncash
4c1a95ed61 fsp_srv: Resolve -Wunused-but-set-variable warning 
We can just log out the parameters in the meantime.
 2020-08-23 17:16:32 -04:00
Lioncash
01d1b5cdaf file_sys: Replace inclusions with forward declarations where applicable 
Same behavior, minus unnecessary inclusions where not necessary.
 2020-08-23 17:02:55 -04:00
Lioncash
85db5f4091 fsp_srv: Resolve -Wmaybe_uninitialized warning in OpenSaveDataFileSystem() 
Initialize id to a deterministic value and also mark the unreachable
cases in the switch with UNREACHABLE().
 2020-08-23 16:37:57 -04:00
Lioncash
67a8e73101 registered_cache: Make use of ends_with for string suffix checking 
Simplifies code.
 2020-08-23 11:25:45 -04:00
Lioncash
f83c6e1e0c registered_cache: Make use of designated initializers 
Removes the need for comments to indicate the fields being assigned.
 2020-08-23 10:26:20 -04:00
bunnei
cfb7fd395c
Merge pull request #4560 from lioncash/convert 
core_timing: Resolve sign conversion warning
 2020-08-23 02:11:14 -04:00
Lioncash
b62a8ca43e key_manager: Make data arrays constexpr 
We can convert these maps into constexpr arrays to eliminate some
runtime static constructors.
 2020-08-22 22:47:24 -04:00
Lioncash
544fbd5c84 cpu_manager: Make use of ranged for where applicable 
We can simplify a few loops by making use of ranged for.
 2020-08-22 22:43:19 -04:00
Lioncash
79504f1a39 core_timing: Remove unused header 2020-08-22 22:12:37 -04:00
Lioncash
25cd5d9dda core_timing: Move clock initializer into constructor initializer list 
Same behavior, minus unnecessary zeroing out of the pointer.
 2020-08-22 20:26:48 -04:00
Lioncash
2624b1eae6 core_timing: Resolve sign conversion warning 
This constant is only ever assigned to downcount, which is a s64, not a
u64.
 2020-08-22 20:26:45 -04:00
bunnei
66ac7cf730
Merge pull request #4541 from MerryMage/yolo 
dynarmic: Add unsafe optimizations
 2020-08-21 23:06:21 -04:00
Lioncash
f6bb905182 common/telemetry: Migrate namespace into the Common namespace 
Migrates the Telemetry namespace into the Common namespace to make the
code consistent with the rest of our common code.
 2020-08-18 15:08:32 -04:00
Lioncash
551882e512 vfs_real: Resolve sign conversion warnings 2020-08-18 14:58:33 -04:00
Lioncash
ed9ae5a977 vfs_real: Avoid redundant map lookups 
Avoids some trivially avoidable map lookups by keeping the result of
find operations around and querying them.
 2020-08-18 14:58:29 -04:00
bunnei
56c6a5def8
Merge pull request #4535 from lioncash/fileutil 
common/fileutil: Convert namespace to Common::FS
 2020-08-17 22:35:30 -04:00
bunnei
0530dd6ea1
Merge pull request #4494 from lioncash/transcode 
aes_util: Make use of non-template variant of Transcode
 2020-08-17 03:50:35 -04:00
MerryMage
836ec9176a dynarmic: Add unsafe optimizations 2020-08-16 14:15:39 +01:00
Lioncash
c4ed791164 common/fileutil: Convert namespace to Common::FS 
Migrates a remaining common file over to the Common namespace, making it
consistent with the rest of common files.

This also allows for high-traffic FS related code to alias the
filesystem function namespace as

namespace FS = Common::FS;

for more concise typing.
 2020-08-16 06:52:40 -04:00
bunnei
2b601e8636
Merge pull request #4526 from lioncash/core-semi 
core: Resolve several -Wextra-semi warnings
 2020-08-15 02:14:11 -04:00
bunnei
e6f9231ef0
Merge pull request #4527 from lioncash/pessimizing2 
software_keyboard: Resolve a pessimizing move warning
 2020-08-15 02:13:44 -04:00
bunnei
cb6808b4d0
Merge pull request #4492 from lioncash/linkage 
system_control: Make functions internally linked where applicable
 2020-08-15 02:11:49 -04:00
bunnei
2aabd1eb05
Merge pull request #4463 from lioncash/lockdiscard 
kernel/scheduler: Mark SchedulerLock constructor as nodiscard
 2020-08-15 01:31:23 -04:00
Lioncash
b14277ef97 time_zone_content_manager: Collapse auto and default case 
Prevents a useless self-assignment from occurring.
 2020-08-14 10:58:58 -04:00
Lioncash
03d5a5d9de software_keyboard: Resolve a pessimizing move warning 
A std::vector created in place like this is already an rvalue and
doesn't need to be moved.
 2020-08-14 09:14:54 -04:00
Lioncash
2296e921d2 core: Resolve several -Wextra-semi warnings 
We can amend one of the cascade macros to require semicolons in order to
compile. In other cases, we can just remove the superfluous semicolons.
 2020-08-14 09:09:20 -04:00
Lioncash
a93f6e51d3 emu_window: Mark Scoped constructor and Acquire() as nodiscard 
Ensures that callers make use of the constructor, preventing bugs from
silently occurring.
 2020-08-14 04:43:44 -04:00
Lioncash
f808258ed9 kernel/scheduler: Mark SchedulerLock constructor as nodiscard 
Allows the compiler to warn about cases where the constructor is used
but then immediately discarded, which is a potential cause of
locking/unlocking bugs.
 2020-08-14 04:43:44 -04:00
Rodrigo Locatti
e050594706
Merge pull request #4495 from lioncash/conv 
cheat_engine: Resolve implicit bool->u64 conversion
 2020-08-14 03:10:17 -03:00
LC
ff0b14ee62
Merge pull request #4511 from lioncash/build2 
General: Tidy up clang-format warnings part 2
 2020-08-13 15:13:21 -04:00
Lioncash
b724a4d90c General: Tidy up clang-format warnings part 2 2020-08-13 14:19:08 -04:00
bunnei
a8ffe6eee4
Merge pull request #4497 from lioncash/freezer-alg 
freezer: Make use of std::erase_if
 2020-08-11 23:07:17 -04:00
bunnei
257b1d2c4b
Merge pull request #4496 from lioncash/ce-desig 
cheat_engine: Make use of designated initializers
 2020-08-10 13:53:43 -04:00
bunnei
acfd771e79
Merge pull request #4491 from lioncash/unused-vars 
kernel: Remove unused variables
 2020-08-10 12:04:30 -04:00
bunnei
664019954a
Merge pull request #4488 from lioncash/file 
vfs_vector: Make creation of array vfs files less verbose
 2020-08-09 17:19:34 -04:00
bunnei
929fc849e9
Merge pull request #4457 from ogniK5377/SetScreenShotPermission 
am: Unstub SetScreenShotPermission
 2020-08-07 09:34:20 -04:00
Lioncash
8e86fa7e60 common/concepts: Rename IsBaseOf to DerivedFrom 
This makes it more inline with its currently unavailable standardized
analogue std::derived_from.

While we're at it, we can also make the template match the requirements
of the standardized variant as well.
 2020-08-07 08:09:57 -04:00
bunnei
f5d538f118
Merge pull request #4483 from lioncash/constexpr-hex 
partition_data_manager: Make data arrays constexpr
 2020-08-06 23:14:14 -04:00
bunnei
5cc2f99fab
Merge pull request #4490 from lioncash/arbiter 
address_arbiter/scheduler: Resolve sign conversion warnings
 2020-08-06 22:28:11 -04:00
Lioncash
61cd7eb47d freezer: Move entry finding to its own function 
Cleans up the callsites in other functions.
 2020-08-06 03:11:21 -04:00
Lioncash
06ab28263b freezer: Take address values by value 
VAddr will always be 64-bit, so there's no need to take a trivial
primitive alias by reference.
 2020-08-06 03:04:54 -04:00
Lioncash
253a17451b freezer: Make use of std::erase_if 
With C++20 we can simplify the erasing idiom.
 2020-08-06 03:03:05 -04:00
Lioncash
5b89291308 cheat_engine: Resolve implicit bool->u64 conversion 
We can just return zero here.
 2020-08-06 02:55:47 -04:00
Lioncash
df96a214ae cheat_engine: Make use of designated initializers 
Same behavior, but makes the member being assigned obvious.
 2020-08-06 02:48:13 -04:00
Lioncash
4f2acc54f5 partition_data_manager: Update master key hashes 
Fills in some hashes that were previously unhandled.
 2020-08-06 02:42:01 -04:00
Lioncash
7f0f37fca7 partition_data_manager: Make data arrays constexpr 
Previously the constructor for all of these would run at program
startup, consuming time before the application can enter main().

This is also particularly dangerous, given the logging system wouldn't
have been initialized properly yet, yet the program would use the logs
to signify an error.

To rectify this, we can replace the literals with constexpr functions
that perform the conversion at compile-time, completely eliminating the
runtime cost of initializing these arrays.
 2020-08-06 02:41:58 -04:00
Lioncash
04bb47f57f partition_data_manager: Eliminate magic value 
We can use sizeof to make it obvious at the call site where the value is
coming from.
 2020-08-06 02:34:10 -04:00
Lioncash
09f884b7bd aes_util: Make use of non-template variant of Transcode 
Same behavior, less template instantiations.
 2020-08-06 02:31:19 -04:00
comex
d37f0b29e2 Fix thread naming on Linux, which limits names to 15 bytes. 
- In `SetCurrentThreadName`, when on Linux, truncate to 15 bytes, as (at
  least on glibc) `pthread_set_name_np` will otherwise return `ERANGE` and
  do nothing.
- Also, add logging in case `pthread_set_name_np` returns an error
  anyway.  This is Linux-specific, as the Apple and BSD versions of
  `pthread_set_name_np return `void`.
- Change the name for CPU threads in multi-core mode from
  "yuzu:CoreCPUThread_N" (19 bytes) to "yuzu:CPUCore_N" (14 bytes) so it
  fits into the Linux limit.  Some other thread names are also cut off,
  but I didn't bother addressing them as you can guess them from the
  truncated versions.  For a CPU thread, truncation means you can't see
  which core it is!
 2020-08-05 20:34:49 -07:00
bunnei
1cc0e4b4d8
Merge pull request #4489 from lioncash/typesafe 
ipc_helpers: Only allow trivially copyable objects with PushRaw() and PopRaw()
 2020-08-05 23:20:23 -04:00
bunnei
35c1607f23
Merge pull request #4484 from lioncash/aesutil 
aes_util: Allow SetIV() to be non-allocating
 2020-08-05 22:35:41 -04:00
bunnei
61678c4e9f
Merge pull request #4475 from lioncash/bqueue 
buffer_queue: Make use of designated initializers/std::nullopt where applicable
 2020-08-05 16:56:46 -04:00
Lioncash
87c64c41d2 system_control: Make functions internally linked where applicable 
These functions are only ever used internally as implementation details
for GenerateRandomRange(), so these can be given internal linkage.
 2020-08-05 15:34:27 -04:00
Lioncash
a10d64ea79 kernel: Remove unused variables 
Resolves a few compiler warnings.
 2020-08-05 15:19:48 -04:00
Lioncash
9893da8e2c scheduler: Resolve sign conversion warning 2020-08-05 15:12:29 -04:00
Lioncash
1a45b15a8c address_arbiter: Resolve sign conversion warning 
Makes our type conversion explicit.
 2020-08-05 15:07:19 -04:00
bunnei
4a2d9c6454
Merge pull request #4444 from lioncash/volatile 
common/atomic_ops: Don't cast away volatile from pointers
 2020-08-05 14:22:36 -04:00
Lioncash
a77ee63f65 ipc_helpers: Only allow trivially copyable objects with PushRaw() and PopRaw() 
It's undefined behavior to use non-trivially copyable objects with
std::memcpy, so we can add asserts to catch usages of these at
compile-time.
 2020-08-05 14:08:28 -04:00
Lioncash
0a5456feb9 vfs_vector: Make creation of array vfs files less verbose 
We can add a helper function to make creation of these files nicer.
While we're at it, we can eliminate an unnecessary std::array copy in
the constructor. This makes the overhead on some of these functions way
less intensive, given some arrays were quite large.

e.g. The timezone location names are 9633 bytes in size.
 2020-08-05 12:37:00 -04:00
bunnei
07691f994a
Merge pull request #4466 from ogniK5377/loader-type-safe 
loader: Make IdentifyFile typesafe
 2020-08-05 12:34:25 -04:00
bunnei
142930e609
Merge pull request #4476 from lioncash/tz 
time_zone_binary: Make use of designated initializers
 2020-08-04 18:56:28 -04:00
bunnei
ba9ed7b1fe
Merge pull request #4401 from ogniK5377/GetIndirectLayerImageRequiredMemoryInfo 
vi: IApplicationDisplayService:GetIndirectLayerImageRequiredMemoryInfo
 2020-08-04 18:45:11 -04:00
bunnei
f11628b9b7
Merge pull request #4430 from bunnei/new-gpu-vmm 
hle: nvdrv: Rewrite of GPU memory management.
 2020-08-04 18:44:26 -04:00
bunnei
ecbee11829
Merge pull request #4472 from lioncash/const-get 
perf_stats: Mark GetMeanFrametime() as const
 2020-08-04 07:00:23 -07:00
David
741cbbdc0e
Merge pull request #4470 from lioncash/qualifier 
patch_manager: Resolve -Wignored-qualifier warnings
 2020-08-04 14:09:48 +10:00
David
723314b682
Merge pull request #4481 from lioncash/cpp-dep 
yuzu: Resolve C++20 deprecation warnings related to lambda captures
 2020-08-04 14:06:07 +10:00
David
25fb7cd16d
Merge pull request #4474 from lioncash/hle-profile 
profile_manager: Make use of designated initializers
 2020-08-04 13:51:15 +10:00
bunnei
c6e5a36452
Merge pull request #4473 from lioncash/cheat-desig 
dmnt_cheat_vm: Make use of designated initializers
 2020-08-03 18:07:17 -07:00
bunnei
0dbb95c42d
Merge pull request #4456 from Morph1984/stub-really-long-fs-func 
fsp-srv: Stub Read/WriteSaveDataFileSystemExtraDataWithMaskBySaveDataAttribute
 2020-08-03 18:06:48 -07:00
Lioncash
15660bd857 aes_util: Allow SetIV to be non-allocating 
In a few places, the data to be set as the IV is already within an array.
We shouldn't require this data to be heap-allocated if it doesn't need
to be. This allows certain callers to reduce heap churn.
 2020-08-03 14:29:58 -04:00
bunnei
9808f244cc
Merge pull request #4482 from lioncash/ldr-sign 
service/ldr: Resolve sign mismatch warnings
 2020-08-03 11:27:13 -07:00
bunnei
a971667d1f
Merge pull request #4468 from lioncash/regcache 
registered_cache: Resolve -Wmaybe_uninitialized warnings
 2020-08-03 11:26:45 -07:00
bunnei
94c1689ef3
Merge pull request #4471 from ogniK5377/sm-getservice-concept 
sm: Make use of IsBaseOf for GetService
 2020-08-03 11:11:22 -07:00
Lioncash
570150bc86 perf_stats: Make use of designated initializers 
Same behavior, but allows us to avoid a now-unnecessary zero
initialization.
 2020-08-03 12:33:40 -04:00
Lioncash
d767be65be perf_stats: Mark GetMeanFrametime() as const 
The general pattern is to mark mutexes as mutable when it comes to
matters of constness, given the mutex acts as a transient member of a
data structure.
 2020-08-03 12:33:35 -04:00
Lioncash
b249e4e0ce yuzu: Resolve C++20 deprecation warnings related to lambda captures 
C++20 deprecates capturing the this pointer via the '=' capture.
Instead, we replace it or extend the capture specification.
 2020-08-03 11:54:04 -04:00
Lioncash
f525da56e5 service/ldr: Resolve sign mismatch warnings 
We were performing an int < size_t comparison. We can just correct the
type of the induction variable.
 2020-08-03 11:48:16 -04:00
bunnei
3697fc8d14
Merge pull request #4467 from lioncash/mode 
file_sys/mode: Make use of DECLARE_ENUM_FLAG_OPERATORS with Mode
 2020-08-03 08:07:56 -07:00
Lioncash
04ca1ed2bd time_zone_binary: Make use of designated initializers 2020-08-03 10:42:38 -04:00
Lioncash
9b837c6069 buffer_queue: Make use of std::nullopt 
Allows compilers to eliminate unnecessary zeroing out of the optional's
buffer.
 2020-08-03 09:31:51 -04:00
Lioncash
24bd068a08 buffer_queue: Make use of designated initializers 2020-08-03 09:31:51 -04:00
Lioncash
b9831fd80a profile_manager: Make use of std::nullopt 
Allows some implementations to completely avoid unnecessarily zeroing
out the internal buffer.
 2020-08-03 09:03:42 -04:00
Lioncash
3fcaf937d2 profile_manager: Make use of designated initializers 
More compact code.
 2020-08-03 09:01:31 -04:00
Lioncash
c883666045 dmnt_cheat_vm: Make use of designated initializers 
Allows for more compact code.
 2020-08-03 08:50:51 -04:00
Lioncash
2b8ae009a0 file_sys/mode: Make use of DECLARE_ENUM_FLAG_OPERATORS with Mode 
Same behavior, minus a hand-rolled operator.
 2020-08-03 07:52:36 -04:00
David Marcec
6a0b77996b sm: Make use of IsBaseOf for GetService 2020-08-03 21:46:14 +10:00
Lioncash
1c6d3ba397 patch_manager: Resolve -Wignored-qualifier warnings 
Top level const will always be ignored in this case, so it can be
removed.
 2020-08-03 07:42:56 -04:00
Lioncash
4ca0014479 registered_cache: Resolve -Wmaybe_uninitialized warnings 
While we're at it, we can avoid a redundant map lookup.
 2020-08-03 07:34:46 -04:00
David Marcec
a5af1161c9 Place in anonymous namespace 2020-08-03 21:31:28 +10:00
David Marcec
6cfff2c3f6 loader: Make IdentifyFile typesafe 
Relies on #4465 for concept.h Common::IsBaseOf
 2020-08-03 21:31:27 +10:00
David
9b75481755
ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer (#4465) 
* ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer

With the support of C++20, we can use concepts to deduce if a type is an STL container or not.

* More agressive concept for stl containers

* Add -fconcepts

* Move to common namespace

* Add Common::IsBaseOf
 2020-08-03 07:28:54 -04:00
David
0ca42c806f
Merge pull request #4439 from lioncash/cpu 
cpu_manager: Remove redundant std::function declarations
 2020-08-03 20:58:31 +10:00
Morph
fc86cb4ca2 minor nits 2020-07-31 11:02:59 -04:00
David Marcec
e586921c28 am: Unstub SetScreenShotPermission 2020-08-01 00:44:14 +10:00
Morph
1241020093 fsp-srv: Stub Read/WriteSaveDataFileSystemExtraDataWithMaskBySaveDataAttribute 
Stub these 2 service commands required for Animal Crossing: New Horizons Update 1.4.0
 2020-07-30 15:39:44 -04:00
Morph
45fd67c109 fs: Rename SaveDataDescriptor to SaveDataAttribute 2020-07-30 15:29:39 -04:00
Morph
ed46f3c62a xts_archive: Check if the file is nullptr prior to parsing 
Fixes an access violation where the file no longer exists at the specified path while being parsed.
 2020-07-29 06:50:30 -04:00
Morph
2ec852dd9f registered_cache: Add support for removing folder ncas 2020-07-29 06:50:30 -04:00
bunnei
b205b12e75
Merge pull request #4442 from lioncash/devicemem 
device_memory: Remove unused system member
 2020-07-28 13:03:30 -07:00
Morph
8d42456dc2 configure_graphics: Remove Force 30 FPS mode 
The introduction of multicore rendered this setting non-functional as timing code was changed.

This removes the setting entirely.
 2020-07-28 08:07:26 -04:00
Lioncash
e3f0c93230 common/atomic_ops: Don't cast away volatile from pointers 
Preserves the volatility of the pointers being casted.
 2020-07-28 04:36:53 -04:00
ReinUsesLisp
bc699ace15 service/bsd: Handle Poll with no entries accurately 
Testing shows that Poll called with zero entries returns -1 and signals
an errno of zero.
 2020-07-28 01:51:47 -03:00
ReinUsesLisp
f7d59f3e0e services/bsd: Implement most of bsd:s 
This implements: Socket, Poll, Accept, Bind, Connect, GetPeerName,
GetSockName, Listen, Fcntl, SetSockOpt, Shutdown, Recv, RecvFrom,
Send, SendTo, Write, and Close

The implementation was done referencing: SwIPC, switchbrew, testing
with libnx and inspecting its code, general information about bsd
sockets online, and analysing official software.

Not everything from these service calls is implemented, but everything
that is not implemented will be logged in some way.
 2020-07-28 01:48:42 -03:00
ReinUsesLisp
2c67bbf609 service/sockets: Add worker pool abstraction 
Manage worker threads with an easy to use abstraction.
We can expand this to support thread deletion in the future.
 2020-07-28 01:47:03 -03:00
ReinUsesLisp
5692c48ab7 service/sockets: Add worker abstraction to execute blocking calls asynchronously 
This abstraction allows executing blocking functions (like recvfrom on a
socket configured for blocking) without blocking the service thread.
It is intended to be used with SleepClientThread.
 2020-07-28 01:47:03 -03:00
ReinUsesLisp
80b4bd3583 service/sockets: Add translate functions 
These functions translate from Network enumerations/structures to guest
enumerations/structures and viceversa.
 2020-07-28 01:47:03 -03:00
ReinUsesLisp
22263ccaa4 service/sockets: Add enumerations and structures 
Add guest enumerations and structures used in socket services
 2020-07-28 01:47:03 -03:00
ReinUsesLisp
ef8acc9c3d services/nifm: Implement GetCurrentIpAddress 
This is trivially implemented using the Network abstraction

- Used by ftpd
 2020-07-28 01:47:03 -03:00
Lioncash
2258f33ee4 device_memory: Remove unused system member 
This isn't used by anything in particular, so it can be removed.
 2020-07-27 23:37:49 -04:00
Lioncash
989ad52dc1 cpu_manager: Remove redundant std::function declarations 
We can just return the function directly. Making for less reading.
 2020-07-27 21:57:05 -04:00
bunnei
db94457205
Update src/core/hle/service/nvdrv/devices/nvmap.cpp 
Co-authored-by: LC <mathew1800@gmail.com>
 2020-07-27 18:27:20 -07:00
Lioncash
a7af349dae core_timing: Make use of uintptr_t to represent user_data 
Makes the interface future-proofed for supporting other platforms in the event we ever support platforms with differing pointer sizes. This way, we have a type in place that is always guaranteed to be able to represent a pointer exactly.
 2020-07-27 21:21:01 -04:00
CrazyMax
1ffff4dab2 remove unused variable; 2020-07-27 10:36:26 +03:00
bunnei
05def61398 hle: nvdrv: Rewrite of GPU memory management. 2020-07-26 00:49:43 -04:00
Lioncash
7b070bbf62 nvflinger: Mark interface functions with return values as [[nodiscard]] 
Not using the return value of these functions are undeniably the source
of a bug. This way we allow compilers to loudly make any future misuses
evident.
 2020-07-25 19:42:45 -04:00
Lioncash
5dab23e017 nvflinger: Use return value of Lock() 
comex reported in #4424 that we were incorrectly discarding the return
value of Lock() which is correct.
 2020-07-25 19:04:53 -04:00
bunnei
a2e1810287
Merge pull request #4350 from ogniK5377/hid-update-connected 
hid: Only update keyboard & debug pad inputs if enabled
 2020-07-25 11:57:24 -07:00
bunnei
d046e9b458
Merge pull request #4380 from ogniK5377/swkbd-inline-1 
swkbd: Return result for Calc request for inlined swkbd
 2020-07-24 22:31:24 -07:00
David Marcec
380658c21d audio_core: Apollo Part 1, AudioRenderer refactor 2020-07-25 12:39:34 +10:00
Jan Beich
f99be1c923 network: add missing include for BSDs 
src/core/network/network.cpp:112:28: error: use of undeclared identifier 'SHUT_RD'
constexpr int SD_RECEIVE = SHUT_RD;
                           ^
src/core/network/network.cpp:113:25: error: use of undeclared identifier 'SHUT_WR'
constexpr int SD_SEND = SHUT_WR;
                        ^
src/core/network/network.cpp:114:25: error: use of undeclared identifier 'SHUT_RDWR'
constexpr int SD_BOTH = SHUT_RDWR;
                        ^
src/core/network/network.cpp:120:37: error: unknown type name 'in_addr'; did you mean 'in_addr_t'?
constexpr IPv4Address TranslateIPv4(in_addr addr) {
                                    ^~~~~~~
                                    in_addr_t
/usr/include/netdb.h:66:20: note: 'in_addr_t' declared here
typedef __uint32_t      in_addr_t;
                        ^
src/core/network/network.cpp:121:27: error: member reference base type 'in_addr_t' (aka 'unsigned int') is not a structure or union
    const u32 bytes = addr.s_addr;
                      ~~~~^~~~~~~
src/core/network/network.cpp:121:15: error: variables defined in a constexpr function must be initialized
    const u32 bytes = addr.s_addr;
              ^
src/core/network/network.cpp:126:10: error: incomplete result type 'sockaddr' in function definition
sockaddr TranslateFromSockAddrIn(SockAddrIn input) {
         ^
/usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr'
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:127:5: error: unknown type name 'sockaddr_in'; did you mean 'sockaddr'?
    sockaddr_in result;
    ^~~~~~~~~~~
    sockaddr
/usr/include/netdb.h:142:9: note: 'sockaddr' declared here
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:127:17: error: variable has incomplete type 'sockaddr'
    sockaddr_in result;
                ^
/usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr'
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:131:29: error: use of undeclared identifier 'AF_INET'
        result.sin_family = AF_INET;
                            ^
src/core/network/network.cpp:135:29: error: use of undeclared identifier 'AF_INET'
        result.sin_family = AF_INET;
                            ^
src/core/network/network.cpp:139:23: error: use of undeclared identifier 'htons'
    result.sin_port = htons(input.portno);
                      ^
src/core/network/network.cpp:143:14: error: variable has incomplete type 'sockaddr'
    sockaddr addr;
             ^
/usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr'
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:156:1: error: unknown type name 'linger'
linger MakeLinger(bool enable, u32 linger_value) {
^
src/core/network/network.cpp:157:5: error: unknown type name 'linger'
    linger value;
    ^
src/core/network/network.cpp:185:16: error: use of undeclared identifier 'AF_INET'
        return AF_INET;
               ^
src/core/network/network.cpp:195:16: error: use of undeclared identifier 'SOCK_STREAM'
        return SOCK_STREAM;
               ^
src/core/network/network.cpp:197:16: error: use of undeclared identifier 'SOCK_DGRAM'
        return SOCK_DGRAM;
               ^
src/core/network/network.cpp:207:16: error: use of undeclared identifier 'IPPROTO_TCP'
        return IPPROTO_TCP;
               ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
 2020-07-22 22:10:15 +00:00
David Marcec
8abb31a19d vi: IApplicationDisplayService:GetIndirectLayerImageRequiredMemoryInfo 
Needed for dark souls and monster hunter
 2020-07-21 23:06:18 +10:00
David
e9bfe05e04
Merge pull request #4306 from ReinUsesLisp/bsd-network 
core/network: Add network abstraction
 2020-07-21 16:05:47 +10:00
David Marcec
8248d76964 Address issues 2020-07-20 11:52:07 +10:00
David Marcec
d7d2c27b48 swkbd: Return result for Calc request for inlined swkbd 
Fixes random swkbd popups in monster hunter
 2020-07-19 18:56:16 +10:00
ReinUsesLisp
51817f6e59 core/network: Add network abstraction 
This commit adds a network abstraction designed to implement bsd:s but
at the same time work as a generic abstraction to implement any
networking code we have to use from core.

This is implemented on top of BSD sockets on Unix systems and winsock on
Windows. The code is designed around winsocks having compatibility
definitions to support both BSD and Windows sockets.
 2020-07-19 04:12:40 -03:00
bunnei
4a8cb9a706
Merge pull request #4348 from lioncash/nano 
core_timing: Make usage of nanoseconds more consistent in the interface
 2020-07-18 01:45:10 -04:00
bunnei
c700079e08
Merge pull request #4345 from Morph1984/fix-createfile 
filesystem: Create subdirectories prior to creating a file
 2020-07-18 00:59:26 -04:00
bunnei
90cbcaa44a
Merge pull request #4273 from ogniK5377/async-shaders-prod 
video_core: Add asynchronous shader decompilation and compilation
 2020-07-18 00:48:27 -04:00
bunnei
af1151b1b0
Merge pull request #4365 from lioncash/mii 
mii/manager: Make use of designated initializers
 2020-07-17 22:20:15 -04:00
bunnei
47b305387a
Merge pull request #4366 from lioncash/mii-sign 
mii/manager: Resolve sign mismatch warnings
 2020-07-17 20:13:06 -04:00
FearlessTobi
4d4bbe756f file_sys/nsp: Make SetTicketKeys actually do something 
Previously, the method wasn't modifying any class state and therefore not having any effects when called.
Since this has been the case for a very long time now, I'm not sure if we couldn't just remove this method altogether.
 2020-07-18 02:02:39 +02:00
bunnei
5d95e62443
Merge pull request #4344 from VolcaEM/c3 
dmnt_cheat_vm: Implement opcode 0xC3 (ReadWriteStaticRegister)
 2020-07-17 17:11:52 -04:00
bunnei
0f0b756775
Merge pull request #4309 from Morph1984/fix-romfs-bug 
fs: Fix RomFS building when zero byte files are present
 2020-07-17 17:01:20 -04:00
David Marcec
4f473cda64 Drop settings namespace 2020-07-17 17:23:24 +10:00
David Marcec
85d7a8f466 Rebase for per game settings 2020-07-17 14:26:14 +10:00
David
c783cf443e
Merge pull request #4347 from lioncash/logging 
settings: Make use of std::string_view over std::string for logging
 2020-07-17 13:25:06 +10:00
David
92f37a229e
Merge pull request #4371 from lioncash/cmake2 
core/CMakeLists: Add missing physical_memory.h header file
 2020-07-17 13:22:19 +10:00
David
adbf5ca50b
Merge pull request #4357 from lioncash/unused4 
kernel: Remove unused variables
 2020-07-17 13:18:31 +10:00
David
69f8b6a53e
Merge pull request #4358 from lioncash/unused5 
kernel/thread: Remove unimplemented function prototype
 2020-07-17 13:17:52 +10:00
Lioncash
311f500753 core/CMakeLists: Add missing physical_memory.h header file 
Allows this header file to show up in IDE CMake generators.
 2020-07-16 22:56:31 -04:00
Lioncash
e07eb5b223 constants: Add missing <array> include 
Eliminates reliance on an indirect include.
 2020-07-16 21:43:20 -04:00
Lioncash
e54c940abf mii/manager: Resolve sign mismatch warnings 
Previously the loop termination condition was testing variables of
different signedness.
 2020-07-16 21:07:04 -04:00
Lioncash
7f989378c0 mii/manager: Make use of designated initializers 
Allows returning the structure in a more concise manner.
 2020-07-16 20:45:33 -04:00
bunnei
3bbf4462db
Merge pull request #4292 from bunnei/mii-rewrite 
hle: service: mii: Rewrite service to properly support creation of random and default miis.
 2020-07-16 20:05:40 -04:00
Rodrigo Locatti
104c523d3d
Merge pull request #4327 from lioncash/desig2 
address_space_info: Make use of designated initializers
 2020-07-16 17:41:55 -03:00
Lioncash
8bef49cde5 kernel/thread: Remove unimplemented function prototype 
This isn't used, so it can be removed.
 2020-07-16 14:32:46 -04:00
Lioncash
2bab07c367 kernel: Remove unused variables 
Resolves some compiler warnings in the Linux build.
 2020-07-16 14:17:50 -04:00
Lioncash
07d080ecc8 kernel: Add missing include 2020-07-16 13:51:51 -04:00
Lioncash
f0125b2be8 cpu_manager: Mark function getters as static 
All these do are return std::function instances of static functions, so
these can be used without an instance of the CPU manager.
 2020-07-16 13:30:56 -04:00
Lioncash
51546ce57e cpu_manager: Remove unused preemption_count variable 
Shrinks the data structure by 8 bytes.
 2020-07-16 13:24:25 -04:00
Lioncash
201514cb50 cpu_manager: Add missing includes 
Previously this header was relying on indirect inclusions that are no
longer satisfied.
 2020-07-16 13:22:58 -04:00
bunnei
2781201bfb
Merge pull request #4337 from lat9nq/fix-per-game-async 
main: Set async gpu properly after loading per-game setting
 2020-07-16 11:33:51 -04:00
David
0648e023ea
Merge pull request #4346 from lioncash/thread 
kernel/handle_table: Remove usages of the global system instance
 2020-07-16 23:02:04 +10:00
David Marcec
0319cc1c37 hid: Only update keyboard & debug pad inputs if enabled 
Previously we would ignore this setting and would update the states regardless of the user setting
 2020-07-16 22:28:49 +10:00
David
815f30dc10
Merge pull request #4249 from Morph1984/delete-update-aoc-on-overwrite 
registered_cache: Remove previous update/dlc if it exists on install
 2020-07-16 20:36:22 +10:00
Morph
f66e3181dc Check for empty section0 and CNMT prior to install 2020-07-16 05:22:51 -04:00
Morph
5892fc1555 Add comment to clarify the nullptr check 2020-07-16 00:15:27 -04:00
Morph
2079bb4090 filesystem: Create subdirectories prior to creating a file 
If subdirectories exist in the given path parameter and don't exist in the real filesystem create them prior to creating the files within.
This fixes the softlocks upon save creation in The Legend of Zelda: Breath of the Wild
 2020-07-16 00:15:27 -04:00
bunnei
f26f53f35b
Merge pull request #4328 from lioncash/unused-var3 
memory_layout: Remove unused data member
 2020-07-15 22:08:05 -04:00
Lioncash
0435b7d361 core_timing: Remove unused data member 
Shrinks the size of the CoreTiming class by 8 bytes.
 2020-07-15 19:41:37 -04:00
Lioncash
bef1844a51 core_timing: Make TimedCallback take std::chrono::nanoseconds 
Enforces our desired time units directly with a concrete type.
 2020-07-15 19:41:22 -04:00
Lioncash
8b50c660df core_timing: Make use of std::chrono with ScheduleEvent 2020-07-15 18:54:15 -04:00
Lioncash
af5a56ddc4 settings: Resolve a sign conversion warning within GetTimeZoneString() 
A sign conversion warning was occurring due to an int < size_t
comparison.
 2020-07-15 13:45:22 -04:00
Lioncash
73bb87c06b kernel/process: Move name and system context to the bottom of the member list 
These aren't directly important or commonly used within the process, so
we can move these to the bottom to allow everything else to be more
likely to be within a cache line.
 2020-07-15 13:40:18 -04:00
Lioncash
52e83f0d5c kernel/handle_table: Remove usages of the global system instance 
Removes even more usages of the global system instance, trimming away
more dependencies on global variables and making them explicit in the
interface.
 2020-07-15 13:40:15 -04:00
Lioncash
5dbf91d739 settings: Make use of std::string_view over std::string for logging 
In all usages of LogSetting(), string literals are provided.
std::string_view is better suited here, as we won't churn a bunch of
string allocations every time the settings are logged out.

While we're at it, we can fold LogSetting() into LogSettings(), given
it's only ever used there.
 2020-07-15 13:37:33 -04:00
Lioncash
4ad69ca96e kernel/thread: Remove global GetCurrentThread() 
This is only used in one place, so we can fold it into the calling code,
eliminating a place for the global system instance to be used.
 2020-07-15 13:28:05 -04:00
Morph
0ca7b8269a clang format 2020-07-15 13:27:04 -04:00
Morph
1bbc61f5f1 Use proper install result when overwriting files 2020-07-15 13:27:04 -04:00
Morph
8794e623d9 Remove global system instance and address feedback 2020-07-15 13:27:04 -04:00
Morph
a82fdea1ac registered_cache: Remove previous update/dlc if it exists on install 
- This checks for and removes old updates or dlc based on title id. If a content meta nca exists within the registered cache, it will attempt to remove all the ncas associated with the content meta before installing a new update/dlc
 2020-07-15 13:27:04 -04:00
VolcaEM
e90802e762
clang-format 2020-07-15 01:22:52 +02:00
VolcaEM
b608acd688
dmnt_cheat_vm: Implement opcode 0xC3 (ReadWriteStaticRegister) 
This was based on Atmosphére's DMNT Cheat VM:

- https://github.com/Atmosphere-NX/Atmosphere/blob/master/stratosphere/dmnt/source/cheat/impl/dmnt_cheat_vm.hpp
- https://github.com/Atmosphere-NX/Atmosphere/blob/master/stratosphere/dmnt/source/cheat/impl/dmnt_cheat_vm.cpp

From Atmosphére's documentation: "Code type 0xC3 reads or writes a static register with a given register"

There are now only two remaining opcodes to implement (PauseProcess and BreakProcess)

This is untested because I don't have any experience in testing cheats on yuzu
 2020-07-15 01:19:22 +02:00
lat9nq
a683e42516 clang-format 2020-07-14 13:46:42 -04:00
lat9nq
6d1477f214 settings: Move settings sanitization to its own function 
Creates a new function that can be expanded later to fix other settings that are known to cause emulation errors across executables.
 2020-07-14 13:36:09 -04:00
bunnei
e2730372b8
Merge pull request #4294 from MerryMage/cpu-opt-settings 
configuration: Add settings to enable/disable specific CPU optimizations
 2020-07-14 12:38:03 -04:00
bunnei
450cbcfee6
Merge pull request #4282 from Morph1984/fs-size 
filesystem: Set various NAND partition sizes to their defaults
 2020-07-14 12:16:42 -04:00
Lioncash
f2f876e3ff memory_layout: Remove unused data member 
This isn't used, so it can be removed entirely, shrinking the structure
size by 8 bytes.
 2020-07-13 10:51:23 -04:00
Lioncash
ed0fe04b4f address_space_info: Use type alias to simplify code 
We can define an alias for the index arrays and then just reuse it to
make the code nicer to read.
 2020-07-13 10:42:52 -04:00
Lioncash
c3eb42de65 address_space_info: Make use of designated initializers 
We can alter the structure so that we can use designated initializers in
the array, eliminating the comments that indicate their field names.
 2020-07-13 10:42:49 -04:00
ReinUsesLisp
9b38f4fc55 kernel/scheduler: Use std::mutex instead of spin lock 
Profiling shows that this is a highly contested mutex, causing dimishing
results compared to a OS lock. std::mutex implementations can spin for a
while before falling back to an OS lock.

This avoids wasting precious CPU cycles in a no-op.
 2020-07-12 21:27:24 -03:00
Fernando Sahmkow
739d90ee66
Merge pull request #4265 from Morph1984/file-rename 
vfs_real: Fix MoveFile
 2020-07-12 13:00:09 -04:00
Morph
fd1c3aa14e fs: Fix RomFS building when zero byte files are present 
When zero byte files are present, the key (offset) for that file is identical to the file right after. A std::map isn't able to fit key-value pairs with identical keys (offsets), therefore, the solution is to use std::multimap which permits multiple entries with the same key.

This most prominently fixes Pokemon Sword and Shield weather with any RomFS mod applied.
 2020-07-12 04:33:35 -04:00
bunnei
e60733aad3
Merge pull request #4275 from CrazyMax/desired_language 
AM: fix GetDesiredLanguage:
 2020-07-12 01:45:08 -04:00
bunnei
e706501c8d hle: service: mii: Rewrite service to properly support creation of random and default miis. 2020-07-11 21:34:59 -04:00
MerryMage
505aa3a4c1 configure_cpu: Show/Hide debugging options 2020-07-11 16:38:38 +01:00
MerryMage
0193202964 configuration: Add settings to enable/disable specific CPU optimizations 2020-07-11 14:34:09 +01:00
bunnei
a0ee597b19
Merge pull request #4203 from VolcaEM/services 
service: Update function tables
 2020-07-11 00:02:36 -04:00
Morph
755506d404 vfs_real: Fix MoveFile 
The file wasn't closed prior to being renamed / moved, throwing an error that states "The process cannot access the file because it is being used by another process." Fix this by closing the file prior to a rename / move operation.

Fixes saving in Luigi's Mansion 3 and KATANA KAMI: A Way of the Samurai Story.
 2020-07-10 00:39:23 -04:00
Morph
7351ca8c75 KeyManager: Prevent writing of invalid keys 
If the keys are zero, don't write them to the autogenerated file.
 2020-07-10 00:39:00 -04:00
Morph
b24b463c87 bis_factory: Set User NAND free space to be 1 MiB less than total. 2020-07-10 00:37:39 -04:00
Morph
17242a8865 sdmc_factory: Set the SDMC total size to 1 TiB 
We should not be limited by the SDMC's partition size, set this to 1 TiB. Hardware is limited to the max allowed by the MBR partition table which is 2 TiB.
 2020-07-10 00:37:39 -04:00
Morph
0373ead96e bis_factory: Use hardware default NAND partition sizes 
Sets the total space of user and system partitions to their hardware defaults.
Furthermore, return the total space as free space for the user partition to prevent it from reaching zero.
Some games like Bioshock 2 check for the available free space prior to save creation, and we should not be limited by arbitrary limits.
 2020-07-10 00:37:39 -04:00
Morph
47e26d7bc7 settings: Remove storage size options 2020-07-10 00:37:39 -04:00
lat9nq
63d23835ef
configuration: implement per-game configurations (#4098) 
* Switch game settings to use a pointer

In order to add full per-game settings, we need to be able to tell yuzu to switch
to using either the global or game configuration. Using a pointer makes it easier
to switch.

* configuration: add new UI without changing existing funcitonality

The new UI also adds General, System, Graphics, Advanced Graphics,
and Audio tabs, but as yet they do nothing. This commit keeps yuzu
to the same functionality as originally branched.

* configuration: Rename files

These weren't included in the last commit. Now they are.

* configuration: setup global configuration checkbox

Global config checkbox now enables/disables the appropriate tabs in the game
properties dialog. The use global configuration setting is now saved to the
config, defaulting to true. This also addresses some changes requested in the PR.

* configuration: swap to per-game config memory for properties dialog

Does not set memory going in-game. Swaps to game values when opening the
properties dialog, then swaps back when closing it. Uses a `memcpy` to swap.
Also implements saving config files, limited to certain groups of configurations
so as to not risk setting unsafe configurations.

* configuration: change config interfaces to use config-specific pointers

When a game is booted, we need to be able to open the configuration dialogs
without changing the settings pointer in the game's emualtion. A new pointer
specific to just the configuration dialogs can be used to separate changes
to just those config dialogs without affecting the emulation.

* configuration: boot a game using per-game settings

Swaps values where needed to boot a game.

* configuration: user correct config during emulation

Creates a new pointer specifically for modifying the configuration while
emulation is in progress. Both the regular configuration dialog and the game
properties dialog now use the pointer Settings::config_values to focus edits to
the correct struct.

* settings: split Settings::values into two different structs

By splitting the settings into two mutually exclusive structs, it becomes easier,
as a developer, to determine how to use the Settings structs after per-game
configurations is merged. Other benefits include only duplicating the required
settings in memory.

* settings: move use_docked_mode to Controls group

`use_docked_mode` is set in the input settings and cannot be accessed from the
system settings. Grouping it with system settings causes it to be saved with
per-game settings, which may make transferring configs more difficult later on,
especially since docked mode cannot be set from within the game properties
dialog.

* configuration: Fix the other yuzu executables and a regression

In main.cpp, we have to get the title ID before the ROM is loaded, else the
renderer will reflect only the global settings and now the user's game specific
settings.

* settings: use a template to duplicate memory for each setting

Replaces the type of each variable in the Settings::Values struct with a new
class that allows basic data reading and writing. The new struct
Settings::Setting duplicates the data in memory and can manage global overrides
per each setting.

* configuration: correct add-ons config and swap settings when apropriate

Any add-ons interaction happens directly through the global values struct.
Swapping bewteen structs now also includes copying the necessary global configs
that cannot be changed nor saved in per-game settings. General and System config
menus now update based on whether it is viewing the global or per-game settings.

* settings: restore old values struct

No longer needed with the Settings::Setting class template.

* configuration: implement hierarchical game properties dialog

This sets the apropriate global or local data in each setting.

* clang format

* clang format take 2

can the docker container save this?

* address comments and style issues

* config: read and write settings with global awareness

Adds new functions to read and write settings while keeping the global state in
focus. Files now generated per-game are much smaller since often they only need
address the global state.

* settings: restore global state when necessary

Upon closing a game or the game properties dialog, we need to restore all global
settings to the original global state so that we can properly open the
configuration dialog or boot a different game.

* configuration: guard setting values incorrectly

This disables setting values while a game is running if the setting is
overwritten by a per game setting.

* config: don't write local settings in the global config

Simple guards to prevent writing the wrong settings in the wrong files.

* configuration: add comments, assume less, and clang format

No longer assumes that a disabled UI element means the global state is turned
off, instead opting to directly answer that question. Still however assumes a
game is running if it is in that state.

* configuration: fix a logic error

Should not be negated

* restore settings' global state regardless of accept/cancel

Fixes loading a properties dialog and causing the global config dialog to show
local settings.

* fix more logic errors

Fixed the frame limit would set the global setting from the game properties
dialog. Also strengthened the Settings::Setting member variables and simplified
the logic in config reading (ReadSettingGlobal).

* fix another logic error

In my efforts to guard RestoreGlobalState, I accidentally negated the IsPowered
condition.

* configure_audio: set toggle_stretched_audio to tristate

* fixed custom rtc and rng seed overwriting the global value

* clang format

* rebased

* clang format take 4

* address my own review

Basically revert unintended changes

* settings: literal instead of casting

"No need to cast, use 1U instead"
Thanks, Morph!

Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>

* Revert "settings: literal instead of casting
"

This reverts commit 95e992a87c898f3e882ffdb415bb0ef9f80f613f.

* main: fix status buttons reporting wrong settings after stop emulation

* settings: Log UseDockedMode in the Controls group

This should have happened when use_docked_mode was moved over to the controls group
internally. This just reflects this in the log.

* main: load settings if the file has a title id

In other words, don't exit if the loader has trouble getting a title id.

* use a zero

* settings: initalize resolution factor with constructor instead of casting

* Revert "settings: initalize resolution factor with constructor instead of casting"

This reverts commit 54c35ecb46a29953842614620f9b7de1aa9d5dc8.

* configure_graphics: guard device selector when Vulkan is global

Prevents the user from editing the device selector if Vulkan is the global
renderer backend. Also resets the vulkan_device variable when the users
switches back-and-forth between global and Vulkan.

* address reviewer concerns

Changes function variables to const wherever they don't need to be changed. Sets Settings::Setting to final as it should not be inherited from. Sets ConfigurationShared::use_global_text to static.

Co-Authored-By: VolcaEM <volcaem@users.noreply.github.com>

* main: load per-game settings after LoadROM

This prevents `Restart Emulation` from restoring the global settings *after* the per-game settings were applied. Thanks to BSoDGamingYT for finding this bug.

* Revert "main: load per-game settings after LoadROM"

This reverts commit 9d0d48c52d2dcf3bfb1806cc8fa7d5a271a8a804.

* main: only restore global settings when necessary

Loading the per-game settings cannot happen after the ROM is loaded, so we have to specify when to restore the global state. Again thanks to BSoD for finding the bug.

* configuration_shared: address reviewer concerns except operator overrides

Dropping operator override usage in next commit.

Co-Authored-By: LC <lioncash@users.noreply.github.com>

* settings: Drop operator overrides from Setting template

Requires using GetValue and SetValue explicitly. Also reverts a change that broke title ID formatting in the game properties dialog.

* complete rebase

* configuration_shared: translate "Use global configuration"

Uses ConfigurePerGame to do so, since its usage, at least as of now, corresponds with ConfigurationShared.

* configure_per_game: address reviewer concern

As far as I understand, it prevents the program from unnecessarily copying strings.

Co-Authored-By: LC <lioncash@users.noreply.github.com>

Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
Co-authored-by: VolcaEM <volcaem@users.noreply.github.com>
Co-authored-by: LC <lioncash@users.noreply.github.com>
 2020-07-09 22:42:09 -04:00
bunnei
f9e748b721
Merge pull request #4248 from Morph1984/CreateManagedDisplaySeparableLayer 
AM/ISelfController: Stub CreateManagedDisplaySeparableLayer
 2020-07-09 22:09:42 -04:00
bunnei
83b1b259bd
Merge pull request #4202 from ReinUsesLisp/scoped-lock 
core_timing,scheduler: Use std::scoped_lock when possible
 2020-07-09 15:33:41 -04:00
CrazyMax
cf76769026 AM: fix GetDesiredLanguage: 
try to get a control metadata from application update when is failed to get from the basic version.

Tested on Kirby Star Allies
 2020-07-08 19:45:06 +03:00
bunnei
4e2464a713
Merge pull request #4243 from CrazyMax/display_version 
AM: fix GetDisplayVersion
 2020-07-08 10:46:56 -04:00
bunnei
2a87ddcce2
Merge pull request #4245 from MerryMage/page-table-race 
memory: Race-condition in pagetables.
 2020-07-08 10:44:33 -04:00
MerryMage
e7c77b90c4 cpu_interrupt_handler: Remove #pragma once from .cpp file 2020-07-07 22:47:00 +01:00
CrazyMax
7bd3558c64 GetDisplayVersion should return a null-terminated version string. 
also, in case of failed to get of the basic version, we will try get it from application update.
 2020-07-07 02:04:24 +03:00
MerryMage
76bd617b2d memory: Set page-table pointers before setting attribute = Memory 2020-07-05 12:54:19 +01:00
Morph
c0dc8f9d25 AM/ISelfController: Stub CreateManagedDisplaySeparableLayer 
Stub this by sending 1 layer id instead of 2 as yuzu does not support multiple layers per display.
No adverse side effects have been observed.
- Used by Animal Crossing: New Horizons Update 1.3.0
 2020-07-05 06:26:21 -04:00
Rodrigo Locatti
3096adb347
Merge pull request #4218 from ogniK5377/opus-external 
externals: Track opus as submodule instead of using conan
 2020-07-04 01:32:54 -03:00
bunnei
8a1cfcc8b7
Merge pull request #3924 from ogniK5377/GetKeyCodeMap 
Implement GetKeyCodeMap & GetKeyCodeMap2
 2020-07-02 23:03:20 -04:00
bunnei
b13fd9e65a
Merge pull request #4193 from ogniK5377/GetIndirectLayerConsumerHandle-stub 
am: Stub GetIndirectLayerConsumerHandle
 2020-07-02 21:31:20 -04:00
bunnei
af787e451b
Merge pull request #4192 from ogniK5377/acc-ListOpenContextStoredUsers-stub 
acc: ListOpenContextStoredUsers partial stub
 2020-07-02 20:36:54 -04:00
VolcaEM
3f910efb40
Rename two functions in NS 
- Rename "GetShellEvent" to "GetShellEventHandle"
- Rename "LaunchApplicationFromHost" to "LaunchApplication"
 2020-07-02 09:02:55 +02:00
VolcaEM
38b585a309
Rename GetApplicationArea2 to GetApplicationAreaSize 2020-07-02 08:58:51 +02:00
David Marcec
d5dfe34c49 externals: Track opus as submodule instead of using conan 
Supersedes #4068 see for details.
 2020-07-01 15:09:33 +10:00
Lioncash
fb13f053bb key_manager: Correct casing of instance() 
Our codebase uppercases member function names.
 2020-07-01 00:28:50 -04:00
Lioncash
c91710a82f key_manager: Delete move operations 
Prevents the singleton from being moved from.
 2020-07-01 00:24:38 -04:00
Lioncash
00a1d106bd key_manager: Make use of canonical deleted operator= 
operator= typically returns a reference, it's not void.

While we're at it, we can correct the parameter formatting to adhere to the
codebase.
 2020-07-01 00:21:31 -04:00
David
3bb63bc0b3
Merge pull request #3967 from FearlessTobi/keys-singleton 
crypto: Make KeyManager a singleton class
 2020-07-01 14:16:26 +10:00
bunnei
c6b0353c4d
Merge pull request #4153 from ogniK5377/prepo-multibuf 
prepo: : Don't read extra buffer from report unless passed
 2020-06-30 22:37:13 -04:00
VolcaEM
86946ea13c
Remove duplicate functions 2020-06-29 04:22:38 +02:00
VolcaEM
f3630a0713
Use decimal instead of hexadecimal 
Co-authored-by: David <25727384+ogniK5377@users.noreply.github.com>
 2020-06-29 04:21:10 +02:00
VolcaEM
a0c499aef7
Fix typo 2020-06-29 04:12:36 +02:00
VolcaEM
f2eead3b5b
Clang-format 2020-06-29 04:09:38 +02:00
VolcaEM
6a0010d0c6
service: Update function tables 2020-06-29 04:01:34 +02:00
ReinUsesLisp
8562b516c0 core_timing,scheduler: Use std::scoped_lock when possible 
Simplifies the cognitive load of procedures using locks and makes locks
safe against exceptions.
 2020-06-28 21:42:57 -03:00
bunnei
b05795d704
Merge pull request #3955 from FernandoS27/prometheus-2b 
Remake Kernel Scheduling, CPU Management & Boot Management (Prometheus)
 2020-06-28 12:37:50 -04:00
David Marcec
db824b59c8 ldr: Cleanup NRO & NRR structs 2020-06-28 20:54:37 +10:00
David
d67c7d9a82
Merge pull request #4026 from VolcaEM/ldr 
ldr: Update NRR/NRO structs
 2020-06-28 20:46:42 +10:00
David
4a5f6c03b0
Merge pull request #4184 from VolcaEM/patch-9 
grc: Update function table
 2020-06-28 18:49:15 +10:00
David
d3a306b7a6
Merge pull request #4185 from VolcaEM/patch-10 
lbl: Update function table
 2020-06-28 18:48:54 +10:00
David
477979dd43
Merge pull request #4186 from VolcaEM/patch-11 
ldn: Update function table
 2020-06-28 18:48:28 +10:00
David
b478b61dcf
Merge pull request #4187 from VolcaEM/patch-12 
mig: Update function table
 2020-06-28 18:48:15 +10:00
David
00aa9f6a53
Merge pull request #4188 from VolcaEM/patch-13 
mm: Update function table
 2020-06-28 18:47:55 +10:00
David
26e243d2d7
Merge pull request #4189 from VolcaEM/patch-14 
ncm: Update function table
 2020-06-28 18:47:27 +10:00
David
bd590895cf
Merge pull request #4190 from VolcaEM/patch-15 
nfc: Update function table
 2020-06-28 18:47:07 +10:00
David
e978f05ed1
Merge pull request #4183 from VolcaEM/patch-8 
friend: Update function table
 2020-06-28 18:46:40 +10:00
David Marcec
dcf345febe am: Stub GetIndirectLayerConsumerHandle 
Needed by Monster Hunter Generations Ultimate
 2020-06-28 16:51:28 +10:00
David Marcec
f0baf2abf2 acc: ListOpenContextStoredUsers partial stub 
Needed by Baldur's Gate 1/2
 2020-06-28 16:44:36 +10:00
Fernando Sahmkow
2f8947583f Core/Common: Address Feedback. 2020-06-27 18:20:06 -04:00
Fernando Sahmkow
e486c66850 NvFlinger: Clang Format. 2020-06-27 11:36:30 -04:00
Fernando Sahmkow
4105f38022 SVC: Implement 32-bits wrappers and update Dynarmic. 2020-06-27 11:36:27 -04:00
Fernando Sahmkow
ce350e7ce0 SVC: Add GetCurrentProcessorNumber32, CreateTransferMemory32, SetMemoryAttribute32 2020-06-27 11:36:27 -04:00
Fernando Sahmkow
b8df61c642 ARM: Update Dynarmic and Setup A32 according to latest interface. 2020-06-27 11:36:26 -04:00
Fernando Sahmkow
22ceaca2f4 SVC: Add GetThreadPriority32 & SetThreadPriority32 2020-06-27 11:36:25 -04:00
Fernando Sahmkow
ec11918323 ArmDynarmic32: Setup CNTPCT correctly 2020-06-27 11:36:24 -04:00
Fernando Sahmkow
e3d561fb84 Audio: Correct buffer release for host timing. 2020-06-27 11:36:23 -04:00
Fernando Sahmkow
7fd7d05838 Common/Kernel: Corrections and small bug fixing. 2020-06-27 11:36:21 -04:00
Fernando Sahmkow
272a87127a Services/NvFlinger: Do vSync in a sepparate thread on Multicore. 2020-06-27 11:36:20 -04:00
Fernando Sahmkow
0a8013d71e ARMDynarmicInterface: Correct GCC Build Errors. 2020-06-27 11:36:17 -04:00
Fernando Sahmkow
d240143588 Kernel: Correct Host Context on Threads and Scheduler. 2020-06-27 11:36:15 -04:00
Fernando Sahmkow
467d43570e Clang Format. 2020-06-27 11:36:14 -04:00
Fernando Sahmkow
3714f2e471 ARMInterface/Externals: Update dynarmic and fit to latest version. 2020-06-27 11:36:13 -04:00
Fernando Sahmkow
dda6147b0d ARMInterface: Correct rebase errors. 2020-06-27 11:36:12 -04:00
Fernando Sahmkow
71f1c0f9f9 CoreTiming: Correct rebase bugs and other miscellaneous things. 2020-06-27 11:36:11 -04:00
Fernando Sahmkow
cdf900f1e3 Core: Split Microprofile Dynarmic timing per Core 2020-06-27 11:36:10 -04:00
Fernando Sahmkow
528b19a842 General: Tune the priority of main emulation threads so they have higher priority than less important helper threads. 2020-06-27 11:36:09 -04:00
Fernando Sahmkow
7b44187fd2 Dynarmic Interface: don't clear cache if JIT has not been created. 2020-06-27 11:36:08 -04:00
Fernando Sahmkow
ad92865497 General: Correct rebase, sync gpu and context management. 2020-06-27 11:36:08 -04:00
Fernando Sahmkow
bfb5244cf8 CoreTiming/CycleTimer: Correct Idling. 2020-06-27 11:36:07 -04:00
Fernando Sahmkow
bece52cd81 SingleCore: Correct ticks reset to be on preemption. 2020-06-27 11:36:06 -04:00
Fernando Sahmkow
48fa3b7a0f General: Cleanup legacy code. 2020-06-27 11:36:05 -04:00
Fernando Sahmkow
c8bf47dcfb Kernel/svcBreak: Implement CacheInvalidation for Singlecore and correct svcBreak. 2020-06-27 11:36:04 -04:00
Fernando Sahmkow
54e304fe2a Bootmanager/CPU_Manager: Correct shader caches and sync GPU on OpenGL. 2020-06-27 11:36:03 -04:00
Fernando Sahmkow
19165cd859 HLE_IPC: Correct HLE Event behavior on timeout. 2020-06-27 11:36:03 -04:00
Fernando Sahmkow
7e2ce2f7f4 SingleCore: Improve Cycle timing Behavior and replace mutex in global scheduler for spinlock. 2020-06-27 11:36:02 -04:00
Fernando Sahmkow
a7ecd9e19c FrameLimiting: Enable frame limiting for single core. 2020-06-27 11:36:01 -04:00
Fernando Sahmkow
f5e32935ca SingleCore: Use Cycle Timing instead of Host Timing. 2020-06-27 11:36:01 -04:00
Fernando Sahmkow
9bde28d7b1 Scheduler: Correct Reload/Unload 2020-06-27 11:35:59 -04:00
Fernando Sahmkow
5974e3ea33 Thread: Release the ARM Interface on exitting. 2020-06-27 11:35:58 -04:00
Fernando Sahmkow
1567824d2d General: Move ARM_Interface into Threads. 2020-06-27 11:35:58 -04:00
Fernando Sahmkow
1b82ccec22 Core: Refactor ARM Interface. 2020-06-27 11:35:56 -04:00
Fernando Sahmkow
534466754f X64 Clock: Reduce accuracy to be less or equal to guest accuracy. 2020-06-27 11:35:55 -04:00
Fernando Sahmkow
7b18174eef ARM/WaitTree: Better track the CallStack for each thread. 2020-06-27 11:35:54 -04:00
Fernando Sahmkow
87c49aa7be SVC/ARM: Correct svcSendSyncRequest and cache ticks on arm interface. 2020-06-27 11:35:53 -04:00
Fernando Sahmkow
f2ade343e2 SingleCore: Move Host Timing from a sepparate thread to main cpu thread. 2020-06-27 11:35:52 -04:00
Fernando Sahmkow
5d3a2be04f GUI: Make multicore only work with Async and add GUI for multicore. 2020-06-27 11:35:52 -04:00
Fernando Sahmkow
25565dffd5 ARM: Addapt to new Exclusive Monitor Interface. 2020-06-27 11:35:50 -04:00
Fernando Sahmkow
1a5f2e290b CPU_Manager: Correct stopping on SingleCore. 2020-06-27 11:35:49 -04:00
Fernando Sahmkow
db68fba4a6 Scheduler: Correct yielding interaction with SetThreadActivity. 2020-06-27 11:35:49 -04:00
Fernando Sahmkow
7020d498c5 General: Fix microprofile on dynarmic/svc, fix wait tree showing which threads were running. 2020-06-27 11:35:48 -04:00
Fernando Sahmkow
e6f8bde74b General: Fix Stop function 2020-06-27 11:35:47 -04:00
Fernando Sahmkow
f370de84b1 Kernel: Rewind on SVC change. 2020-06-27 11:35:46 -04:00
Fernando Sahmkow
d494b074e8 Kernel: Preempt Single core on redudant yields. 2020-06-27 11:35:45 -04:00
Fernando Sahmkow
a439cdf22e CPU_Manager: Unload/Reload threads on preemption on SingleCore 2020-06-27 11:35:43 -04:00
Fernando Sahmkow
8a78fc2580 Synchronization: Correct wide Assertion. 2020-06-27 11:35:43 -04:00
Fernando Sahmkow
ab9aae28bf General: Initial Setup for Single Core. 2020-06-27 11:35:42 -04:00
Fernando Sahmkow
391f5f360d Scheduler: Set last running time on thread. 2020-06-27 11:35:41 -04:00
Fernando Sahmkow
9e9c287f8b Kernel: Corrections to TimeManager, Scheduler and Mutex. 2020-06-27 11:35:40 -04:00
Fernando Sahmkow
6515c6e8c6 Kernel: Fixes, corrections and asserts to scheduler and different svcs. 2020-06-27 11:35:40 -04:00
Fernando Sahmkow
4217e58a10 Scheduler: Correct yields. 2020-06-27 11:35:39 -04:00
Fernando Sahmkow
445b4342b3 Mutex: Revert workaround due to poor exclusive memory. 2020-06-27 11:35:38 -04:00
Fernando Sahmkow
cd1c38be8d ARM/Memory: Correct Exclusive Monitor and Implement Exclusive Memory Writes. 2020-06-27 11:35:37 -04:00
Fernando Sahmkow
535c542d84 SVC: WaitSynchronization add Termination Pending Result. 2020-06-27 11:35:36 -04:00
Fernando Sahmkow
725bac1404 Scheduler: Remove arm_interface lock and a few corrections. 2020-06-27 11:35:35 -04:00
Fernando Sahmkow
83c7ba1ef7 SVC: Correct SetThreadActivity. 2020-06-27 11:35:33 -04:00
Fernando Sahmkow
a66c61ca2d SCC: Small corrections to CancelSynchronization 2020-06-27 11:35:33 -04:00
Fernando Sahmkow
44cb9997b3 Scheduler: Correct locking for hle threads. 2020-06-27 11:35:32 -04:00
Fernando Sahmkow
6ed28e15fa Scheduler: Fix HLE Threads on guard 2020-06-27 11:35:31 -04:00
Fernando Sahmkow
3de33348e4 Scheduler: Protect on closed threads. 2020-06-27 11:35:31 -04:00
Fernando Sahmkow
19847d4d42 Scheduler: Correct assert. 2020-06-27 11:35:30 -04:00
Fernando Sahmkow
a33fbaddec Core: Correct rebase. 2020-06-27 11:35:29 -04:00
Fernando Sahmkow
1c672128c4 Scheduler: Release old thread fiber before trying to switch to the next thread fiber. 2020-06-27 11:35:28 -04:00
Fernando Sahmkow
c43e559734 NVDRV: Remove frame limiting as Host Timing already takes care. 2020-06-27 11:35:28 -04:00
Fernando Sahmkow
a6bce296ad Mutex: Correct Result writting to clear exclusivity. 2020-06-27 11:35:26 -04:00
Fernando Sahmkow
e4b175ade2 SVC: Correct svcWaitForAddress and svcSignalToAddress. 2020-06-27 11:35:25 -04:00
Fernando Sahmkow
1e987dbe8d Scheduler: Correct Select Threads Step 2. 2020-06-27 11:35:24 -04:00
Fernando Sahmkow
07993ac8c8 Kernel: Corrections to Scheduling. 2020-06-27 11:35:23 -04:00
Fernando Sahmkow
b4dc01f16a Kernel: Correct Signal on Thread Death and Setup Sync Objects on Thread for Debugging 2020-06-27 11:35:23 -04:00
Fernando Sahmkow
75e10578f1 Core: Correct HLE Event Callbacks and other issues. 2020-06-27 11:35:22 -04:00
Fernando Sahmkow
de5b521c09 Process: Protect TLS region and Modules. 2020-06-27 11:35:21 -04:00
Fernando Sahmkow
2a8837ff51 General: Add Asserts 2020-06-27 11:35:21 -04:00
Fernando Sahmkow
04e0f8776c General: Add better safety for JIT use. 2020-06-27 11:35:20 -04:00
Fernando Sahmkow
bd36eaf15d SVC: Correct races on physical core switching. 2020-06-27 11:35:19 -04:00
Fernando Sahmkow
cc3aa95926 NVFlinger: Lock race condition between CPU, Host Timing, VSync. 2020-06-27 11:35:18 -04:00
Fernando Sahmkow
3902067008 SVC: Add locks to the memory management. 2020-06-27 11:35:18 -04:00
Fernando Sahmkow
d4ebb510a0 SVC: Correct WaitSynchronization, WaitProcessWideKey, SignalProcessWideKey. 2020-06-27 11:35:17 -04:00
Fernando Sahmkow
5b6a67f849 SVC: Cleanup old methods. 2020-06-27 11:35:16 -04:00
Fernando Sahmkow
3d9fbb8226 CPU_Manager: Reconfigre guest threads for dynamrmic downsides 2020-06-27 11:35:15 -04:00
Fernando Sahmkow
15a79eb0d7 SVC: Correct SendSyncRequest. 2020-06-27 11:35:14 -04:00
Fernando Sahmkow
203e706302 SVC: Correct ArbitrateUnlock 2020-06-27 11:35:14 -04:00
Fernando Sahmkow
3b5b950c89 SVC: Correct SignalEvent, ClearEvent, ResetSignal, WaitSynchronization, CancelSynchronization, ArbitrateLock 2020-06-27 11:35:13 -04:00
Fernando Sahmkow
ef4afa9760 SVC: Remove global HLE Lock. 2020-06-27 11:35:13 -04:00
Fernando Sahmkow
589f9cf108 SVC: Correct GetThreadPriority, SetThreadPriority, GetThreadCoreMask, SetThreadCoreMask, GetCurrentProcessorNumber 2020-06-27 11:35:12 -04:00
Fernando Sahmkow
49ba563995 SVC: Correct CreateThread, StartThread, ExitThread, SleepThread. 2020-06-27 11:35:11 -04:00
Fernando Sahmkow
18dcb09342 HostTiming: Pause the hardware clock on pause. 2020-06-27 11:35:10 -04:00
Fernando Sahmkow
dc58058203 General: Setup yuzu threads' microprofile, naming and registry. 2020-06-27 11:35:09 -04:00
Fernando Sahmkow
a5c58a25ef CPU_Manager: remove debugging code. 2020-06-27 11:35:08 -04:00
Fernando Sahmkow
e31425df38 General: Recover Prometheus project from harddrive failure 
This commit: Implements CPU Interrupts, Replaces Cycle Timing for Host 
Timing, Reworks the Kernel's Scheduler, Introduce Idle State and 
Suspended State, Recreates the bootmanager, Initializes Multicore 
system.
 2020-06-27 11:35:06 -04:00
David
0ea4a8bcc4
Merge pull request #3396 from FernandoS27/prometheus-1 
Implement SpinLocks, Fibers and a Host Timer
 2020-06-28 01:34:07 +10:00
VolcaEM
23515e0ccc
nfc: Update function table 
This was based on Switchbrew page: https://switchbrew.org/wiki/NFC_services
 2020-06-27 13:09:36 +02:00
VolcaEM
c56414b80d
ncm: Update function table 
This was based on Switchbrew page: https://switchbrew.org/wiki/NCM_services

ILocationResolver's 16, 17, 18 and 19 have unofficial names
 2020-06-27 13:05:22 +02:00
VolcaEM
b829643946
mm: Update function table 
This was based on Switchbrew page: https://switchbrew.org/wiki/Display_services
 2020-06-27 12:59:01 +02:00
VolcaEM
5219424226
mig: Update function table 
This was based on Switchbrew page: https://switchbrew.org/wiki/Migration_services
 2020-06-27 12:53:59 +02:00
VolcaEM
b9be484a51
ldn: Update function table 
This was based on Switchbrew page: https://switchbrew.org/wiki/LDN_services
 2020-06-27 12:50:56 +02:00
VolcaEM
a8d17adb7c
Oops (fix typo) 2020-06-27 12:45:42 +02:00
VolcaEM
73b035d2e2
lbl: Update function table 
This was based on Switchbrew page: https://switchbrew.org/wiki/Backlight_services
 2020-06-27 12:43:33 +02:00
VolcaEM
64fa9b9f57
grc: Update function table 
This was based on Switchbrew page: https://switchbrew.org/wiki/GRC_services
 2020-06-27 12:41:21 +02:00
VolcaEM
af88767508
friend: Update function table 2020-06-27 12:39:10 +02:00
bunnei
9eaccac674
Merge pull request #4164 from Kewlan/mute-audio-hotkey 
hotkeys: Add a "Mute Audio" hotkey
 2020-06-27 02:47:13 -04:00
bunnei
6f16f54f10
Merge pull request #4158 from Morph1984/caps 
caps: Use enum classes and check struct sizes on compile time
 2020-06-27 00:09:32 -04:00
bunnei
a91f92a89d
Merge pull request #4152 from ogniK5377/ipc-err 
Mark invalid IPC buffers as ASSERT_OR_EXECUTE_MSG
 2020-06-26 23:37:19 -04:00
bunnei
705cccb1e4
Merge pull request #4154 from ogniK5377/swkbd-nullptr 
Prevent nullptr dereference on swkbd error case
 2020-06-26 23:25:04 -04:00
David
b32b7c6e74
Merge pull request #4178 from VolcaEM/patch-6 
es: Update function table
 2020-06-27 13:05:12 +10:00
VolcaEM
2d82b7f1a1
Use better names for "Unknown"s 2020-06-27 02:48:29 +02:00
VolcaEM
bc51a9365b
Update function names 2020-06-27 02:43:22 +02:00
David Marcec
0b23ce6ef2 btm: Give better names for unknown functions 2020-06-27 10:42:46 +10:00
VolcaEM
032b7d490d
btdrv: Update function table (#4174) 
* btdrv: Update function table
 2020-06-26 20:34:29 -04:00
VolcaEM
6e14edbcc2
bpc: Update function tables (#4173) 
* bpc: Update function tables

This was based on Switchbrew page: https://switchbrew.org/wiki/PCV_services
 2020-06-26 20:33:55 -04:00
VolcaEM
e6fee39ae7
bcat: Update function tables and add missing classes (#4172) 
* bcat: Update function tables and add missing classes
 2020-06-26 20:33:25 -04:00
VolcaEM
ca25a3845e
am: Update function tables and add missing classes (#4169) 
* am: Update function tables and add missing classes

* Remove comments (1/5)

* Remove comments (2/5)

* Remove comments (3/5)

* Remove comments (4/5)

* Remove comments (5/5)

* Remove unused classes (1/2)

* Remove unused classes (2/2)
 2020-06-26 20:32:26 -04:00
VolcaEM
b5d54619cc
aoc: Update function table (#4170) 
* aoc: Update function table

* Remove comments
 2020-06-26 20:31:44 -04:00
LC
98bbab8030
Merge pull request #4177 from VolcaEM/patch-5 
btm: Update function tables
 2020-06-26 20:30:59 -04:00
VolcaEM
0f4a611129
eupld: Update function table 
This was based on Switchbrew page: https://switchbrew.org/wiki/Error_Upload_services
 2020-06-27 02:25:04 +02:00
VolcaEM
3828aa4927
es: Update function table 
This was based on Switchbrew page: https://switchbrew.org/wiki/ETicket_services
 2020-06-27 02:17:51 +02:00
VolcaEM
d3e9b45ce0
btm: Update function tables 
This was based on Switchbrew page: https://switchbrew.org/wiki/BTM_services

"No comment" edition
 2020-06-27 01:57:48 +02:00
Morph
72f14ae21f caps_u: Fix GetAlbumContentsFileListForApplication stub 2020-06-26 08:35:21 -04:00
Morph
3017be7855 caps: Use enum classes and check struct sizes on compile time 2020-06-26 08:35:21 -04:00
Morph
02a33feef4 caps: Update copyright headers 
Updated to "yuzu Emulator Project"
 2020-06-26 08:35:21 -04:00
Kewlan
3eb8efc095 Add a "Mute Audio" hotkey 2020-06-26 06:03:29 +02:00
bunnei
c4fe83a7bc
Merge pull request #4159 from ogniK5377/mem-manager-dumb-assert 
memory_manager: Remove useless assertion
 2020-06-25 22:53:13 -04:00
David
d11baf8bf8
Merge pull request #4141 from Morph1984/SevenSixAxisSensor 
hid: Stub a series of "SevenSixAxisSensor" service commands
 2020-06-25 19:37:39 +10:00
David Marcec
38868e5750 memory_manager: Remove useless assertion 
num_pages is an std::size_t. It will always be >= 0
 2020-06-25 16:35:58 +10:00
Morph
2c9308954c hid: Stub a series of "SevenSixAxisSensor" service commands 
- Used by Captain Toad: Treasure Tracker Update 1.3.0

While we're at it, fix the input parameters for SetIsPalmaAllConnectable and SetPalmaBoostMode
 2020-06-24 11:57:39 -04:00
David Marcec
510838759f Prevent nullptr dereference on swkbd error case 2020-06-25 00:25:15 +10:00
David Marcec
2f0b322e72 prepo: : Don't read extra buffer from report unless passed 
Prepo doesn't always pass a secondary buffer, we assume it always does which leads to a bad read.
 2020-06-24 23:01:00 +10:00
David Marcec
82ecdd0104 Mark invalid IPC buffers as ASSERT_OR_EXECUTE_MSG 
Previously if applications would send faulty buffers(example homebrew) it would lead to us returning uninitalized data. Switching from ASSERT_MSG to ASSERT_OR_EXECUTE_MSG allows us to have a fail safe to prevent crashes but also continue execution without introducing undefined behavior
 2020-06-24 22:50:27 +10:00
David Marcec
380fbd8cb7 Move GetKeyCodeMapImpl to an anonymous namespace 2020-06-24 13:05:08 +10:00
David Marcec
e3d2b646e0 Fixed logging output 2020-06-24 12:07:41 +10:00
David Marcec
5226610a15 Implement GetKeyCodeMap & GetKeyCodeMap2 
Closes #3919
 2020-06-24 12:05:52 +10:00
bunnei
3bab5a5e4a
Merge pull request #4138 from Morph1984/GyroscopeZeroDriftMode 
hid: Implement Get/ResetGyroscopeZeroDriftMode
 2020-06-23 21:56:16 -04:00
bunnei
1d1489da80
Merge pull request #4128 from lioncash/move2 
software_keyboard: Eliminate trivial redundant copies
 2020-06-23 18:24:15 -04:00
Morph
45dac6bc5c lm: Silence no return value warning 2020-06-22 22:55:32 -04:00
VolcaEM
e193aa3f53
account: Update function tables and add missing classes (#4145) 
* account: Update function tables and add missing classes

* clang-format

* Add missing "public"

* Add missing public again

* Add missing final
 2020-06-22 16:03:26 -04:00
Morph
f2df941e8d arm_dynarmic_64: Log the instruction when an exception is raised 2020-06-22 07:00:24 -04:00
Morph
e0af4cdf98 arm_dynarmic_32: Log under Core_ARM instead of HW_GPU 2020-06-22 06:59:41 -04:00
Morph
0235915baa hid: Implement Get/ResetGyroscopeZeroDriftMode 
- Used by Captain Toad Treasure Tracker
 2020-06-21 16:25:41 -04:00
Lioncash
a5ed0c3df7 software_keyboard: Eliminate trivial redundant copies 
We can just make use of moves here to get rid of two redundant copies
 2020-06-20 01:06:10 -04:00
bunnei
7d1dca4c98
Merge pull request #4099 from MerryMage/macOS-build 
Fix compilation on macOS
 2020-06-19 23:31:04 -04:00
bunnei
9c5ed4408d
Merge pull request #4113 from ogniK5377/boxcat-disable 
Fix compilation when not building with boxcat
 2020-06-19 21:59:59 -04:00
MerryMage
7236393114 mii_model: Remove redundant std::move 
Named return value optimization automatically applies here.
 2020-06-19 14:29:09 +01:00
David Marcec
c7ed7d9427 Fix compilation when not building with boxcat 
Fixes compilation when trying to build without boxcat enabled
 2020-06-19 22:17:56 +10:00
Fernando Sahmkow
8f6ffcd5c4 Host Timing: Correct clang format. 2020-06-18 16:29:23 -04:00
Fernando Sahmkow
96b2d8419c HostTiming: Correct rebase and implement AddTicks. 2020-06-18 16:29:22 -04:00
Fernando Sahmkow
49a7e0984a Core/HostTiming: Allow events to be advanced manually. 2020-06-18 16:29:22 -04:00
Fernando Sahmkow
1f7dd36499 Common/Tests: Address Feedback 2020-06-18 16:29:21 -04:00
Fernando Sahmkow
1bd706344e Common/Tests: Clang Format. 2020-06-18 16:29:19 -04:00
Fernando Sahmkow
e3524d1142 Common: Refactor & Document Wall clock. 2020-06-18 16:29:18 -04:00
Fernando Sahmkow
234b5ff6a9 Common: Implement WallClock Interface and implement a native clock for x64 2020-06-18 16:29:17 -04:00
Fernando Sahmkow
0f8e5a1465 Tests: Add base tests to host timing 2020-06-18 16:29:17 -04:00
Fernando Sahmkow
62e35ffc0e Core: Implement a Host Timer. 2020-06-18 16:29:16 -04:00
ReinUsesLisp
778043a44c arm_dynarmic_32: Fix implicit conversion error in SetTPIDR_EL0 
On MSVC builds we treat conversion warnings as errors.
 2020-06-18 16:52:15 -03:00
MerryMage
b19fe55f84 memory_manager: Explicitly specifcy std::min<size_t> 2020-06-18 15:47:44 +01:00
MerryMage
4f09f0aea4 shared_font: Service::NS::EncryptSharedFont takes a size_t& 2020-06-18 15:47:44 +01:00
VolcaEM
684dfbf209
Move SHA256Hash to its original position 
It's not needed to have it in its previous position anymore
 2020-06-18 15:45:47 +02:00
MerryMage
52bcfac116 arm_dynarmic_cp15: Implement CNTPCT 2020-06-17 17:10:24 +01:00
MerryMage
109df7705f arm_dynarmic_cp15: Update CP15 2020-06-17 17:10:24 +01:00
MerryMage
32a127faaa arm_dynarmic_32: InterpreterFallback should never happen 2020-06-17 17:10:24 +01:00
VolcaEM
bd9495c9ab
Remove unnecessary pragmas 2020-06-16 20:28:44 +02:00
VolcaEM
c0d6162050
Revert IsValidNRO refactor but make it more readable 2020-06-16 20:24:58 +02:00
bunnei
f22d02083c
Merge pull request #3966 from Morph1984/hide-internal-resolution-ui 
yuzu/frontend: Remove internal resolution option
 2020-06-16 14:12:17 -04:00
VolcaEM
4b71bf654d
Update assert string 2020-06-16 15:57:02 +02:00
bunnei
55ebf68636
Merge pull request #4070 from ogniK5377/GetTPCMasks-fix 
nvdrv: Fix GetTPCMasks for ioctl3
 2020-06-14 20:12:45 -04:00
VolcaEM
39213b1c59
Clang-format again 2020-06-14 19:41:28 +02:00
VolcaEM
198b0fa790
Use consistent variable names 2020-06-14 19:37:44 +02:00
VolcaEM
1520d7865d
Clang-format 2020-06-14 19:34:58 +02:00
VolcaEM
761d206049
Make assert strings consistent 2020-06-14 19:30:08 +02:00
VolcaEM
151a3fe7b3
Attempt to fix crashes in SSBU and refactor IsValidNRO 2020-06-14 19:28:39 +02:00
bunnei
89d11f2268
Merge pull request #4069 from ogniK5377/total-phys-mem 
kernel: Account for system resource size for memory usage
 2020-06-14 00:44:34 -04:00
bunnei
e1911e5c8b
Merge pull request #4010 from ogniK5377/reserve-always-break 
kernel: ResourceLimit::Reserve remove useless while loop
 2020-06-12 22:30:19 -04:00
David Marcec
b15cbf9bcf nvdrv: Fix GetTPCMasks for ioctl3 
Fixes animal crossing svcBreak on launch
 2020-06-10 18:36:42 +10:00
David Marcec
74ff1db758 kernel: Account for system resource size for memory usage 
GetTotalPhysicalMemoryAvailableWithoutSystemResource & GetTotalPhysicalMemoryUsedWithoutSystemResource seem to subtract the resource size from the usage.
 2020-06-10 14:49:00 +10:00
Morph
03fad5ebe8 yuzu/frontend: Remove internal resolution option 2020-06-06 15:56:14 -04:00
bunnei
1adf640d37 service: nvhost_vic: Ignore Submit commands. 2020-06-04 22:32:28 -04:00
Zach Hilman
34635a42c0 nvdrv: Stub nvdec/vic ioctls to bypass nvdec movies 2020-06-04 22:32:28 -04:00
bunnei
624def4f38
Merge pull request #4044 from ogniK5377/handle-not-signalled-err 
Downgrade "handle not signaled" error to trace
 2020-06-04 12:23:40 -04:00
bunnei
34d4abc4f9
Merge pull request #4009 from ogniK5377/macro-jit-prod 
video_core: Implement Macro JIT
 2020-06-04 11:40:52 -04:00
David Marcec
c0d2e3212f Downgrade "handle not signaled" error to trace 
clogs logs quite a bit
 2020-06-04 22:27:15 +10:00
VolcaEM
dfd1badc12
Address review comments 2020-06-02 17:54:10 +02:00
VolcaEM
8c84a7e7ec
Clang-format 2020-06-01 19:42:54 +02:00
VolcaEM
4d10d3113f
hid: Stub GetXpadIDs 
Allows Minecraft: Nintendo Switch Edition (a.k.a. old Minecraft) to boot and go ingame
 2020-06-01 19:38:44 +02:00
VolcaEM
a087b3365a
Add comment to nrr_kind 
According to Atmosphére (c7026b9094/libraries/libstratosphere/include/stratosphere/ro/ro_types.hpp), nrr_kind (Atmosphére calls it "type") is 7.0.0+
 2020-05-31 19:12:09 +02:00
VolcaEM
2b1cc232bc
ldr: Update NRR/NRO structs 
This was based on Switchbrew pages:

https://switchbrew.org/wiki/NRR

https://switchbrew.org/wiki/NRO
 2020-05-31 18:49:51 +02:00
David Marcec
b032ebdfee Implement macro JIT 2020-05-30 11:40:04 +10:00
David Marcec
43bf860b22 kernel: ResourceLimit::Reserve remove useless while loop 
Timeout is a u64, it will always be >= 0
 2020-05-29 13:48:01 +10:00
bunnei
5242b21524
Merge pull request #4002 from lat9nq/fix-nix-mod-directories 
patch_manager: Add support for case-sensitivity on Linux
 2020-05-28 22:36:39 -04:00
lat9nq
f57cbd9f24 Make copying directory string more concise 2020-05-28 13:33:50 -04:00
lat9nq
326403518d Address requested changes 2020-05-28 13:30:22 -04:00
lat9nq
136c563f76 *nix systems can read any-case patch directories 
Changes many patch_manager functions to use a case-less variant of
GetSubdirectory. Fixes patches not showing up on *nix systems when
patch directories are named with odd cases, i.e. `exeFS'.
 2020-05-27 23:12:56 -04:00
bunnei
325e7eed3c
Merge pull request #3964 from ReinUsesLisp/arb-integration 
renderer_opengl: Add assembly program code paths
 2020-05-24 00:34:12 -04:00
VolcaEM
cb75ccc1f7
clang-format 2020-05-21 10:43:55 +02:00
VolcaEM
235805edf3
nifm: correct assert in CreateTemporaryNetworkProfile 
This has been wrong since 0432af5ad1
I haven't found a game that called this function (and I haven't tried this on a real Switch), and because of this I haven't been able to check if the number in assert OR the string in the assert is wrong, but one of the two is wrong:
NetworkProfileData is 0x18E, while SfNetworkProfileData is 0x17C, according to Switchbrew
Switchbrew doesn't officially say that NetworkProfileData's size is 0x18E but it's possible to calculate its size since Switchbrew provides the size and the offset of all the components of NetworkProfileData (which isn't currently implemented in yuzu, alongside SfNetworkProfileData)
NetworkProfileData documentation: https://switchbrew.org/wiki/Network_Interface_services#NetworkProfileData
SfNetworkProfileData documentation: https://switchbrew.org/wiki/Network_Interface_services#SfNetworkProfileData
Since I trust ogniK's work on reversing NIFM, I'd assume this was just a typo in the string
 2020-05-21 10:23:53 +02:00
bunnei
ae61e47cba
Merge pull request #3946 from ogniK5377/sysverdat-10-0-2 
file_sys: Update SystemVersion archive to version 10.0.2
 2020-05-20 19:21:27 -04:00
FearlessTobi
9f82a9a244 crypto: Make KeyManager a singleton class 
Previously, we were reading the keys everytime a KeyManager object was created, causing yuzu to reread the keys file multiple hundreds of times when loading the game list.
With this change, it is only loaded once.
On my system, this decreased game list loading times by a factor of 20.
 2020-05-20 21:28:16 +02:00
ReinUsesLisp
47a7c4f4fe yuzu: Add frontend settings for assembly shaders 
Add settings for assembly shaders. Currently hidden to avoid users from
accidentally enabled them.
 2020-05-19 17:53:17 -03:00
bunnei
cf4ee279c6
Merge pull request #3926 from ogniK5377/keyboard-states 
hid: Clear keyboard states & fix logic issue
 2020-05-19 15:55:14 -04:00
bunnei
65010607b7
Merge pull request #3665 from bunnei/device-save 
FS: Improve emulation of device saves
 2020-05-16 12:39:58 -04:00
David Marcec
17455b7222 file_sys: Update SystemVersion archive to version 10.0.2 2020-05-16 13:56:06 +10:00
David Marcec
6f0360690b nv_flinger: Use enum for pixel format instead of u32 2020-05-16 13:47:55 +10:00
Morph
b73f678ee8 frontend: Set minimum window size to 640x360 instead of 1280x720 (#3413) 2020-05-15 22:22:27 +02:00
bunnei
bba54e1880 time_zone: Use std::chrono::seconds for strong typing. 2020-05-12 18:44:07 -04:00
David Marcec
a79f060ea2 hid: Clear keyboard states & fix logic issue 
Previously we never cleared the states of the entries and the key would stay held down, also looping over the key bytes for each key lead to setting every bit for the key state instead of the key we wanted
 2020-05-12 12:40:50 +10:00
bunnei
3c8cd62b0d hle: service: time_zone_manager: Use current time zone setting. 2020-05-11 17:55:25 -04:00
bunnei
988e42a3f5 core: settings: Add a setting for time zone. 2020-05-11 17:50:07 -04:00
bunnei
47b97b9577 service: fsp_srv: Stub implementation of OpenMultiCommitManager. 2020-05-11 12:54:30 -04:00
bunnei
ab9ddab0a2 file_sys: savefata_factory: Update to support DeviceSaveData. 2020-05-11 12:54:30 -04:00
bunnei
9c065c013e file_sys: control_metadata: Expose device_save_data_size. 2020-05-11 12:54:30 -04:00
David Marcec
ecc8ccc9d3 Stub SendKeyboardLockKeyEvent 
Needed for Puchikon 4 SmileBASIC 1.0.0
 2020-05-12 01:01:50 +10:00
James Rowe
bc30a591ba
Replace externals with Conan (#3735) 
* Remove git submodules that will be loaded through conan

* Move custom Find modules to their own folder

* Use conan for downloading missing external dependencies

* CI: Change the yuzu source folder user to the user that the containers run on

* Attempt to remove dirty mingw build hack

* Install conan on the msvc build

* Only set release build type when using not using multi config generator

* Re-add qt bundled to workaround an issue with conan qt not downloading prebuilt binaries

* Add workaround for submodules that use legacy CMAKE variables

* Re-add USE_BUNDLED_QT on the msvc build bot
 2020-05-08 17:09:29 -04:00
bunnei
1121960f0e
Merge pull request #3879 from lioncash/global2 
hle_ipc: Eliminate core memory globals
 2020-05-07 19:13:34 -04:00
bunnei
88141bb2d4
Merge pull request #3881 from lioncash/mem-warning 
kernel/memory: Resolve several compiler warnings
 2020-05-05 15:41:18 -04:00
bunnei
929acd4d1e
Merge pull request #3880 from lioncash/encoding 
kernel/memory: Amend potential encoding warnings
 2020-05-04 18:50:29 -04:00
bunnei
500e9c5969
Merge pull request #3843 from ogniK5377/GetPopFromGeneralChannelEvent 
am: IHomeMenuFunctions:GetPopFromGeneralChannelEvent
 2020-05-04 16:20:11 -04:00
bunnei
29fce1a187
Merge pull request #3822 from ogniK5377/GetAccountId 
acc: Return a unique value per account for GetAccountId
 2020-05-03 23:15:03 -04:00
Lioncash
4620580245 kernel/memory: Remove #pragma once within cpp file 
This isn't necessary in a cpp file and will cause warnings on clang.
 2020-05-03 13:42:07 -04:00
Lioncash
1ecaa86a52 kernel/memory: Remove unused includes 
Prevents header churn and needing to recompile these files if these
headers are ever changed in the future.
 2020-05-03 13:41:18 -04:00
Lioncash
a2e61e6542 kernel/memory: Remove unused variables in memory_block_manager 
Prevents unused variable warnings.
 2020-05-03 13:36:20 -04:00
Lioncash
26aee55aef kernel/memory: Make use of std::array consistently in address_space_info 
This allows tuning standard library implementations to enable or disable
range checks at runtime, which is nicer for debugging.
 2020-05-03 13:34:24 -04:00
Lioncash
dfa582169b kernel/memory: Resolve -Wshadow warnings 
Prevents variable name clashing.
 2020-05-03 13:29:42 -04:00
Lioncash
93c083aef1 kernel/memory: Amend potential encoding warnings 
While èis generally representable in some language encodings, in some
it isn't and will result in compilation warnings occurring. To remain
friendly with other language's codepages on Windows, we normalize it to
an ASCII e.
 2020-05-03 13:01:03 -04:00
Lioncash
0ec07e8763 hle_ipc: Eliminate core memory globals 
We can just pass the required instances into the constructor of the
request, eliminating all usages of the global system accessor.
 2020-05-03 12:57:40 -04:00
Morph
3cfa7a89e0
settings: Add anisotropic filtering level to the yuzu configuration log (#3875) 2020-05-03 17:42:17 +02:00
bunnei
8db4feb5b4
Merge pull request #3871 from lioncash/semi 
readable_event: Remove unnecessary semicolon in Signal()
 2020-05-02 23:38:36 -04:00
bunnei
7459215933
Merge pull request #3824 from ogniK5377/GetDisplayVersion 
am: Properly implement GetDisplayVersion
 2020-05-02 23:35:38 -04:00
bunnei
c49f51eaf1
Update src/core/hle/service/am/am.cpp 
Co-authored-by: Mat M. <mathew1800@gmail.com>
 2020-05-02 23:35:31 -04:00
Lioncash
aabf5b2059 readable_event: Remove unnecessary semicolon in Signal() 
Resolves a -Wextra-semi warning.

While we're at it, we can invert the branch to form a guard clause,
unindenting all of the contained code.
 2020-05-02 14:07:31 -04:00
bunnei
30bd77c6e7
Merge pull request #3811 from ogniK5377/audin-init 
audin:u: ListAudioIns, OpenAudioIn, ListAudioInsAuto, OpenAudioInAuto, ListAudioInsAutoFiltered, OpenAudioInProtocolSpecified
 2020-05-02 13:11:52 -04:00
bunnei
5ddcc1b2f5
Merge pull request #3819 from ogniK5377/err-log2 
kernel: Don't fail silently
 2020-05-02 02:51:50 -04:00
bunnei
1bcdf5e61c
Merge pull request #3833 from qwell/caps_su-32-stub 
Add stub for caps:su SetShimLibraryVersion
 2020-05-01 23:34:05 -04:00
bunnei
fd005585f6
Merge pull request #3821 from ogniK5377/InitializeApplicationInfo-fix 
acc: Fix InitializeApplicationInfo
 2020-05-01 22:06:05 -04:00
bunnei
224cf3075c
Merge pull request #3812 from ogniK5377/lisst-qualified-users 
account: ListQualifiedUsers
 2020-05-01 22:05:37 -04:00
David Marcec
d5a69ecb68 nvdrv: Fix GetGpuTime stack corruption 
IoctlGetGpuTime should be 16 bytes, not 8.
 2020-05-02 00:14:37 +10:00
David Marcec
8850d85341 am: IHomeMenuFunctions:GetPopFromGeneralChannelEvent 
QLaunch 1.0.0
 2020-05-01 11:20:43 +10:00
Jason Parker
4b16e93f1a caps:su Stub out SetShimLibraryVersion 
Used by Animal Crossing: New Horizons when trying to take a picture.
 2020-04-30 15:16:53 -04:00
Mat M
f88d2f5739
Merge pull request #3823 from ogniK5377/setvrmode 
am: IsVrModeEnabled & SetVrModeEnabled fixes
 2020-04-30 13:39:16 -04:00
Mat M
ecf1f2e054
Merge pull request #3830 from ogniK5377/GetFriendInvitationStorageChannelEvent 
am: GetFriendInvitationStorageChannelEvent
 2020-04-30 13:38:35 -04:00
Mat M
0a0b676286
Merge pull request #3835 from ogniK5377/GetFreeSpaceSize-GetTotalSpaceSize 
fs-srv: GetFreeSpaceSize & GetTotalSpaceSize
 2020-04-30 13:37:43 -04:00
Mat M
07552d4615
Merge pull request #3832 from ogniK5377/nim-eca-CreateServerInterface 
nim: CreateServerInterface, CreateAccessorInterface, CreateAsyncInterface
 2020-04-30 13:36:04 -04:00
Mat M
e6f4251988
Merge pull request #3831 from ogniK5377/caps-su-names 
caps: Add missing service names to caps:su
 2020-04-30 13:32:53 -04:00
David Marcec
78e5f162e2 fs-srv: GetFreeSpaceSize & GetTotalSpaceSize 
Closes #3533

Turns out the functions were already implemented but just never added
 2020-04-30 23:59:57 +10:00
David Marcec
55e423c8b6 nim: CreateServerInterface, CreateAccessorInterface, CreateAsyncInterface 
Closes #3026
 2020-04-30 23:10:20 +10:00
David Marcec
738140fdd8 caps: Add missing service names to caps:su 
SetShimLibraryVersion, SaveScreenShotEx1 & SaveScreenShotEx2 were missing
 2020-04-30 22:51:06 +10:00
David Marcec
10804d6d0e am: GetFriendInvitationStorageChannelEvent 
Closes #3829
 2020-04-30 22:37:26 +10:00
David Marcec
973c40b63e psm: Mark as debug instead of warning 
No point to emulate battery life. However options are broken out if we ever want to add a setting for it
 2020-04-29 22:39:49 +10:00
David Marcec
9acd336422 am: Properly implement GetDisplayVersion 
Properly implement IApplicationFunctions::GetDisplayVersion
 2020-04-29 22:13:56 +10:00
David Marcec
8bddc750e2 am: IsVrModeEnabled & SetVrModeEnabled fixes 
Return the proper state of vr mode for IsVrModeEnabled
We should not return an error for SetVrModeEnabled. When VR Mode is turned on, it signals to lbl to turn vr mode on, not return an error code
 2020-04-29 21:48:58 +10:00
David Marcec
1417849a2b acc: Return a unique value per account for GetAccountId 2020-04-29 21:09:53 +10:00
David Marcec
1fbc341aba acc: Fix InitializeApplicationInfo 
We're not suppose to pop a u64, should just read the sent pid and check that
 2020-04-29 20:49:35 +10:00
David Marcec
b6538c3e7c kernel: Don't fail silently 2020-04-29 14:53:53 +10:00
Mat M
c3c3e07263
Merge pull request #3818 from ogniK5377/err-log 
Don't fail silently for vi, sm, set and ns services
 2020-04-28 21:41:13 -04:00
Mat M
5cb531b6cf
Merge pull request #3783 from lioncash/pointer 
physical_core: Make use of std::make_unique instead of std::make_shared in ctor
 2020-04-28 21:38:02 -04:00
David Marcec
b4dbf1b9c7 Don't fail silently for vi, sm, set and ns services 2020-04-29 11:15:21 +10:00
David Marcec
2261cf24af kernel: Bad GetInfo ids should not be marked as stubs 
As we currently match hardware and don't return a successful result, these should be marked as errors instead of warnings and as stubs.
 2020-04-29 01:17:59 +10:00
David Marcec
fdbeb90bd0 Updated comment to reflect ListQualifiedUsers better 2020-04-29 01:13:03 +10:00
David Marcec
0f6064e5c9 style: Change AMs & Glues error codes to be dec instead of hex 
Consistency for the rest of the error codes in the codebase
 2020-04-29 00:49:49 +10:00
David Marcec
1276e425d2 marked stubs 2020-04-29 00:43:05 +10:00
David Marcec
a17813c4f4 account: ListQualifiedUsers 
Closes #2844
 2020-04-29 00:37:47 +10:00
David Marcec
fb51a655b8 Audin:u ListAudioIns, OpenAudioIn, ListAudioInsAuto, OpenAudioInAuto, ListAudioInsAutoFiltered, OpenAudioInProtocolSpecified 
Closes #2874
 2020-04-29 00:19:07 +10:00
bunnei
4dca2298f9
Merge pull request #3785 from ogniK5377/set-buffer-count-unit 
vi: Don't let uninitialized data pass as a response for SetBufferCount
 2020-04-27 17:10:28 -04:00
Mat M
e8e04a4b80
Merge pull request #3797 from slashiee/hid-stub 
services: hid: Stub StopSevenSixAxisSensor.
 2020-04-27 15:37:08 -04:00
bunnei
6c7d8073be
Merge pull request #3742 from FernandoS27/command-list 
Optimize GPU Command Lists and Introduce Fast GPU Time Option
 2020-04-27 00:18:46 -04:00
bunnei
11e1629d89
Merge pull request #3744 from lioncash/table2 
service: Update function tables
 2020-04-26 04:15:47 -04:00
M&M
c1ffaa8b29 services: hid: Stub StopSevenSixAxisSensor. 
- Used by The Legend of Zelda: Breath of the Wild v1.6.0
 2020-04-25 15:38:56 -07:00
bunnei
d1e7cf3bdc
Merge pull request #3780 from lioncash/process 
svc: Re-add MapProcessCodeMemory/UnmapProcessCodeMemory
 2020-04-24 23:22:26 -04:00
David Marcec
03a6f3b0f4 vi: Don't let uninitialized data pass as a response for SetBufferCount 
Currently SetBufferCount doesn't write to the out buffer which then contains uninitialized data. This leads to non-zero data which leads to responding with different error codes
 2020-04-24 17:24:58 +10:00
Lioncash
cc84b48ce5 physical_core: Make use of std::make_unique instead of std::make_shared in ctor 
We can also allow unicorn to be constructed in 32-bit mode or 64-bit
mode to satisfy the need for both interpreter instances.

Allows this code to compile successfully of non x86-64 architectures.
 2020-04-24 00:20:58 -04:00
Rodrigo Locatti
f24c67877b
Merge pull request #3777 from lioncash/warn 
page_table: Remove unused captures
 2020-04-23 21:47:54 -03:00
Rodrigo Locatti
db3dcb2f64
Merge pull request #3778 from lioncash/unused-var 
svc: Remove unused variable
 2020-04-23 21:47:24 -03:00
Lioncash
ce7c02735e shared_memory: Amend doxygen reference 
Amends the parameter to match the documentation reference.

Resolves a -Wdocumentation warning with clang.
 2020-04-23 18:42:14 -04:00
Lioncash
4730347f8e svc: Re-add MapProcessCodeMemory/UnmapProcessCodeMemory 
These were lost in the re-implementation of the virtual memory manager.
 2020-04-23 18:12:04 -04:00
Lioncash
bed4865981 svc: Remove unused variable 
Since the VMM refactor, this is no longer used or needed.
 2020-04-23 17:53:26 -04:00
Lioncash
f77b5dfe81 page_table: Remove unused captures 
Any time the lambda function is called, the permission being used in the
capture would be passed in as an argument to the lambda, so the capture
is unnecessary.
 2020-04-23 17:33:08 -04:00
bunnei
ff0c49e1ce
kernel: memory: Improve implementation of device shared memory. (#3707) 
* kernel: memory: Improve implementation of device shared memory.

* fixup! kernel: memory: Improve implementation of device shared memory.

* fixup! kernel: memory: Improve implementation of device shared memory.
 2020-04-23 11:37:12 -04:00
Fernando Sahmkow
b8aef40c56 GPU: Add Fast GPU Time Option. 2020-04-23 08:52:57 -04:00
bunnei
eb26e9e711
Merge pull request #3730 from lioncash/time 
service/time: Remove reliance on the global system accessor
 2020-04-23 02:41:38 -04:00
bunnei
2409fedacf
Merge pull request #3697 from lioncash/declarations 
CMakeLists: Enable -Wmissing-declarations on Linux builds
 2020-04-23 02:18:52 -04:00
bunnei
bf2ddb8fd5
Merge pull request #3677 from FernandoS27/better-sync 
Introduce Predictive Flushing and Improve ASYNC GPU
 2020-04-22 22:09:38 -04:00
bunnei
bee2c64b34
Merge pull request #3725 from MerryMage/fpcr 
thread: FPCR.FZ is likely not 1 (and FPCR.RMode = TieAway and FPCR.DN = 0)
 2020-04-22 19:49:13 -04:00
Fernando Sahmkow
7f44f22451 Correct Linux Compile Error. 2020-04-22 11:36:22 -04:00
Fernando Sahmkow
084ceb925a UI: Replasce accurate GPU option for GPU Accuracy Level 2020-04-22 11:36:04 -04:00
bunnei
e84f82a028
Merge pull request #3699 from FearlessTobi/port-5185 
Port citra-emu/citra#5185: "gdbstub: Fix some gdbstub jankiness"
 2020-04-21 22:26:10 -04:00
bunnei
cd47ccec49
Merge pull request #3745 from bunnei/fix-homebrew-load 
Fix process memory initialization for ELF and NRO
 2020-04-21 18:59:16 -04:00
bunnei
9bf3abcb63
Merge pull request #3698 from lioncash/warning 
General: Resolve minor assorted warnings
 2020-04-21 14:11:18 -04:00
bunnei
48b670d132
Merge pull request #3724 from bunnei/fix-unicorn 
core: arm_unicorn: Fix interpret fallback by temporarily mapping instruction page.
 2020-04-20 23:28:23 -04:00
David
11c63ca969
audio_renderer: Preliminary BehaviorInfo (#3736) 
* audio_renderer: Preliminary BehaviorInfo

* clang format

* Fixed IsRevisionSupported

* fixed IsValidRevision

* Fixed logic error & spelling errors & crash

* Addressed issues
 2020-04-20 22:57:30 -04:00
bunnei
9c12aef2f8 loader: nro: Fix process initialization using ProgramMetadata default. 2020-04-20 18:19:45 -04:00
bunnei
68039addbc loader: elf: Fix process initialization using ProgramMetadata default. 2020-04-20 18:19:45 -04:00
bunnei
f0a7f05070 file_sys: program_metadata: Add a helper function for generating reasonable default metadata. 
- We need this for homebrew process initialization.
 2020-04-20 18:19:45 -04:00
Lioncash
99eaa2e6f2 service: Update function tables 
Keeps the service function tables up to date.

Updated based off information on SwitchBrew.
 2020-04-20 15:53:49 -04:00
Mat M
200f69d2ff
Merge pull request #3739 from MerryMage/disable_cpu_opt 
dynarmic: Add option to disable CPU JIT optimizations
 2020-04-20 14:19:18 -04:00
FearlessTobi
4e99a06c70 npad: Lower log level for VibrateController to Debug 2020-04-20 18:44:57 +02:00
FearlessTobi
6ce0f3575a audren: Lower log level for RequestUpdateImpl to Debug 2020-04-20 18:44:41 +02:00
MerryMage
a3a12deecc dynarmic: Add option to disable CPU JIT optimizations 2020-04-20 13:36:26 +01:00
bunnei
6de36f0b61
Merge pull request #3712 from lioncash/remove 
service: Remove unused RequestParser instances
 2020-04-20 01:04:04 -04:00
bunnei
e3977243e2
Merge pull request #3709 from lioncash/am 
am: Resolve ineffective moves
 2020-04-20 00:15:00 -04:00
Lioncash
bfee33cce3 service/time: Remove reliance on the global system accessor 
Eliminates usages of the global system accessor and instead passes the
existing system instance into the interfaces.
 2020-04-19 16:31:28 -04:00
bunnei
10fb26f69c
Merge pull request #3696 from lioncash/cast-size 
hle_ipc: Remove std::size_t casts where applicable
 2020-04-19 14:24:15 -04:00
MerryMage
2bfac7b61d thread: FPCR.FZ is likely not 1 2020-04-19 08:37:20 +01:00
bunnei
74c27fd1b5 core: arm_unicorn: Fix interpret fallback by temporarily mapping instruction page. 2020-04-19 00:53:23 -04:00
bunnei
89e512ca8d
Merge pull request #3710 from lioncash/nso 
loader/nso: Resolve moves not occurring in DecompressSegment
 2020-04-18 14:44:42 -04:00
Mat M
45964e6fec
Merge pull request #3715 from bunnei/fix-impl-fallthrough 
service: hid: npad: Fix implicit fallthrough errors.
 2020-04-18 14:44:20 -04:00
bunnei
a8d5d08e2e service: hid: npad: Fix implicit fallthrough errors. 2020-04-18 14:41:08 -04:00
bunnei
907ba8794e
Merge pull request #3713 from lioncash/time 
service/time: Minor changes
 2020-04-17 21:04:43 -04:00
Lioncash
7714b02d95 time/system_clock_core: Remove unnecessary initializer 
This is already initialized within the class body.
 2020-04-17 20:04:06 -04:00
Lioncash
b533f18ab9 service/time: Mark IsStandardNetworkSystemClockAccuracySufficient as const 
This doesn't modify internal member state.
 2020-04-17 20:02:45 -04:00
Lioncash
0cfd3b94db service/time: Add virtual destructors where applicable 
Many of these implementations are used to implement a polymorphic
interface. While not directly used polymorphically, this prevents
virtual destruction from ever becoming an issue.
 2020-04-17 19:59:31 -04:00
Lioncash
4d8a8a8033 service: Remove unused RequestParser instances 
These aren't used, so they should be removed to reduce compilation
warnings.
 2020-04-17 19:47:43 -04:00
Lioncash
7e585bce28 memory/slab_heap: Make use of static_cast over reinterpret_cast 
Casting from void* with static_cast is permitted by the standard, so we
can just make use of that instead.
 2020-04-17 19:38:59 -04:00
Lioncash
441a2812ed loader/nso: Resolve moves not occurring in DecompressSegment 
Given the std::vector was const, an automatic move out of the function
could not occur.

We can allow automatic return value optimizations to occur by making the
buffer non-const.
 2020-04-17 19:26:50 -04:00
Lioncash
64f226889c am: Resolve ineffective moves 
Previously const objects were being std::moved, which results in no move
actually occurring. This resolves that.
 2020-04-17 19:22:46 -04:00
bunnei
8bbe74a8dc core: hle: Address various feedback & code cleanup. 
- Should be no functional changes.
 2020-04-17 00:59:36 -04:00
bunnei
92caa003a8 core: device_memory: Remove incorrect usage of constexpr. 2020-04-17 00:59:36 -04:00
bunnei
6f3266e98b memory: Add copyright notice for Atmosphere where applicable. 2020-04-17 00:59:35 -04:00
bunnei
02547a0cb4 kernel: Remove old VMManager class. 2020-04-17 00:59:35 -04:00
bunnei
bebfb05c1b loader: nso: Fix loader size and arguments. 2020-04-17 00:59:35 -04:00
bunnei
83761d5316 loader: elf/kip/nro: Updates for new VMM. 2020-04-17 00:59:35 -04:00
bunnei
37b79ebe85 service: ldr: Updates for new VMM. 
- Includes removing some service impls. that are untested.
 2020-04-17 00:59:35 -04:00
bunnei
a8292f6cd9 kernel: memory: page_table: Simplify GetPhysicalAddr impl. 2020-04-17 00:59:35 -04:00
bunnei
c629e544a7 kernel: svc: Updates for new VMM. 
- Includes removing some SVC impls. that are untested.
 2020-04-17 00:59:34 -04:00
bunnei
ff5d5b6f41 core: memory: Fix memory access on page boundaries. 
- Fixes Super Smash Bros. Ultimate.
 2020-04-17 00:59:34 -04:00
bunnei
f7c03610e1 core: memory: Updates for new VMM. 2020-04-17 00:59:34 -04:00
bunnei
1d5923e150 core: gdbstub: Updates for new VMM. 2020-04-17 00:59:34 -04:00
bunnei
c7bc7986bb core: reporter: Updates for new VMM. 2020-04-17 00:59:33 -04:00
bunnei
18c4bb6f5c memory: cheat_engine: Updates for new VMM. 2020-04-17 00:59:33 -04:00
bunnei
108564df57 kernel: process: Updates for new VMM. 2020-04-17 00:59:33 -04:00
bunnei
77382ac2b2 service: pl_u: Update for new shared memory layout. 2020-04-17 00:59:33 -04:00
bunnei
67b3df683b service: time: Update for new shared memory layout. 2020-04-17 00:59:33 -04:00
bunnei
8eca0f9cd2 service: hid: Update for new shared memory layout. 2020-04-17 00:59:33 -04:00
bunnei
8bbc38a7bd service: irs: Update for new shared memory layout. 2020-04-17 00:59:32 -04:00
bunnei
fc61cb44ee kernel: resource_limit: Reserve physical memory. 2020-04-17 00:59:32 -04:00
bunnei
8f75524e55 kernel: Initialize memory layout for new VMM. 2020-04-17 00:59:32 -04:00
bunnei
11c02a50e9 core: system: Rename GetDeviceManager -> DeviceManager. 
- More consistent with other system components.
 2020-04-17 00:59:32 -04:00
bunnei
3fcc4cab4f kernel: transfer_memory: Refactor for new VMM. 2020-04-17 00:59:32 -04:00
bunnei
c53454ff46 core: Construct/Destruct DeviceMemory on Init/Shutdown. 2020-04-17 00:59:32 -04:00
bunnei
d0162fc3d7 kernel: shared_memory: Refactor for new VMM. 2020-04-17 00:59:32 -04:00
bunnei
a040a15246 core: device_memory: Update to use VirtualBuffer class. 2020-04-17 00:59:31 -04:00
bunnei
a238d08f71 kernel: errors: Add ERR_OUT_OF_RESOURCES. 2020-04-17 00:59:31 -04:00
bunnei
ffc3de762b kernel: process_capability: Update to use Memory::PageTable. 2020-04-17 00:59:31 -04:00
bunnei
84f1b6d530 kernel: memory: Add PageTable class, to manage process address space. 2020-04-17 00:59:31 -04:00
bunnei
cfae8a1c1a kernel: memory: Add MemoryLayout class, to build physical memory layout. 2020-04-17 00:59:31 -04:00
bunnei
5d6e8a5b44 kernel: memory: Add MemoryManager class, to manage page heaps. 2020-04-17 00:59:30 -04:00
bunnei
548ef190ab kernel: memory: Add MemoryBlockManager class, to manage memory blocks. 2020-04-17 00:59:30 -04:00
bunnei
3927012734 kernel: memory: Add PageHeap class, to manage a heap of pages. 2020-04-17 00:59:30 -04:00
bunnei
dc720311cc kernel: memory: Add PageLinkedList class, to manage a list of pages. 2020-04-17 00:59:30 -04:00
bunnei
81cb4d3c7f kernel: memory: Add system_control code, which will be used for ASLR support. 2020-04-17 00:59:30 -04:00
bunnei
fc040b5b70 physical_memory: Add missing include for <vector>. 2020-04-17 00:59:30 -04:00
bunnei
c2f4dcb1e3 kernel: memory: Add MemoryBlock class, for managing memory blocks and their state. 2020-04-17 00:59:29 -04:00
bunnei
ea5ee9918e kernel: memory: Add memory_types.h, for things that are commonly used in memory code. 2020-04-17 00:59:29 -04:00
bunnei
d364e7cf09 kernel: memory: Add SlabHeap class, for managing memory heaps. 
- This will be used for TLS pages, among other things.
 2020-04-17 00:59:29 -04:00
bunnei
14aa65ce00 kernel: memory: Add AddressSpaceInfo class, for managing the memory address space. 2020-04-17 00:59:29 -04:00
bunnei
dc25c86556 core: device_manager: Add a simple class to manage device RAM. 2020-04-17 00:59:29 -04:00
bunnei
f1b607829e dynarmic: Enable strict alignment checks. 
- Also add a missing include.
 2020-04-17 00:59:29 -04:00
bunnei
4caff51710 core: memory: Move to Core::Memory namespace. 
- helpful to disambiguate Kernel::Memory namespace.
 2020-04-17 00:59:28 -04:00
bunnei
ad48ebb2c8 core: kernel: Add svc_types header to include SVC-specific types. 2020-04-17 00:59:28 -04:00
bunnei
82d457af37 core: kernel: Move SVC to its own namesapce. 2020-04-17 00:59:28 -04:00
bunnei
b0e3cbef7a kernel: resource_limit: Improvements to implementation. 2020-04-17 00:59:27 -04:00
bunnei
7aa0e4a7ca loader: nso: Fix loading of static objects to be properly sized and aligned. 2020-04-17 00:59:27 -04:00
bunnei
f2676efe23 process: SetupMainThread: Zero out argument on process start. 2020-04-17 00:11:50 -04:00
bunnei
0f4f90cd04 arm_interface: Ensure ThreadContext is zero'd out. 2020-04-17 00:11:50 -04:00
Lioncash
e2d8be1ca2 General: Resolve warnings related to missing declarations 2020-04-16 23:43:34 -04:00
MerryMage
1cc9507bc5 gdbstub: Fix some gdbstub jankiness 
1. Ensure that register information available to gdbstub is most up-to-date.
2. There's no reason to check for current_thread == thread when emitting a trap.
   Doing this results in random hangs whenever a step happens upon a thread switch.
 2020-04-17 05:41:43 +02:00
bunnei
86f9c9aa1c
Merge pull request #3671 from lioncash/switch 
kernel/thread: Resolve -Wswitch warnings
 2020-04-16 23:30:32 -04:00
Lioncash
8f9c599c9f key_manager: Resolve missing field initializer warning 2020-04-16 22:45:44 -04:00
Lioncash
337f2dc11f time_zone_manager: Resolve sign conversion warnings 
ttis and ats will never exceed the length of INT32_MAX in our case, so
this is safe.
 2020-04-16 22:23:59 -04:00
Lioncash
77356731a9 hle_ipc: Remove std::size_t casts where applicable 
These were added in the change that enabled -Wextra on linux builds so
as not to introduce interface changes in the same change as a
build-system flag addition.

Now that the flags are enabled, we can freely change the interface to
make these unnecessary.
 2020-04-16 22:02:10 -04:00
bunnei
79c1269f0f
Merge pull request #3673 from lioncash/extra 
CMakeLists: Specify -Wextra on linux builds
 2020-04-16 21:12:33 -04:00
Markus Wick
fedf750e1b externals: Move LibreSSL linking to httplib. 
Neither core nor web_services use OpenSSL nor LibreSSL.
However they need to link them as it's a requirement of httplib.
So let's declare this within httplib instead of core and web_services.
 2020-04-16 16:46:33 +02:00
Rodrigo Locatti
db67e017cb
Merge pull request #3659 from bunnei/time-calc-standard-user 
service: time: Implement CalculateStandardUserSystemClockDifferenceByUser.
 2020-04-16 02:51:57 -03:00
Lioncash
1c340c6efa CMakeLists: Specify -Wextra on linux builds 
Allows reporting more cases where logic errors may exist, such as
implicit fallthrough cases, etc.

We currently ignore unused parameters, since we currently have many
cases where this is intentional (virtual interfaces).

While we're at it, we can also tidy up any existing code that causes
warnings. This also uncovered a few bugs as well.
 2020-04-15 21:33:46 -04:00
Lioncash
213fff67bc CMakeLists: Make -Wreorder a compile-time error 
This can result in silent logic bugs within code, and given the amount
of times these kind of warnings are caused, they should be flagged at
compile-time so no new code is submitted with them.
 2020-04-15 14:14:41 -04:00
Lioncash
521c4c33b5 kernel/thread: Resolve -Wswitch warnings 2020-04-15 13:48:14 -04:00
bunnei
eb676c343a service: time: Implement CalculateStandardUserSystemClockDifferenceByUser. 
- Used by Animal Crossing: New Horizons.
 2020-04-14 22:28:41 -04:00
Zach Hilman
e366b4ee1f
Merge pull request #3660 from bunnei/friend-blocked-users 
service: friend: Stub IFriendService::GetBlockedUserListIds.
 2020-04-14 16:59:46 -04:00
bunnei
fc35803f91 file_sys: patch_manager: Return early when there are no layers to apply. 2020-04-14 16:25:55 -04:00
bunnei
598740f1dd service: friend: Stub IFriendService::GetBlockedUserListIds. 
- This is safe to stub, as there should be no adverse consequences from reporting no blocked users.
 2020-04-14 16:20:51 -04:00
bunnei
a9f866264d
Merge pull request #3606 from ReinUsesLisp/nvflinger 
service/vi: Partially implement BufferQueue disconnect
 2020-04-12 11:44:48 -04:00
Rodrigo Locatti
75e39f7f88
Merge pull request #3635 from FernandoS27/buffer-free 
Buffer queue: Correct behavior of free buffer.
 2020-04-11 17:58:15 -03:00
bunnei
51c6688e21
Merge pull request #3594 from ReinUsesLisp/vk-instance 
yuzu: Drop SDL2 and Qt frontend Vulkan requirements
 2020-04-10 20:06:55 -04:00
Fernando Sahmkow
486a42c45a Buffer queue: Correct behavior of free buffer. 
This corrects the behavior of free buffer after witnessing it in an
unrelated hardware test. I haven't found any games affected by it but in
name of better accuracy we'll correct such behavior.
 2020-04-10 16:44:28 -04:00
ReinUsesLisp
8c0ba9c6fe service/vi: Partially implement BufferQueue disconnect 2020-04-10 01:00:50 -03:00
Rodrigo Locatti
36f607217f
Merge pull request #3610 from FernandoS27/gpu-caches 
Refactor all the GPU Caches to use VAddr for cache addressing
 2020-04-09 17:59:21 -03:00
Fernando Sahmkow
913f42a3a7 Memory: Address Feedback. 2020-04-08 13:40:46 -04:00
ReinUsesLisp
bf1d66b7c0 yuzu: Drop SDL2 and Qt frontend Vulkan requirements 
Create Vulkan instances and surfaces from the Vulkan backend.
 2020-04-07 16:32:19 -03:00
enler
27f122c48c
file_sys: fix LayeredFS error when loading some games made with… (#3602) 
* fix LayeredFS error when loading some games made with the Unity
 2020-04-07 02:03:32 +02:00
Fernando Sahmkow
7fcd0fee6d Buffer Cache: Use vAddr instead of physical memory. 2020-04-06 09:23:06 -04:00
Fernando Sahmkow
9c0f40a1f5 GPU: Setup Flush/Invalidate to use VAddr instead of CacheAddr 2020-04-06 09:21:46 -04:00
Fernando Sahmkow
9d8886b1a4
Merge pull request #3563 from bunnei/fix-ldr-memstate 
services: ldr: Fix MemoryState for read/write regions of NROs.
 2020-04-03 10:14:56 -04:00
Rodrigo Locatti
825a6e2615
Merge pull request #3552 from jroweboy/single-context 
Refactor Context management (Fixes renderdoc on opengl issues)
 2020-04-02 01:38:25 -03:00
Morph
224a75d839
capsrv: Split Capture services into individual files and stub GetAlbumContentsFileListForApplication (#3571) 
* Organize capture services into individual files

* Stub GetAlbumContentsFileListForApplication

* Address feedback
 2020-03-31 19:16:36 -04:00
bunnei
2c9879d2eb
Merge pull request #3568 from bunnei/time-calcspan 
services: time: Implement CalculateSpanBetween.
 2020-03-29 00:03:55 -04:00
bunnei
ffe1e2b5ec
Merge pull request #3562 from perillamint/vrsvc 
am: Implement VR related APIs
 2020-03-28 13:32:52 -04:00
bunnei
8a6a25e4b6 services: hid: Stub InitializeSevenSixAxisSensor. 
- Used by Super Smash Bros. Ultimate v7.0.0.
 2020-03-27 10:48:01 -04:00
bunnei
a60f34a850 services: time: Implement CalculateSpanBetween. 
- Used by Super Smash Bros. Ultimate.
 2020-03-27 10:42:13 -04:00
perillamint
a429644672 am: Implement VR related APIs 
Implement (and stub) VR related APIs in AM sysmodule.

This fixes issue #2938
 2020-03-27 18:22:28 +09:00
bunnei
5228bd0bb9 services: ldr: Fix MemoryState for read/write regions of NROs. 
- Fixes #3541, used by Final Fantasy VIII Remastered.
 2020-03-26 15:52:59 -04:00
James Rowe
cf9c94d401 Address review and fix broken yuzu-tester build 2020-03-25 23:32:42 -06:00
James Rowe
282adfc70b Frontend/GPU: Refactor context management 
Changes the GraphicsContext to be managed by the GPU core. This
eliminates the need for the frontends to fool around with tricky
MakeCurrent/DoneCurrent calls that are dependent on the settings (such
as async gpu option).

This also refactors out the need to use QWidget::fromWindowContainer as
that caused issues with focus and input handling. Now we use a regular
QWidget and just access the native windowHandle() directly.

Another change is removing the debug tool setting in FrameMailbox.
Instead of trying to block the frontend until a new frame is ready, the
core will now take over presentation and draw directly to the window if
the renderer detects that its hooked by NSight or RenderDoc

Lastly, since it was in the way, I removed ScopeAcquireWindowContext and
replaced it with a simple subclass in GraphicsContext that achieves the
same result
 2020-03-24 21:03:42 -06:00
bunnei
f8382c9d9d
Merge pull request #3524 from FearlessTobi/port-5106 
Port citra-emu/citra#5106: "gdbstub: Ensure gdbstub doesn't drop packets crucial to initialization"
 2020-03-24 16:50:58 -04:00
FearlessTobi
4afebf26b6 sm/controller: Increase PointerBufferSize 
This increases the PointerBufferSize as a lager one is required by some services.
This change is still not hw-accurate, but it is proven to work in Ryujinx.

Instead of using a hardcoded size, we should figure out the specific values for each service in the future. Some of them can be taken from Atmosphere: https://github.com/Atmosphere-NX/Atmosphere/search?q=PointerBufferSize.
 2020-03-23 03:19:30 +01:00
bunnei
e731c4b991
Merge pull request #3477 from FearlessTobi/webapplet-shit 
core/web_browser: Allow WebApplet to exit gracefully when an error occurs
 2020-03-22 13:11:02 -04:00
FearlessTobi
977418c65b core/web_browser: Allow WebApplet to exit gracefully when an error occurs 
Currently, yuzu just freezes when an error occurs while Initializing the WebApplet.
From a user perspective, this obviously isn't great as the game just softlocks.
With this change, yuzu will call the Finalize method, so to the game it seems like as the user just exited the WebApplet normally.

This works around https://github.com/yuzu-emu/yuzu/issues/2852.
 2020-03-22 16:01:13 +01:00
Dan
06dea163fa set: implement GetRegionCode 2020-03-19 10:37:42 +01:00
bunnei
bc681dc555
Merge pull request #3527 from FearlessTobi/output-mode 
yuzu: Save sound output mode and set it to Stereo by default
 2020-03-18 23:19:22 -04:00
ReinUsesLisp
ac7ee21331 time_zone_content_manager: Fix out of bounds read 
There were cases where raw_data didn't contain enough
space to hold the zero terminator.

This was caught with -fsanitize=address.
 2020-03-18 19:06:16 -03:00
FearlessTobi
cdeadd448b yuzu: Save sound output mode and set it to Stereo by default 2020-03-17 19:03:00 +01:00
Gauvain "GovanifY" Roussel-Tarbouriech
eae2ed6b07 gdbstub: small logic bug fix with defer_start 2020-03-17 11:18:39 +01:00
Gauvain "GovanifY" Roussel-Tarbouriech
38036eb1c8 gdbstub: Ensure gdbstub doesn't drop packets crucial to initialization 2020-03-17 11:18:13 +01:00
bunnei
ca2d228c9d
Merge pull request #3497 from FernandoS27/microprogfile-extend 
Small corrections and features to microprofile
 2020-03-12 12:14:03 -04:00
Fernando Sahmkow
95b804ff05 NVFlinger: Do the microprofile Flip after processing a valid frame. 2020-03-12 10:52:44 -04:00
Vitor Kiguchi
e891ff9a0c framebuffer_layout.h: drop the use of enum for screen dimensions. 
+clang format
 2020-03-11 14:22:28 -03:00
Rodrigo Locatti
22e825a3bc
Merge pull request #3301 from ReinUsesLisp/state-tracker 
video_core: Remove gl_state and use a state tracker based on dirty flags
 2020-03-09 18:34:37 -03:00
bunnei
84e9f9f395
Merge pull request #3452 from Morph1984/anisotropic-filtering 
frontend/Graphics: Add "Advanced" graphics tab and experimental Anisotropic Filtering support
 2020-03-07 22:28:35 -05:00
bunnei
dba112e510 core: hle: Implement separate A32/A64 SVC interfaces. 2020-03-02 21:52:03 -05:00
bunnei
c083ea7d78 core: Implement separate A32/A64 ARM interfaces. 2020-03-02 21:51:57 -05:00
bunnei
6fc485a607 core: loader: Remove check for 32-bit. 2020-03-02 21:43:15 -05:00
bunnei
64facb403e core: dynarmic: Add CP15 from Citra. 2020-03-02 21:43:15 -05:00
bunnei
08c638f249
Merge pull request #3464 from FernandoS27/jit-fix 
ARM_Interface: Cache the JITs instead of deleting/recreating.
 2020-03-02 21:41:43 -05:00
ReinUsesLisp
eed789d0d1 video_core: Reintroduce dirty flags infrastructure 2020-02-28 17:56:41 -03:00
Morph
7ee6065178 Create an "Advanced" tab in the graphics configuration tab and add anisotropic filtering levels. 2020-02-27 21:34:00 -05:00
bunnei
969357af1a
Merge pull request #3430 from bunnei/split-presenter 
Port citra-emu/citra#4940: "Split Presentation thread from Render thread"
 2020-02-27 19:51:55 -05:00
Morph
e1efab1f51
AM/ICommonStateGetter: Stub SetLcdBacklighOffEnabled (#3454) 
* Stub SetLcdBacklighOffEnabled

Used by Super Smash Bros. Ultimate
We require backlight services to be implemented to turn on/off the backlight.

* Address feedback
 2020-02-27 17:49:23 +01:00
bunnei
aef159354c renderer_opengl: Move Frame/FrameMailbox to OpenGL namespace. 2020-02-26 18:28:50 -05:00
Fernando Sahmkow
f3d4d4eaa8 ARM_Interface: Cache the JITs instead of deleting/recreating. 
This was a bug inherited from citra which was fixed by then at some 
time. This commit corrects such bug and ensures JITs are correctly 
recycled.
 2020-02-26 15:53:47 -04:00
bunnei
01a05b48b7
Merge pull request #3431 from CJBok/npad-fix 
InputCommon: analog_from_button get direction implementation
 2020-02-25 21:39:26 -05:00
bunnei
667f026c95 core: frontend: Refactor scope_acquire_window_context to scope_acquire_context. 2020-02-25 21:23:00 -05:00
bunnei
2e16c23784 frontend: sdl2: emu_window: Implement separate presentation thread. 2020-02-25 21:23:00 -05:00
bunnei
dc672ca4b3 renderer_opengl: Add texture mailbox support for presenter thread. 2020-02-25 21:22:59 -05:00
bunnei
0c82b00dfd core: frontend: emu_window: Add TextureMailbox class. 2020-02-25 21:22:57 -05:00
bunnei
571451bdfe core: settings: Add setting to enable vsync, which is on by default. 2020-02-25 20:57:02 -05:00
Fernando Sahmkow
3d0a2375ca Scheduler: Inline global scheduler in Scheduler Lock. 2020-02-22 12:39:17 -04:00
Fernando Sahmkow
a1bf353780 Kernel: Correct pending feedback. 2020-02-22 11:51:03 -04:00
Fernando Sahmkow
b9472eae44 System: Expose Host thread registering routines from kernel. 2020-02-22 11:18:07 -04:00
Fernando Sahmkow
d219a96cc8 Kernel: Address Feedback. 2020-02-22 11:18:07 -04:00
Fernando Sahmkow
ea956c823e Kernel: Implement Scheduler locks 2020-02-22 11:18:07 -04:00
Fernando Sahmkow
5c90d22f3d Kernel: Implement Time Manager. 2020-02-22 11:18:07 -04:00
Fernando Sahmkow
179bafa7cb Kernel: Rename ThreadCallbackHandleTable and Setup Thread Ids on Kernel. 2020-02-22 11:18:06 -04:00
Fernando Sahmkow
0728dfef84 Kernel: Make global scheduler depend on KernelCore 2020-02-22 11:18:06 -04:00
Brian Clinkenbeard
ad4e5c15fb httplib compatibility 2020-02-18 18:04:33 -08:00
CJBok
23c4cc80e2 analog_from_button get direction implementation 2020-02-18 06:45:37 +01:00
bunnei
72d4c6fee0
Merge pull request #3412 from Morph1984/aspect-ratio 
GUI: Add aspect ratio dropdown
 2020-02-17 22:02:18 -05:00
bunnei
26006cbd2c
Merge pull request #3420 from namkazt/master2 
nvhost_gpu: implement ChannelSetTimeslice
 2020-02-17 00:31:11 -05:00
Nguyen Dac Nam
5257a83ebe
IUserLocalCommunicationService: add function Initialize2 2020-02-16 13:24:34 +07:00
Nguyen Dac Nam
6c0eb6026b
HLE: correct function name of IUserLocalCommunicationService 
402: function name should be Initialize2 (7.0.0+) not SetOperationMode
Follow by: https://switchbrew.org/wiki/LDN_services#IUserLocalCommunicationService
 2020-02-16 13:14:06 +07:00
namkazy
7fadc9c180 nvhost_gpu: implement ChannelSetTimeslice 2020-02-16 11:53:03 +07:00
bunnei
f552d553ba
Merge pull request #3401 from FernandoS27/synchronization 
Set of refactors for Kernel Synchronization and Hardware Constants
 2020-02-14 14:40:20 -05:00
Morph
c3d0a0d627 Add 4:3 aspect ratio and address feedback 2020-02-14 14:39:04 -05:00
Fernando Sahmkow
829d8c0d6b Core: Correct compilition in GCC 2020-02-14 05:53:30 -04:00
Morph
20dc2e3622 Address feedback 2020-02-14 00:06:26 -05:00
Morph
22f58cca5e Use enumeration instead of magic numbers 2020-02-13 23:13:23 -05:00
Morph
27e19f87c6 Add following aspect ratios: 16:9, 21:9, Stretch to Window 
Available as a drop down within the configure graphics tab.
 2020-02-13 22:17:28 -05:00
bunnei
74feed372c
Merge pull request #3400 from makigumo/patch-1 
update hwopus DecodeInterleaved for FW 7.0.0+
 2020-02-13 21:26:13 -05:00
Fernando Sahmkow
2bc949628d Core: Address Feedback 2020-02-13 19:10:33 -04:00
Lioncash
be269e21a5 address_arbiter: Collapse loops in InsertThread() and RemoveThread() 
Same behavior, but without the need to explicitly loop through
everything manually.
 2020-02-12 15:34:07 -05:00
Lioncash
9f2c703137 address_arbiter: Simplify GetThreadsWaitingOnAddress() 
Simplifies the overall function and also allows for it to become a
const-qualified member function.
 2020-02-12 15:10:16 -05:00
bunnei
8f8dda2d5b
Merge pull request #3403 from lioncash/debug 
bcat/backend: Prevent fmt exception in debug log within NullBackend::Clear()
 2020-02-12 11:17:43 -05:00
Lioncash
f00a54f508 bcat/backend: Make formatting of passphrase consistent in NullBackend::SetPassphrase() 
Aligns the '=' to be consistent with the rest of the logs within this
source file.
 2020-02-12 01:18:29 -05:00
Lioncash
eefd97e80d bcat/backend: Prevent fmt exception in debug log within NullBackend::Clear() 
A formatting specifier within Clear wasn't being used, which will cause
fmt to throw an exception. This fixes that.
 2020-02-12 01:14:47 -05:00
Lioncash
b80c348b09 kernel/thread: Remove trivial usages of the global system accessor 
We can just use the kernel member variable directly instead of going
through the system to obtain the same thing.
 2020-02-12 01:00:41 -05:00
Fernando Sahmkow
1e6f8aba04 Core: Set all hardware emulation constants in a single file. 2020-02-11 20:19:11 -04:00
Fernando Sahmkow
d23d504d77 Kernel: Refactor synchronization to better match RE 2020-02-11 18:47:31 -04:00
makigumo
926ea5a16d
update hwopus DecodeInterleaved for FW 7.0.0+ 
trivial change,
see https://switchbrew.org/wiki/Audio_services#IHardwareOpusDecoder
 2020-02-11 18:41:04 +01:00
Fernando Sahmkow
c5aefe42aa Kernel: Change WaitObject to Synchronization object. In order to better reflect RE. 2020-02-11 10:46:25 -04:00
bunnei
7b07e521ca hle: services: Use std::shared_ptr instead of copy by value. 2020-02-07 23:02:26 -05:00
bunnei
aa3f9b9606
Merge pull request #3381 from bunnei/ipc-fix 
hle: services: Fix prepo IPC, and add better error checking.
 2020-02-07 16:25:42 -05:00
bunnei
ba53543da6 kernel: transfer_memory: Properly reserve and reset memory region. 2020-02-05 23:06:54 -05:00
Zach Hilman
7a547b9342 wait_object: Make wait behavior only require one object to signal. 
- This was holdover from citra.
 2020-02-05 23:06:53 -05:00
bunnei
3a0c1e79f8 am: Correct IPC object count mismatch. 2020-02-05 23:06:53 -05:00
bunnei
77da74e17a services: am: Clear events on PopOutData and PopInteractiveOutData. 2020-02-05 23:06:52 -05:00
bunnei
84e895cdd6 am: Refactor IStorage interface. 2020-02-05 23:06:52 -05:00
bunnei
3557fa25d0 applets: software_keyboard: Signal state change on end of interactive session. 2020-02-05 23:06:51 -05:00
bunnei
be5fcffb89 applets: software_keyboard: Minor cleanup. 2020-02-05 23:06:50 -05:00
bunnei
2245c24e21 services: prepo: Fix IPC interface with SaveReport/SaveReportWithUser. 2020-02-05 22:52:35 -05:00
bunnei
9751ccc5e0 hle_ipc: Add error checking to read/write buffer access. 2020-02-05 22:52:35 -05:00
bunnei
c31ec00d67
Merge pull request #3337 from ReinUsesLisp/vulkan-staged 
yuzu: Implement Vulkan frontend
 2020-02-03 16:56:25 -05:00
bunnei
69a6796de1
Merge pull request #3284 from CJBok/hid-fix 
hid: Fix analog sticks directional states
 2020-02-01 14:02:41 -05:00
bunnei
c18f9898d9
Merge pull request #3364 from lioncash/thread 
core/arm: Remove usage of global GetCurrentThread()
 2020-01-31 11:13:24 -05:00
bunnei
6b5b01b29f
Merge pull request #3363 from lioncash/unique_ptr 
kernel/physical_core: Make use of std::unique_ptr instead of std::shared_ptr
 2020-01-30 23:33:02 -05:00
bunnei
91b0a3f799
Revert "system_archive: Fix Korean and Chinese fonts" 2020-01-30 22:02:15 -05:00
Lioncash
472319e573 core/arm: Remove usage of global GetCurrentThread() 
Now both CPU backends go through their referenced system instance to
obtain the current thread.
 2020-01-30 18:52:25 -05:00
Lioncash
2de2bb980e kernel/physical_core: Make use of std::unique_ptr 
shared_ptr was used in 2d1984c20c due to a
misunderstanding of how the language generates move constructors and
move assignment operators.

If a destructor is user-provided, then the compiler won't generate the
move constructor and move assignment operators by default--they must be
explicitly opted into.

The reason for the compilation errors is due to the fact that the
language will fall back to attempting to use the copy constructor/copy
assignment operators if the respective move constructor or move
assignment operator is unavailable.

Given that we explicitly opt into them now, the the move constructor and
move assignment operators will be generated as expected.
 2020-01-30 18:42:40 -05:00
Lioncash
16e7b7b83d core/cpu_manager: Remove unused includes 
Nothing from these headers are used within this source file, so we can
remove them.
 2020-01-30 18:30:57 -05:00
Lioncash
51927bc9dc kernel/physical_core: Remove unused kernel reference member variable 
This isn't used within the class, so it can be removed to simplify the
overall interface.

While we're in the same area, we can simplify a unique_ptr reset() call.
 2020-01-30 18:29:57 -05:00
bunnei
985d0f35e5
Merge pull request #3353 from FernandoS27/aries 
System: Refactor CPU Core management and move ARMInterface and Schedulers to Kernel
 2020-01-30 18:13:59 -05:00
bunnei
8a7cdfc3ff
Merge pull request #3151 from FearlessTobi/fix-korean 
system_archive: Fix Korean and Chinese fonts
 2020-01-30 15:09:55 -05:00
ReinUsesLisp
f92cbc5501 yuzu: Implement Vulkan frontend 
Adds a Qt and SDL2 frontend for Vulkan. It also finishes the missing
bits on Vulkan initialization.
 2020-01-29 17:53:11 -03:00
ReinUsesLisp
788d57d723 settings: Add settings for graphics backend 2020-01-29 17:53:11 -03:00
ReinUsesLisp
e651e54b85 core: Only wait for idle on gpu_core when it was initialized 
This fixes crashes when a Vulkan device fails to initialize.
 2020-01-29 17:53:11 -03:00
Fernando Sahmkow
2d1984c20c System: Address Feedback 2020-01-27 09:54:11 -04:00
Fernando Sahmkow
de4b01f75d System: Correct PrepareReschedule. 2020-01-26 14:32:50 -04:00
Fernando Sahmkow
a1630ab53e Kernel: Remove a few global instances from the kernel. 2020-01-26 14:23:46 -04:00
Fernando Sahmkow
e4a1ead897 Core: Refactor CpuCoreManager to CpuManager and Cpu to Core Manager. 
This commit instends on better naming the new purpose of this classes.
 2020-01-26 14:07:22 -04:00
Fernando Sahmkow
450341b397 ArmInterface: Delegate Exclusive monitor factory to exclusive monitor interfasce. 2020-01-26 10:28:23 -04:00
Fernando Sahmkow
4d6a86b03f Core: Refactor CPU Management. 
This commit moves ARM Interface and Scheduler handling into the kernel.
 2020-01-25 18:55:32 -04:00
bunnei
2a822f3378 bsd: Stub several more functions. 
- Required for Little Town Hero to boot further.
 2020-01-25 00:47:15 -05:00
FearlessTobi
845a5dbca9 Disable clang-format for font files 2020-01-24 23:54:19 +01:00
Fernando Sahmkow
ab89ced244 Kernel: Implement Physical Core. 2020-01-24 15:38:20 -04:00
bunnei
f64adcfc37
Merge pull request #3340 from SciresM/pmdx 
loader: provide default arguments (zero byte) to NSOs
 2020-01-24 10:31:43 -05:00
fearlessTobi
ac3690f205 Input: UDP Client to provide motion and touch controls 
An implementation of the cemuhook motion/touch protocol, this adds the
ability for users to connect several different devices to citra to send
direct motion and touch data to citra.

Co-Authored-By: jroweboy <jroweboy@gmail.com>
 2020-01-23 20:55:26 +01:00
bunnei
ed76c71319 service: time: Implement ToPosixTimeWithMyRule. 
- Used by Pokemon Mystery Dungeon.
 2020-01-22 23:20:19 -05:00
Michael Scire
5a7eecc3ad loader: provide default arguments (zero byte) to NSOs 
Certain newer unity games (Terraria, Pokemon Mystery Dungeon) require
that the argument region be populated. Failure to do so results in
an integer underflow in argument count, and eventually an unmapped
read at 0x800000000. Providing this default fixes this.

Note that the behavior of official software is as yet unverified,
arguments-wise.
 2020-01-22 20:14:06 -08:00
bunnei
7113236b30 time: Fix month off-by-one error. 
- Fixes timestamp in ZLA and Astral Chain saves.
 2020-01-20 14:20:32 -05:00
bunnei
8b9f433d95
Merge pull request #3271 from bunnei/time-rewrite 
service: time: Rewrite implementation of glue services.
 2020-01-19 22:45:05 -05:00
FearlessTobi
4e9331f45d system_archive: Fix Chinese font 
Adds the proper OSS font for the Chinese language.
 2020-01-19 15:09:53 +01:00
FearlessTobi
999e3f89b9 system_archive: Fix Korean font 
Fixes Korean fonts when using Open-source system archives.
 2020-01-19 15:09:50 +01:00
Markus Wick
56672b8c98 core/memory: Create a special MapMemoryRegion for physical memory. 
This allows us to create a fastmem arena within the memory.cpp helpers.
 2020-01-18 08:38:47 +01:00
Markus Wick
55103da066 core/hle: Simplify PhysicalMemory usage in vm_manager. 2020-01-18 08:29:19 +01:00
Markus Wick
7e94e544f4 core/loaders: Simplify PhysicalMemory usage. 
It is currently a std::vector, however we might want to replace it with a more fancy allocator.
So we can't use the C++ iterators any more.
 2020-01-18 08:29:19 +01:00
CJBok
635deb70d4 Moved analog direction logic to sdl_impl 2020-01-15 11:25:15 +01:00
CJBok
231d9c10f3 Corrected directional states sensitivity 2020-01-14 21:51:58 +01:00
Markus Wick
c76ffa5019 core/kernel: Fix GetTotalPhysicalMemoryUsed. 
module._memory was already moved over to a new shared_ptr.
So code_memory_size was not increased at all.

This lowers the heap space and so saves a bit of memory, usually between 50 to 100 MB.

This fixes a regression of c0a01f3adc
 2020-01-11 14:04:44 +01:00
CJBok
ae7fd01e38 hid: Fix analog sticks directional states 2020-01-09 02:40:55 +01:00
bunnei
319c4d2108
Merge pull request #3272 from bunnei/vi-close-layer 
service: vi: Implement CloseLayer.
 2020-01-07 12:45:34 -05:00
bunnei
09908207fb
Merge pull request #3261 from degasus/page_table 
core/memory + arm/dynarmic: Use a global offset within our arm page table.
 2020-01-06 11:56:59 -05:00
bunnei
89fc75d769
Merge pull request #3257 from degasus/no_busy_loops 
video_core: Block in WaitFence.
 2020-01-06 00:09:57 -05:00
bunnei
6fe51f398f
Merge pull request #2945 from FernandoS27/fix-bcat 
nifm: Only return that there's an internet connection when there's a BCATServer
 2020-01-05 02:17:16 -05:00
bunnei
be5c149d37 service: time: Implement GetStandardLocalSystemClock. 2020-01-04 22:18:54 -05:00
bunnei
361285add9 time: Remove overflow error checking (currently breaks ADO builds). 2020-01-04 13:48:31 -05:00
bunnei
a4e840181c service: time: Implement GetClockSnapshotFromSystemClockContext. 2020-01-04 13:48:30 -05:00
bunnei
fab2607c6b service: time: Implement IsStandardNetworkSystemClockAccuracySufficient. 2020-01-04 13:48:30 -05:00
bunnei
4414640285 system_archive: Add a basic HLE implementation for time zone binary. 2020-01-04 13:48:29 -05:00
bunnei
78f977c980 service: time: Rewrite implementation of glue services. 2020-01-04 13:48:29 -05:00
bunnei
5135b74179 core: Initialize several structs that make use of Common::UUID. 2020-01-04 13:29:55 -05:00
bunnei
64c5631579 service: vi: Implement CloseLayer. 
- Needed for Undertale.
 2020-01-04 00:45:06 -05:00
bunnei
624a0f7f3f
Merge pull request #3247 from FernandoS27/remap-fix 
NvServices: Correct Ioctl Remap.
 2020-01-03 12:30:56 -05:00
ReinUsesLisp
0d6d8129c4 yuzu: Remove Maxwell debugger 
This was carried from Citra and wasn't really used on yuzu. It also adds
some runtime overhead. This commit removes it from yuzu's codebase.
 2020-01-02 23:09:44 -03:00
Markus Wick
0986caa8d8 core/memory + arm/dynarmic: Use a global offset within our arm page table. 
This saves us two x64 instructions per load/store instruction.

TODO: Clean up our memory code. We can use this optimization here as well.
 2020-01-01 12:24:54 +01:00
Markus Wick
cb9dd01ffd video_core: Block in WaitFence. 
This function is called rarely and blocks quite often for a long time.
So don't waste power and let the CPU sleep.

This might also increase the performance as the other cores might be allowed to clock higher.
 2019-12-30 13:04:53 +01:00
Fernando Sahmkow
a5bb1ac6e3 NvServices: Correct Ioctl Remap. 
This commit corrects a padding value in Ioctl Remap that was actually an 
offset to the mapping address.
 2019-12-25 14:37:28 -04:00
bunnei
6d0d79109b
Merge pull request #3214 from lioncash/svc-func 
kernel/svc: Amend function signature of SignalProcessWideKey
 2019-12-12 21:32:36 -05:00
Fernando Sahmkow
22c6b9fab2 Kernel: Correct behavior of Address Arbiter threads. (#3165) 
* Kernel: Correct behavior of Address Arbiter threads.

This corrects arbitration threads to behave just like in Horizon OS.
They are added into a container and released according to what priority
they had when added. Horizon OS does not reorder them if their priority
changes.

* Kernel: Address Feedback.
 2019-12-11 10:55:38 -05:00
Lioncash
30e365e4fc kernel/svc: Correct function signature of SignalProcessWideKey 
This function doesn't actually return a result code, so we can amend the
signature of it to match.
 2019-12-11 07:13:27 -05:00
bunnei
34f8881d3e
Merge pull request #3201 from lioncash/dump 
kernel/svc: Provide implementations for svcDumpInfo/svcDumpInfoNew
 2019-12-10 21:48:37 -05:00
Lioncash
c3e43c7e81 kernel: Remove unnecessary includes 
Over the course of the changes to the kernel code, a few includes are no
longer necessary, particularly with the change over to std::shared_ptr
from Boost's intrusive_ptr.
 2019-12-07 22:37:05 -05:00
Lioncash
67b8265bd6 kernel/svc: Provide implementations for svcDumpInfo/svcDumpInfoNew 
These are fairly trivial to implement, we can just do nothing. This also
provides a spot for us to potentially dump out any relevant info in the
future (e.g. for debugging purposes with homebrew, etc).

While we're at it, we can also correct the names of both of these
supervisor calls.
 2019-12-07 22:01:17 -05:00
Fernando Sahmkow
40cd4df584 CpuCore: Clear exclusive state after doing a run in dynarmic. 
This commit corrects an error in which a Core could remain with an
exclusive state after running, leaving space for possible race
conditions between changing cores.
 2019-12-05 18:08:59 -04:00
ReinUsesLisp
be9f80ef56
telemetry_session: Report renderer backend 
We only have OpenGL as an option for now. Hardcode the entry.
 2019-12-02 16:50:39 -03:00
ReinUsesLisp
526e533e90
telemetry_session: Use temporary to avoid writing the same enum 2019-12-02 16:49:46 -03:00
bunnei
c3d3b173d3 kernel: Implement a more accurate IPC dispatch. 2019-11-28 12:01:53 -05:00
bunnei
e3ee017e91
Merge pull request #3169 from lioncash/memory 
core/memory: Deglobalize memory management code
 2019-11-28 11:43:17 -05:00
bunnei
fe65045dcb
Merge pull request #3171 from lioncash/internal-link 
filesys/romfs: Make ProcessFile and ProcessDirectory internally linked
 2019-11-28 01:18:10 -05:00
Morph
e0242a4654 patch_manager: Adds check for disabled cheats to prevent them from being enabled (#3178) 
* Adds check for disabled cheats to prevent them from being added to the CheatList

* Address feedback
 2019-11-28 01:17:17 -05:00
bunnei
c47fc3301d
Merge pull request #3170 from lioncash/enum 
file_sys/directory: Make EntryType an enum class
 2019-11-27 23:23:01 -05:00
Lioncash
d66ab2b8aa filesys/romfs: Remove unused includes 
These inclusions aren't used at all within the public interface, so they
can be removed.
 2019-11-27 05:29:52 -05:00
Lioncash
ba3c55ab7b filesys/romfs: Make ProcessFile and ProcessDirectory internally linked 
These functions aren't used outside of this file, so we can place them
within an anonymous namespace.
 2019-11-27 05:26:35 -05:00
Lioncash
a3149536e2 file_sys/directory: Make EntryType an enum class 
This can trivially be an enum class rather than a regular enum, making
it more strongly typed.
 2019-11-27 05:11:02 -05:00
Lioncash
e7e939104b core/memory; Migrate over SetCurrentPageTable() to the Memory class 
Now that literally every other API function is converted over to the
Memory class, we can just move the file-local page table into the Memory
implementation class, finally getting rid of global state within the
memory code.
 2019-11-26 21:55:39 -05:00
Lioncash
50a518be69 core/memory: Migrate over GetPointerFromVMA() to the Memory class 
Now that everything else is migrated over, this is essentially just code
relocation and conversion of a global accessor to the class member
variable.

All that remains is to migrate over the page table.
 2019-11-26 21:55:39 -05:00
Lioncash
e4c381b885 core/memory: Migrate over Write{8, 16, 32, 64, Block} to the Memory class 
The Write functions are used slightly less than the Read functions,
which make these a bit nicer to move over.

The only adjustments we really need to make here are to Dynarmic's
exclusive monitor instance. We need to keep a reference to the currently
active memory instance to perform exclusive read/write operations.
 2019-11-26 21:55:39 -05:00
Lioncash
b05bfc6036 core/memory: Migrate over Read{8, 16, 32, 64, Block} to the Memory class 
With all of the trivial parts of the memory interface moved over, we can
get right into moving over the bits that are used.

Note that this does require the use of GetInstance from the global
system instance to be used within hle_ipc.cpp and the gdbstub. This is
fine for the time being, as they both already rely on the global system
instance in other functions. These will be removed in a change directed
at both of these respectively.

For now, it's sufficient, as it still accomplishes the goal of
de-globalizing the memory code.
 2019-11-26 21:55:39 -05:00
Lioncash
89ef3ef575 core/memory: Migrate over ZeroBlock() and CopyBlock() to the Memory class 
These currently aren't used anywhere in the codebase, so these are very
trivial to move over to the Memory class.
 2019-11-26 21:55:38 -05:00
Lioncash
849581075a core/memory: Migrate over RasterizerMarkRegionCached() to the Memory class 
This is only used within the accelerated rasterizer in two places, so
this is also a very trivial migration.
 2019-11-26 21:55:38 -05:00
Lioncash
b2165c6b35 core/memory: Migrate over ReadCString() to the Memory class 
This only had one usage spot, so this is fairly straightforward to
convert over.
 2019-11-26 21:55:38 -05:00
Lioncash
3f08e8d8d4 core/memory: Migrate over GetPointer() 
With all of the interfaces ready for migration, it's trivial to migrate
over GetPointer().
 2019-11-26 21:55:38 -05:00
Lioncash
536fc7f0ea core: Prepare various classes for memory read/write migration 
Amends a few interfaces to be able to handle the migration over to the
new Memory class by passing the class by reference as a function
parameter where necessary.

Notably, within the filesystem services, this eliminates two ReadBlock()
calls by using the helper functions of HLERequestContext to do that for
us.
 2019-11-26 21:55:37 -05:00
Lioncash
fc7d0a17b6 core/memory: Move memory read/write implementation functions into an anonymous namespace 
These will eventually be migrated into the main Memory class, but for
now, we put them in an anonymous namespace, so that the other functions
that use them, can be migrated over separately.
 2019-11-26 21:53:35 -05:00
Lioncash
e58748fd80 core/memory: Migrate over address checking functions to the new Memory class 
A fairly straightforward migration. These member functions can just be
mostly moved verbatim with minor changes. We already have the necessary
plumbing in places that they're used.

IsKernelVirtualAddress() can remain a non-member function, since it
doesn't rely on class state in any form.
 2019-11-26 21:53:34 -05:00
Lioncash
323680e5ad core/memory: Migrate over memory mapping functions to the new Memory class 
Migrates all of the direct mapping facilities over to the new memory
class. In the process, this also obsoletes the need for memory_setup.h,
so we can remove it entirely from the project.
 2019-11-26 21:53:34 -05:00
Lioncash
4c2ed2706e core/memory: Introduce skeleton of Memory class 
Currently, the main memory management code is one of the remaining
places where we have global state. The next series of changes will aim
to rectify this.

This change simply introduces the main skeleton of the class that will
contain all the necessary state.
 2019-11-26 21:53:34 -05:00
bunnei
ec0ce96c56
core_timing: Use better reference tracking for EventType. (#3159) 
* core_timing: Use better reference tracking for EventType.

- Moves ownership of the event to the caller, ensuring we don't fire events for destroyed objects.
- Removes need for unique names - we won't be using this for save states anyways.
 2019-11-26 21:48:56 -05:00
bunnei
f6b9b7910e kernel: Fix reference management for client/server session. 
- Fixes shutdown crash and crash in Pokemon SwSh.
 2019-11-25 18:17:49 -05:00
bunnei
50c7539108
Merge pull request #3094 from lioncash/tables 
service: Update function tables
 2019-11-24 20:30:58 -05:00
bunnei
9046d4a548
kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects. (#3154) 
* kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects.

- See https://github.com/citra-emu/citra/pull/4710 for details.
 2019-11-24 20:15:51 -05:00
bunnei
63248f4edd
Update svc.cpp 2019-11-23 16:01:06 -05:00
bunnei
6eaf7ab55f svc: GetSystemTick should return cntpct_el0, not core ticks. 2019-11-23 15:29:15 -05:00
bunnei
6a3fc5d2ff
Merge pull request #3114 from FernandoS27/cond-var 
Kernel: Correct behavior of Condition Variables to be more similar to real hardware.
 2019-11-23 13:24:39 -05:00
bunnei
6e4d46908a
Merge pull request #3130 from FernandoS27/cancel-sync 
Kernel: Correct Cancel Synchronization.
 2019-11-23 13:23:23 -05:00
bunnei
eedb048585
Merge pull request #3112 from lioncash/skip 
service/am: Remove unnecessary Skip calls
 2019-11-21 15:30:01 -05:00
bunnei
d7953b8ee5
Merge pull request #3111 from lioncash/query 
am: Stub QueryApplicationPlayStatistics
 2019-11-21 15:29:34 -05:00
Fernando Sahmkow
46bb609981 Kernel: Optimize condition variable threads management. 2019-11-21 11:13:29 -04:00
Fernando Sahmkow
2ab41ceff4 Kernel: Correct SignalProcessWideKey 
When the target is 0, all threads must be processed.
 2019-11-21 10:46:55 -04:00
Fernando Sahmkow
2d16507f9f Kernel: Correct behavior of Condition Variables to be more similar to real hardware. 
This commit ensures cond var threads act exactly as they do in the real
console. The original implementation uses an RBTree and the behavior of
cond var threads is that at the same priority level they act like a
FIFO.
 2019-11-21 10:46:55 -04:00
Fernando Sahmkow
7d16b2d2dd Kernel: Correct Cancel Synchronization. 
This commit corrects the behavior of cancel synchronization when the
thread is running/ready and ensures the next wait is cancelled as it's
suppose to.
 2019-11-16 12:41:51 -04:00
bunnei
3e0e4f146b
Merge pull request #3091 from lioncash/core-conversion 
core: Make most implicit type conversion warnings errors on MSVC
 2019-11-15 12:08:50 -05:00
Lioncash
2c4c2b5eee service/am: Remove unnecessary Skip calls 
We can simplify these by wrapping the necessary members in structs and
then simply reading out the whole struct.
 2019-11-14 16:31:52 -05:00
Lioncash
1cd8637bf0 am: Stub QueryApplicationPlayStatistics 
Maintains implementation parity between QueryApplicationPlayStatistics
and QueryApplicationPlayStatisticsByUid.

These function the same behaviorally underneath the hood, with the only
difference being that one allows specifying a UID.
 2019-11-14 16:02:39 -05:00
bunnei
885d88825e
Merge pull request #3089 from SciresM/play_statistics 
Implement stub for IApplicationFunctions::QueryApplicationPlayStatisticsByUid
 2019-11-14 13:54:29 -05:00
bunnei
360b0d1b30
Merge pull request #3093 from lioncash/mbedtls 
core: Migrate off deprecated mbedtls functions
 2019-11-14 13:47:23 -05:00
bunnei
02880a8195
Merge pull request #3092 from lioncash/util 
key_manager: Make use of IOFile in WriteKeyToFile()
 2019-11-14 13:46:55 -05:00
Lioncash
03b73aa575 xts_archive: Remove redundant std::string constructor 
We can just call the .data() member of path instead of constructing a
completely new string.
 2019-11-13 10:02:10 -05:00
Lioncash
e21b6ff79d service: Update function tables 
Keeps the function tables up to date.

Updated based off information from Switchbrew.
 2019-11-12 10:32:56 -05:00
Lioncash
64cbebc58f key_manager: Make use of IOFile in WriteKeyToFile() 
This properly handles unicode-based paths on Windows, while opening a
raw stream doesn't out-of-the-box.

Prevents file creation from potentially failing on Windows PCs that make
use of unicode characters in their save paths (e.g. writing to a user's
AppData folder, where the user has a name with non-ASCII characters).
 2019-11-12 08:52:18 -05:00
Lioncash
e0c46e6879 core: Migrate off deprecated mbedtls functions 
These functions are marked for deprecation and it's recommended that the
*_ret variants be used instead.
 2019-11-12 08:45:56 -05:00
Lioncash
47a6bb2d5b externals: Update httplib 
Since the introduction of this library, numerous improvements have been
made. Notably, many of the warnings we would get by simply including the
library header have now been fixed. This makes it much easier to make
conversion warning an error.
 2019-11-12 08:31:27 -05:00
Lioncash
f11b87ebf1 service: Resolve sign conversion errors 
These are fairly trivial to resolve and most of the changes entail
using RESULT_UNKNOWN over ResultCode(-1).
 2019-11-12 07:55:39 -05:00
Lioncash
75dec14f21 perf_stats: Resolve implicit int to double conversion error 
We simply need to turn the literal argument to std::accumulate into a
double, rather than an int.
 2019-11-12 07:55:39 -05:00
Lioncash
23878bf360 loader; Resolve sign conversion/truncation errors 2019-11-12 07:55:39 -05:00
Lioncash
86a1eb7789 gdbstub: Resolve sign conversion errors 2019-11-12 07:55:39 -05:00
Lioncash
12dc918937 kernel: Resolve sign conversion warnings 
Uncovered a bug within Thread's SetCoreAndAffinityMask() where an
unsigned variable (ideal_core) was being compared against "< 0", which
would always be a false condition.

We can also get rid of an unused function (GetNextProcessorId) which contained a sign
mismatch warning.
 2019-11-12 07:55:39 -05:00
Lioncash
86c397dd6e file_sys: Resolve sign conversion warnings 
Resolves a few trivial sign conversion/mismatch errors.
 2019-11-12 07:55:39 -05:00
Lioncash
ef060ed40c result: Add default error code for the ResultCode(-1) case 
Will be used to reduce the overall duplication of the same magic value
all over the codebase in following changes.
 2019-11-12 07:55:38 -05:00
Lioncash
581d2e36e5 crypto: Resolve sign-conversion warnings 2019-11-12 07:55:22 -05:00
Lioncash
27ab99490e result: Resolve sign-coversion warnings 
The constructor was implicitly using signed->unsigned conversions to
produce 0xFFFFFFFF. We can just specify this explicitly with UINT32_MAX.
 2019-11-12 07:06:48 -05:00
Lioncash
19a0abc19b arm_unicorn: Resolve sign conversion warnings 
While we're at it, this also resolves a type truncation warning as well,
given the code was truncating from a 64-bit value to a 32-bit one.
 2019-11-12 07:06:48 -05:00
Lioncash
96d677bef0 CMakeLists: Make most implicit type conversion warnings errors on MSVC 
Quite frequently there have been cases where code has been merged into
the core that produces warning. In order to prevent this from occurring,
we can make the compiler flag these cases and allow our CI to flag down
any code that would generate these warnings.

This is beneficial given silent conversions from signed/unsigned can
result in logic bugs. This forces one writing changes to be explicit
about when signedness conversions are desirable, rather than leaving it
up to readers' interpretation.

Currently the codebase isn't in a state where it will build successfully
with this change applied, but this will be addressed in subsequent
follow-up changes. This set of changes will focus on making it build
properly with these changes for MSVC as a starting point for basic
coverage.
 2019-11-12 07:06:25 -05:00
Michael Scire
b0b0786493 Implement stub for QueryApplicationPlayStatisticsByUid 2019-11-11 07:32:47 -08:00
Fernando Sahmkow
3c95e49c42 nifm: Only return that there's an internet connection when there's a BCATServer 
This helps games that need internet for other purposes boot as the rest
of our internet infrastructure is incomplete.
 2019-11-06 23:10:32 -05:00
bunnei
c1a3d19897
Merge pull request #3062 from bunnei/event-improve 
kernel: Improve events
 2019-11-06 10:05:50 -05:00
David
0e34f648f4
Merge pull request #2859 from Morph1984/hid 
hid: Stub SetNpadJoyAssignmentModeSingle and GetNpadHandheldActivationMode
 2019-11-06 12:48:07 +11:00
bunnei
1bdae0fe29 common_func: Use std::array for INSERT_PADDING_* macros. 
- Zero initialization here is useful for determinism.
 2019-11-03 22:22:41 -05:00
bunnei
ece5287843 kernel: readable_event: Signal only once. 2019-11-03 04:25:41 -05:00
bunnei
b0ab803ce8 kernel: events: Remove ResetType::Automatic. 
- This does not actually seem to exist in the real kernel - games reset these automatically.

# Conflicts:
#	src/core/hle/service/am/applets/applets.cpp
#	src/core/hle/service/filesystem/fsp_srv.cpp
 2019-11-03 04:22:45 -05:00
bunnei
28bb248db6 kernel: readable_event: Initialize members. 2019-11-03 04:18:39 -05:00
FearlessTobi
832c138eff core/am: Stub InitializeApplicationCopyrightFrameBuffer, SetApplicationCopyrightImage and SetApplicationCopyrightVisibility 
These commands require Screenshots to be implemented anyway, so they are safe to stub for now.
 2019-11-03 07:37:38 +01:00
Rodrigo Locatti
04b838c857
Merge pull request #3038 from lioncash/docs 
kernel/scheduler: Minor changes
 2019-10-30 03:47:28 +00:00
bunnei
a81bd962ab
Merge pull request #3007 from DarkLordZach/fsc-regress 
savedata_factory: Automatically create certain savedata
 2019-10-29 22:05:09 -04:00
Lioncash
6c8f28813c scheduler: Mark parameter of AskForReselectionOrMarkRedundant() as const 
This is only compared against, so it can be made const.
 2019-10-27 23:35:50 -04:00
Lioncash
f19c1a7cda scheduler: Silence sign conversion warnings 2019-10-27 22:44:52 -04:00
Lioncash
2fb0bbff29 scheduler: Initialize class members directly where applicable 
Reduces the overall amount of code.
 2019-10-27 22:13:55 -04:00
Lioncash
2dc469ceba scheduler: Amend documentation comments 
Adjusts the formatting of a few of the comments an ensures they get
recognized as proper Doxygen comments.
 2019-10-27 22:12:32 -04:00
David
4c5731c34f
Merge pull request #2971 from FernandoS27/new-scheduler-v2 
Kernel: Implement a New Thread Scheduler V2
 2019-10-28 10:53:27 +11:00
bunnei
6fe89acf0d
Merge pull request #2991 from lioncash/npad 
hid/npad: Minor cleanup
 2019-10-22 19:51:24 -04:00
Zach Hilman
bb207fe27a savedata_factory: Automatically create certain savedata 
After further hardware investigation, it appears that some games, perhaps those more lazily coded, will not call EnsureSaveData, meaning that they expect the normal (current) save to be automatically made. Additionally, some games do not create a cache or temporary save before use.
In these 3 specific instances, the save is created automatically for the game if it doesn't exist.
 2019-10-22 15:47:38 -04:00
bunnei
a86a88109a core: Fix clang-format errors. 2019-10-19 14:47:18 -04:00
Nicolae-Andrei Cociorba
20521da259 Fix null pointer deref. 2019-10-18 14:12:12 +00:00
bunnei
d1713ad451
Merge pull request #2992 from lioncash/dmnt 
dmnt_cheat_vm: Correct register Restore and ClearRegs behavior
 2019-10-17 19:52:24 -04:00
Lioncash
2c34d8aabb dmnt_cheat_vm: Correct register Restore and ClearRegs behavior 
Previously these were performing the same behavior as the Save and
ClearSaved opcode types.
 2019-10-17 18:49:39 -04:00
Rodrigo Locatti
7cf091bb20
Merge pull request #2989 from lioncash/apm 
service/apm/controller: Minor interface changes
 2019-10-17 19:20:14 -03:00
Lioncash
8d8e495248 hid/npad: Fix incorrect connection boolean value in ConnectAllDisconnectedControllers() 
We should be setting the connection state to true, otherwise we aren't
actually making the controllers connected like the function name
indicates.
 2019-10-17 18:19:47 -04:00
Lioncash
d076466f26 hid/npad: Add missing break in default case 
While not an issue, it does prevent fallthrough from occurring if
anything is ever added after this case (unlikely to occur, but this
turns a trivial "should not cause issues" into a definite "won't cause
issues).
 2019-10-17 18:17:42 -04:00
Lioncash
26c84718c8 hid/npad: Replace std::for_each with ranged for loops 
Performs the same behavior, but is built into the core language itself.

No functional change.
 2019-10-17 18:16:36 -04:00
Lioncash
e433e99191 hid/npad: Remove redundant non-const variant of IsControllerSupported() 
The const qualified variant can also be called in non-const contexts, so
we can remove the non-const variant to eliminate a bit of code
duplication.
 2019-10-17 18:11:41 -04:00
Lioncash
a71e8066a1 hid/npad: Move function declarations 
Clearly separate these from the variable declarations to make them more
visible.
 2019-10-17 18:09:08 -04:00
Lioncash
98c6a95079 core/core: Resolve -Wreorder warnings 
Amends the initializer lists to be ordered in the same manner that
they're declared within the class.
 2019-10-17 17:51:06 -04:00
Lioncash
6414d9e2e5 core/memory/cheat_engine: Resolve -Wreorder warnings 
Amends the initializer lists to be ordered in the same manner that
they're declared within the class.
 2019-10-17 16:21:47 -04:00
Lioncash
b77430df70 apm/controller: Make SetPerformanceConfiguration() use an array of pairs over a map 
While a map is an OK way to do lookups (and usually recommended in most
cases), this is a map that lives for the entire duration of the program
and only deallocates its contents when the program terminates.

Given the total size of the map is quite small, we can simply use a
std::array of pairs and utilize std::find_if to perform the same
behavior without loss of performance.

This eliminates a static constructor and places the data into the
read-only segment.

While we're at it, we can also handle malformed inputs instead of
directly dereferencing the resulting iterator.
 2019-10-17 16:13:14 -04:00
Lioncash
141d929929 apm/controller: Make GetCurrentPerformanceMode() a const member function 
This doesn't modify instance state, so it can be made const qualified.
 2019-10-17 15:58:25 -04:00
bunnei
ef9b31783d
Merge pull request #2912 from FernandoS27/async-fixes 
General fixes to Async GPU
 2019-10-16 10:34:48 -04:00
bunnei
2299950de1
Merge pull request #2972 from lioncash/system 
{bcat, gpu, nvflinger}: Remove trivial usages of the global system accessor
 2019-10-15 17:49:12 -04:00
Lioncash
cc1d7048b5 bcat: Remove use of global system accessors 
Removes all uses of the global system accessor within the BCAT
interface.
 2019-10-15 16:39:27 -04:00
Fernando Sahmkow
64e652d8cb Kernel Thread: Cleanup THREADPROCESSORID_DONT_UPDATE. 2019-10-15 11:55:30 -04:00
Fernando Sahmkow
e28c7f5217 Kernel: Address Feedback 2 2019-10-15 11:55:28 -04:00
Fernando Sahmkow
a3524879be Kernel: Clang Format 2019-10-15 11:55:27 -04:00
Fernando Sahmkow
c32520ceb7 Kernel: Reverse global accessor removal. 2019-10-15 11:55:26 -04:00
Fernando Sahmkow
3073615dbc Kernel: Address Feedback. 2019-10-15 11:55:25 -04:00
Fernando Sahmkow
25f8606a6d Kernel Scheduler: Make sure the global scheduler shutdowns correctly. 2019-10-15 11:55:24 -04:00
Fernando Sahmkow
b3c1deba49 Kernel_Thread: Eliminate most global accessors. 2019-10-15 11:55:23 -04:00
Fernando Sahmkow
0b72b34d89 KernelSVC: Assert that condition variable address is aligned to 4 bytes. 2019-10-15 11:55:22 -04:00
Fernando Sahmkow
96b1b144af Kernel: Correct Paused scheduling 2019-10-15 11:55:21 -04:00
Fernando Sahmkow
1c6a11ab14 Kernel: Corrections to Wait Objects clearing in which a thread could still be signalled after a timeout or a cancel. 2019-10-15 11:55:20 -04:00
Fernando Sahmkow
27d571c084 Kernel: Correct redundant yields to only advance time forward. 2019-10-15 11:55:20 -04:00
Fernando Sahmkow
7176857177 Kernel: Corrections to ModifyByWaitingCountAndSignalToAddressIfEqual 2019-10-15 11:55:19 -04:00
Fernando Sahmkow
44e09e5f21 Kernel: Correct Results in Condition Variables and Mutexes 2019-10-15 11:55:18 -04:00
Fernando Sahmkow
1ec1e81373 Kernel: Clang Format 2019-10-15 11:55:17 -04:00
Fernando Sahmkow
e05a8c2385 Kernel: Remove global system accessor from WaitObject 2019-10-15 11:55:16 -04:00
Fernando Sahmkow
0cf26cee59 Scheduler: Implement Yield Count and Core migration on Thread Preemption. 2019-10-15 11:55:16 -04:00
Fernando Sahmkow
2d382de6fa Scheduler: Corrections to YieldAndBalanceLoad and Yield bombing protection. 2019-10-15 11:55:15 -04:00
Fernando Sahmkow
b49c0dab87 Kernel: Initial implementation of thread preemption. 2019-10-15 11:55:14 -04:00
Fernando Sahmkow
103f3a2fe5 Scheduler: Add protections for Yield bombing 
In case of redundant yields, the scheduler will now idle the core for 
it's timeslice, in order to avoid continuously yielding the same thing 
over and over.
 2019-10-15 11:55:13 -04:00
Fernando Sahmkow
82218c925a Kernel: Style and Corrections 2019-10-15 11:55:12 -04:00
Fernando Sahmkow
fcc6b34fff Correct PrepareReschedule 2019-10-15 11:55:12 -04:00
Fernando Sahmkow
3a94e7ea33 Comment and reorganize the scheduler 2019-10-15 11:55:11 -04:00
Fernando Sahmkow
b5d1e44782 Add PrepareReschedule where required. 2019-10-15 11:55:10 -04:00
Fernando Sahmkow
b8b7ebcece Correct compiling errors and addapt to the new interface. 2019-10-15 11:55:09 -04:00
Fernando Sahmkow
9031502974 Correct Supervisor Calls to work with the new scheduler, 2019-10-15 11:55:08 -04:00
Fernando Sahmkow
47c6c78c03 Redesign CPU Cores to work with the new scheduler 2019-10-15 11:55:07 -04:00
Fernando Sahmkow
57a71f899a Add interfacing to the Global Scheduler 2019-10-15 11:55:07 -04:00
Fernando Sahmkow
a1ac0c6cb4 Addapt thread class to the new Scheduler 2019-10-15 11:55:06 -04:00
Fernando Sahmkow
b164d8ee53 Implement a new Core Scheduler 2019-10-15 11:55:04 -04:00
bunnei
cab2619aeb
Merge pull request #2965 from FernandoS27/fair-core-timing 
Core Timing: Rework Core Timing to run all cores evenly.
 2019-10-15 11:48:30 -04:00
bunnei
0378babd15
Merge pull request #2897 from DarkLordZach/oss-ext-fonts-1 
pl_u: Move open source font archives and fix NAND error
 2019-10-14 15:13:41 -04:00
bunnei
cd2efed922
Merge pull request #2930 from DarkLordZach/gamecard-partitions 
file_sys: Add code to access raw gamecard partitions and lazily load them
 2019-10-14 10:29:10 -04:00
Zach Hilman
e0b9ee9b94 card_image: Implement system update commands in XCI 2019-10-13 14:18:45 -04:00
Zach Hilman
1911f85391 pl_u: Fix mismatched rebase size error in font encryption 2019-10-13 13:46:27 -04:00
Zach Hilman
36d829c27b pl_u: Use kernel physical memory 2019-10-13 13:46:27 -04:00
Zach Hilman
b3a8a094a5 pl_u: Remove excess static qualifier 2019-10-13 13:46:27 -04:00
Zach Hilman
40284c6868 pl_u: Use OSS system archives if real archives don't exist 2019-10-13 13:46:27 -04:00
Zach Hilman
920742d418 system_archive: Synthesize shared fonts system archives 2019-10-13 13:46:10 -04:00
Zach Hilman
d6d6a87bde externals: Move OSS font data to file_sys in core 2019-10-13 13:46:10 -04:00
Lioncash
574440d59f nvflinger/buffer_queue: Remove use of a global system accessor 2019-10-12 09:17:56 -04:00
Fernando Sahmkow
a4ae11d63e Core_Timing: Address Remaining feedback. 2019-10-12 07:26:38 -04:00
Fernando Sahmkow
e0650a2034 Core_Timing: Address Feedback and suppress warnings. 2019-10-11 14:44:14 -04:00
Fernando Sahmkow
96f2b16356 Core Timing: Correct Idle and remove lefting pragma 2019-10-09 12:30:33 -04:00
Fernando Sahmkow
65aff6930b Core Timing: General corrections and added tests. 2019-10-09 12:30:33 -04:00
Fernando Sahmkow
555866f8dc Core Timing: Rework Core Timing to run all cores evenly. 2019-10-09 12:30:31 -04:00
bunnei
e664c24355
Merge pull request #2921 from FreddyFunk/compiler-warnings-core 
Services::ES fix casting warnings
 2019-10-09 10:34:48 -04:00
bunnei
b9c831de62
Merge pull request #2654 from DarkLordZach/lm-log-rewrite 
lm: Rewrite logger to use core reporting services
 2019-10-08 20:23:13 -04:00
Morph
29e15601f3 hid: Implement DeactivateNpad 
Makes use of the already existing DeactivateController function.
 2019-10-07 04:44:09 -07:00
Morph
c1e9ca4c08 hid: Stub SetNpadJoyAssignmentModeSingle and reorganize service commands 2019-10-07 04:43:34 -07:00
Zach Hilman
5326d3cb3a
Merge pull request #2951 from lioncash/global 
core: Remove Core::CurrentProcess()
 2019-10-06 20:47:48 -04:00
Lioncash
0705ce0ed1 bcat/module: Silence truncation warnings 
We need to perform explicit casts here, otherwise we're implicitly
truncating a 64-bit type to a 32-bit one.
 2019-10-06 15:38:12 -04:00
Lioncash
7e77d1593f bcat: Take std::function instance by value in NullBackend's constructor 
Without this, the std::move within the constructor initializer list
won't be able to actually perform a move.
 2019-10-06 15:38:12 -04:00
Lioncash
81adf46d1d bcat: In-class initialize ProgressServiceBackend's impl member 
Allows us to remove a constructor initializer list.
 2019-10-06 15:38:12 -04:00
Lioncash
3fcd2180e4 bcat: Make ProgressServiceBackend's constructor take a std::string_view 
Given the string is appended to another, we can make it a view so a
redundant full copy of the string isn't made.
 2019-10-06 15:38:09 -04:00
Lioncash
f2fa16b609 bcat: Make ProgressServiceBackend's GetEvent() const 
This member function doesn't modify internal member state, so it can be
marked const.
 2019-10-06 14:03:18 -04:00
Lioncash
329081fcb7 boxcat: Silence an unused variable warning 
On parse errors, we can log out the explanatory string indicating what
the parsing error was, rather than just ignoring the variable and
returning an overly broad error code.
 2019-10-06 14:00:32 -04:00
Lioncash
839b38c404 core/core: Remove unused header 
This isn't used anywhere in either the cpp or header file.
 2019-10-06 13:54:27 -04:00
Lioncash
f1382cf0e7 core: Remove Core::CurrentProcess() 
This only encourages the use of the global system instance (which will
be phased out long-term). Instead, we use the direct system function
call directly to remove the appealing but discouraged short-hand.
 2019-10-06 13:53:12 -04:00
Lioncash
69f16ba50e hle/service: Replace global system instance calls with instance-based ones 
Migrates the HLE service code off the use of directly accessing the
global system instance where trivially able to do so.

This removes all usages of Core::CurrentProcess from the service code,
only 8 occurrences of this function exist elsewhere. There's still quite
a bit of "System::GetInstance()" being used, however this was able to
replace a few instances.
 2019-10-06 13:42:23 -04:00
Fernando Sahmkow
75395605d6 NvFlinger: Remove leftover from corrections and clang format. 2019-10-04 19:59:54 -04:00
Fernando Sahmkow
3f104464de Core: Wait for GPU to be idle before shutting down. 2019-10-04 19:59:53 -04:00
Fernando Sahmkow
69fa2e6525 Nvdrv: Correct Event setup in Nvdrv 
Events are supposed to be cleared on quering. This fixes that issue.
 2019-10-04 19:59:52 -04:00
Fernando Sahmkow
782b7a0ca4 NVFlinger: Reverse the change that only signaled events on buffer acquire. 
This has been hardware tested and it seems that NVFlinger will still 
signal even if there are no buffers to present.
 2019-10-04 19:59:51 -04:00
Fernando Sahmkow
ffc2ce89a0 Nvdrv: Do framelimiting only in the CPU Thread 2019-10-04 19:59:50 -04:00
Fernando Sahmkow
976d9ef43c NvFlinger: Don't swap buffers if a frame is missing and always trigger event in sync gpu. 2019-10-04 19:59:49 -04:00
Fernando Sahmkow
5b5e60ffec GPU_Async: Correct fences, display events and more. 
This commit uses guest fences on vSync event instead of an articial fake 
fence we had.
It also corrects to keep signaling display events while loading the game 
as the OS is suppose to send buffers to vSync during that time.
 2019-10-04 19:59:48 -04:00
Fernando Sahmkow
4e9f975935 Nvdrv: Correct Async regression and avoid signaling empty buffer vsyncs 2019-10-04 19:59:47 -04:00
ReinUsesLisp
25ee892d5e audio/audout_u: Change formatting for old clang-format versions 2019-10-04 23:51:56 +00:00
ReinUsesLisp
8d0b1a957e service/nvdrv: Silence -Wswitch 2019-10-04 23:41:22 +00:00
ReinUsesLisp
5c907f85fc service/nfp: Silence -Wunused and -Wswitch 2019-10-04 23:41:22 +00:00
ReinUsesLisp
0759df0aff service/hid: Silence -Wunused and -Wswitch 2019-10-04 23:41:22 +00:00
ReinUsesLisp
ab6f8d8a1e service/am: Silence -Wreorder 2019-10-04 23:41:21 +00:00
ReinUsesLisp
634c6e24b0 service/hid: Remove unused system reference 2019-10-04 23:41:21 +00:00
ReinUsesLisp
1dbd22e695 service/friend: Remove unused field 2019-10-04 23:41:21 +00:00
ReinUsesLisp
99db7d23dd service/filesystem: Silence -Wunused-variable 2019-10-04 23:41:21 +00:00
ReinUsesLisp
8566096794 service/bcat: Silence -Wreorder and -Wunused 2019-10-04 23:41:21 +00:00
ReinUsesLisp
87e7cc2d5a service/audio: Silence -Wunused 2019-10-04 23:28:34 +00:00
ReinUsesLisp
aacb473aa2 service/apm: Silence -Wunused and -Wreorder 2019-10-04 23:28:34 +00:00
bunnei
7fbaf62bac
Merge pull request #2936 from VPeruS/use-isallzeroarray 
[crypto] Use IsAllZeroArray helper function
 2019-10-04 15:44:35 -04:00
David
9aac7fbc22
Merge pull request #2539 from DarkLordZach/bcat 
bcat: Implement BCAT service and connect to yuzu Boxcat server
 2019-10-03 19:06:13 +10:00
vperus
29b1d0db0f [crypto] Use IsAllZeroArray helper function 2019-10-02 19:20:45 +03:00
Zach Hilman
e55d086cc9 qt: Add service dialog 2019-10-02 08:35:43 -04:00
Zach Hilman
5d86c52a3a boxcat: Use updated game-asset API URL and tags 2019-10-01 09:13:31 -04:00
Zach Hilman
19c466dfb1 bcat: Add FSC accessors for BCAT data 
Ports BCAT to use FSC interface
 2019-10-01 09:13:09 -04:00
Zach Hilman
bcf1eafb8b boxcat: Implement events global field 2019-09-30 17:28:23 -04:00
Zach Hilman
2d410ddf4d bcat: Implement DeliveryCacheProgressImpl structure 
Huge thanks to lioncash for re-ing this for me.
 2019-09-30 17:27:23 -04:00
Zach Hilman
92b70a3bf9 boxcat: Use Etag header names for file digest 2019-09-30 17:27:23 -04:00
Zach Hilman
e8183f9ef0 boxcat: Add downloading and client for launch parameter data 2019-09-30 17:27:23 -04:00
Zach Hilman
b8ce87103d bcat: Add backend function for BCAT Indirect (launch parameter) 
Returns the data that should be returned by PopLaunchParameter kind=ApplicationSpecific.
 2019-09-30 17:27:23 -04:00
Zach Hilman
ea17b294ea bcat: Expose CreateBackendFromSettings helper function 2019-09-30 17:27:23 -04:00
Zach Hilman
fe8c7e66e2 am: Unstub PopLaunchParameter and add bcat connection for app-specific data 
Previously we were simply returning the account-preselect structure all times but if passed with a different mode the game expects application-specific data. This also adds a hook for BCAT into this allowing us to send the launch parameter through bcat,
 2019-09-30 17:27:23 -04:00
Zach Hilman
102db206e0 bcat: Implement cmd 90201 ClearDeliveryCacheStorage 
Takes a title ID and simply deletes all the data for that title ID's bcat. Invokes the respective backend command.
 2019-09-30 17:23:26 -04:00
Zach Hilman
1bde5a3c6a bcat: Implement cmd 30100 SetPassphrase 
Takes a title ID and passphrase (0x40 byte string) and passes it to the backend.
 2019-09-30 17:23:26 -04:00
Zach Hilman
86773a7f08 bcat: Implement cmd RequestSyncDeliveryCache and variant 
Variant also supports only updating a single directory. These just both invoke backend commands.
 2019-09-30 17:23:26 -04:00
Zach Hilman
cb7c96b96a bcat: Implement IDeliveryCacheProgressService commands 
Used to query completion status and events for the current delivery task.
 2019-09-30 17:23:26 -04:00
Zach Hilman
f352ad5c93 bcat: Implement IDeliveryCacheFileService commands 
Used to read the contents of files and access their metadata.
 2019-09-30 17:23:26 -04:00
Zach Hilman
8812018c1d bcat: Implement IDeliveryCacheDirectoryService commands 
Used to list and get directories at the root level.
 2019-09-30 17:23:26 -04:00
Zach Hilman
862131ead9 bcat: Implement IDeliveryCacheStorageService commands 
Used to create subclasses to manage files and directories and to list directories.
 2019-09-30 17:23:26 -04:00
Zach Hilman
78d146f907 bcat: Add commands to create IDeliveryCacheStorageService 
Used to access contents of download.
 2019-09-30 17:23:26 -04:00
Zach Hilman
68658a8385 module: Create BCAT backend based upon Settings value on construction 2019-09-30 17:23:26 -04:00
Zach Hilman
2903f3524e bcat: Add BCAT backend for Boxcat service 
Downloads content from yuzu servers and unpacks it into the temporary directory provided. Fully supports all Backend features except passphrase.
 2019-09-30 17:21:53 -04:00
Zach Hilman
2c0b75a744 bcat: Add backend class to generify the functions of BCAT 
Provides the most abstract simplified functions of BCAT as functions. Also includes a NullBackend class which is just a no-op.
 2019-09-30 17:21:53 -04:00
Zach Hilman
647992e666 settings: Add option to set BCAT backend 2019-09-30 17:21:53 -04:00
Zach Hilman
532ec459b8 nifm: Signal to applications that internet access is available 2019-09-30 17:21:53 -04:00
Zach Hilman
f6c53526b3 core/loader: Track the NSO build ID of the current process 2019-09-30 17:21:53 -04:00
Zach Hilman
943662dc3c applets: Add accessor for AppletFrontendSet 
Allows other services to call applets without using LLE.
 2019-09-30 17:20:49 -04:00
Zach Hilman
f2073217a4 filesystem: Add getter for BCAT temporary directory 2019-09-30 17:20:49 -04:00
Zach Hilman
c00ed8f4ff vfs: Add function to extract ZIP file into virtual filesystem 2019-09-30 17:18:38 -04:00
bunnei
dc29919bbe
Revert "arm_dynarmic: Check if jit is nullptr when preparing reschedule" 2019-09-29 21:54:19 -04:00
bunnei
28538bba9c
Merge pull request #2574 from DarkLordZach/dynarmic-jit-nullptr 
arm_dynarmic: Check if jit is nullptr when preparing reschedule
 2019-09-29 21:44:10 -04:00
FreddyFunk
7b93c4646a Services::ES fix casting warnings 2019-09-29 22:45:09 +02:00
David Marcec
77fbf29047 Signal styleset changes at a better time 
We should signal when a net controller is added and our event should be manual, not automatic.
 2019-09-24 17:24:37 +10:00
Zach Hilman
c4f3400bea card_image: Add accessors for raw partitions in XCI 2019-09-22 21:51:46 -04:00
Zach Hilman
3952c73aee card_image: Lazily load partitions in XCI 2019-09-22 21:50:29 -04:00
Zach Hilman
3895f7e456 pfs: Provide accessors for file sizes and offsets 2019-09-22 21:44:36 -04:00
Zach Hilman
6212df3beb lm: Flush manager output on core shutdown 2019-09-22 12:34:55 -04:00
Zach Hilman
fa6531ab0f lm: Rename Initialize to Log and implement with manager/reporter 
Allows saving and clearer output of data.
 2019-09-22 12:34:55 -04:00
Zach Hilman
ef9a7fa1f5 lm: Implement manager class to output to reporter 2019-09-22 12:34:55 -04:00
Zach Hilman
4153bd8d17 core: Add LM::Manager to system 
Allows centralized control over logging mechanisms.
 2019-09-22 12:34:55 -04:00
Zach Hilman
82bf055eca reporter: Add log output for packaged lm log data 
Takes the vector from head to tail of log data and saves it.
 2019-09-22 12:34:33 -04:00
David
aaec1562f8
Merge pull request #2683 from DarkLordZach/lock-exit 
am: Implement exit locking and self exit commands
 2019-09-23 00:37:12 +10:00
Zach Hilman
b835d76311
Merge pull request #2876 from ogniK5377/AcquireNpadStyleSetUpdateEventHandle-fix 
AcquireNpadStyleSetUpdateEventHandle should have a separate event for each controller type
 2019-09-22 10:06:48 -04:00
David
e31c15606b
Merge pull request #2895 from FearlessTobi/debug-logs 
service/acc: Lower log severity from INFO to DEBUG
 2019-09-22 23:50:49 +10:00
Fernando Sahmkow
a755f24369
Merge pull request #2873 from ogniK5377/new-ioctls 
Initial implementation of Ioctl2 & Ioctl3
 2019-09-22 09:45:29 -04:00
David Marcec
59fd910355 removed comment 2019-09-22 23:42:52 +10:00
David Marcec
654427d4d0 Rebased 2019-09-22 23:42:41 +10:00
Fernando Sahmkow
4ace69de9c
Merge pull request #2884 from ogniK5377/deglobal-sys-services 
Remove usage of System::CurrentInterface() from most services
 2019-09-22 09:38:13 -04:00
FearlessTobi
82979296d2 service/acc: Lower log severity from INFO to DEBUG 
According to ogniK, this should have always been Debug and not Info.
 2019-09-22 15:15:07 +02:00
David Marcec
9513abbb0a removed unneeded semicolon 2019-09-22 18:50:34 +10:00
David Marcec
d961d5479e Revert "Merge pull request #2709 from DarkLordZach/oss-ext-fonts-1" 
This reverts commit fa1c60c33e, reversing
changes made to e34899067b.
 2019-09-22 17:47:25 +10:00
David Marcec
e73ac40eaa Removed reference to core timing to nvflinger and used system instead 2019-09-22 16:55:15 +10:00
David Marcec
aed884d121 marked controller constructors as explicit 2019-09-22 16:41:38 +10:00
David Marcec
bd1c4ec9a0 Rebase 2019-09-22 16:41:34 +10:00
David Marcec
fcdbf0bc53 Rebase 2019-09-22 16:40:58 +10:00
David Marcec
4d220964df Deglobalize System: Vi 2019-09-22 16:38:03 +10:00
David Marcec
2c6e4ce0ad Deglobalize System: Time 2019-09-22 16:38:02 +10:00
David Marcec
36a97dd8a2 Rebase 2019-09-22 16:37:59 +10:00
David Marcec
d6e830d877 Deglobalize System: NvFlinger 2019-09-22 16:35:51 +10:00
David Marcec
f21ab654db Rebase 2019-09-22 16:35:43 +10:00
David Marcec
8d3ff2b127 Deglobalize System: Nim 2019-09-22 16:30:34 +10:00
David Marcec
ad53dc0106 Deglobalize System: Nifm 2019-09-22 16:30:33 +10:00
David Marcec
8df2a98f75 Deglobalize System: NFP 2019-09-22 16:30:32 +10:00
David Marcec
482a03f8a5 Deglobalize System: LDR 2019-09-22 16:30:31 +10:00
David Marcec
07823b61a1 Deglobalize System: IRS 2019-09-22 16:30:30 +10:00
David Marcec
28181919a6 Deglobalize System: Hid 2019-09-22 16:30:29 +10:00
David Marcec
a9e9570d84 Deglobalize System: Friend 2019-09-22 16:30:27 +10:00
David Marcec
a40e5b2def Deglobalize System: Fatal 2019-09-22 16:30:25 +10:00
David Marcec
c33faabb27 Deglobalize System: Btm 2019-09-22 16:30:24 +10:00
David Marcec
f2b61ff073 Deglobalize System: Btdrv 2019-09-22 16:30:20 +10:00
David Marcec
7da8e3f812 Deglobalize System: Aoc 2019-09-22 16:30:17 +10:00
David Marcec
2dbfac652e Deglobalize System: Am 2019-09-22 16:30:14 +10:00
David
9187350b32
Merge pull request #2535 from DarkLordZach/cheat-v2 
cheat_engine: Use Atmosphere's Cheat VM and fix cheat crash
 2019-09-22 16:24:42 +10:00
David
fa1c60c33e
Merge pull request #2709 from DarkLordZach/oss-ext-fonts-1 
system_archive: Move shared font data to system_archive and fix extended font data
 2019-09-22 16:09:22 +10:00
Zach Hilman
2a4730cbee pl_u: Use kernel physical memory 2019-09-21 23:00:22 -04:00
Zach Hilman
60c2e9e675 qt: Prompt user for confirmation if exit lock is active 2019-09-21 22:46:57 -04:00
Zach Hilman
2bddc03468 dmnt_cheat_vm: Default initialize structure values 2019-09-21 22:43:49 -04:00
David Marcec
6325c3044c server side clang format fix2 2019-09-22 12:26:03 +10:00
Zach Hilman
e58e3719d8 am: Implement ISelfController ExitLock commands 2019-09-21 22:25:18 -04:00
Zach Hilman
a7fda84902 am: Implement ISelfController Exit 
Closes the current application.
 2019-09-21 22:25:18 -04:00
Zach Hilman
4c1c8801a5 am: Add RequestExit event to AppletMessageQueue 
Tested against libnx, signals to games to begin cleanup.
 2019-09-21 22:24:10 -04:00
Zach Hilman
bbc1437188 core: Track system exit lock status 
Used to determine if yuzu should confirm before pausing or stopping a game.
 2019-09-21 22:23:44 -04:00
David Marcec
d3783fcc52 Use clang-format provided by build server 2019-09-22 12:21:07 +10:00
Zach Hilman
885ea2de2a pl_u: Remove excess static qualifier 2019-09-21 22:17:30 -04:00
Zach Hilman
94afffe9e5 pl_u: Use OSS system archives if real archives don't exist 2019-09-21 21:50:41 -04:00
David
a1b8e5d09a
Merge pull request #2612 from DarkLordZach/prepo-new 
prepo: Implement New, System, and Non-User variants of SaveReport
 2019-09-22 11:49:36 +10:00
Zach Hilman
682174b112 dmnt_cheat_vm: Make Cheat VM compliant to code style 2019-09-21 21:45:05 -04:00
Zach Hilman
3e729c13cc core: Initialize cheats after load to avoid VMManager crash 
This used to occur due to the VMManager being nullptr at the time cheats were registered (during load, but before it was done). This is bypassed by not accessing the VMManager for offset data until load is complete,
 2019-09-21 21:45:05 -04:00
Zach Hilman
37850eeee5 core: Update RegisterCheatList for new VM 2019-09-21 21:45:05 -04:00
Zach Hilman
a0055192fe patch_manager: Update cheat parsing for new VM 2019-09-21 21:45:05 -04:00
Zach Hilman
c6becfc9f5 nso: Pass build ID directly 
As opposed to converting to string and then back to hex array
 2019-09-21 21:44:22 -04:00
Zach Hilman
7d41c1f523 cheat_engine: Move to memory and strip VM 
This is to go with the Atmosphere VM port, now it just contains the callbacks needed for the interface between DmntCheatVm and yuzu, along with the cheat parsers.
 2019-09-21 21:44:22 -04:00
Zach Hilman
12aa127df3 memory: Port Atmosphere's DmntCheatVm 
This was done because the current VM contained many inaccuracies and this also allows cheats to have identical behavior between hardware and yuzu.
 2019-09-21 21:44:22 -04:00
Zach Hilman
8b857fc7c2 system_archive: Synthesize shared fonts system archives 2019-09-21 19:21:58 -04:00
Zach Hilman
ae9604faba pl_u: Expose method to encrypt TTF to BFTTF 2019-09-21 19:21:58 -04:00
Zach Hilman
361a8fa318 externals: Move OSS font data to file_sys in core 2019-09-21 19:21:22 -04:00
Zach Hilman
8dd2e91427 prepo: Remove system global accessors 2019-09-21 19:17:45 -04:00
Zach Hilman
daf9cd9358 prepo: Implement SaveReport New and System variants 2019-09-21 19:17:08 -04:00
Zach Hilman
787b191abf reporter: Differentiate between Old, New, and System play reports 2019-09-21 19:17:08 -04:00
Zach Hilman
038bcec111 configure_debug: Move reporting option to logging 2019-09-21 18:43:20 -04:00
Zach Hilman
a49169e819 filesystem: Add const qualification to various accessors 2019-09-21 16:50:39 -04:00
Zach Hilman
c182688ad6 core: Store FileSystemController in core 2019-09-21 16:50:39 -04:00
Zach Hilman
2590b5a9ea settings: Add options for managing gamecard emulation 2019-09-21 16:43:10 -04:00
Zach Hilman
918119ae1b settings: Add options for setting storage sizes 2019-09-21 16:43:10 -04:00
Zach Hilman
c6ff4a6f4d yuzu: Port old usages of Filesystem namespace to FilesystemController 2019-09-21 16:43:10 -04:00
Zach Hilman
faf628ad8d settings: Update LogSettings to show NAND/SDMC paths from FileUtil 2019-09-21 16:43:10 -04:00
Zach Hilman
ccaafaccfc card_image: Add accessors for gamecard certificate 
Used by fsp-srv/IDeviceOperator
 2019-09-21 16:43:10 -04:00
Zach Hilman
77f9ecd32b card_image: Add functions to query gamecard update partition 
Includes version and meta title ID, used by fsp-srv/IDeviceOperator
 2019-09-21 16:43:10 -04:00
Zach Hilman
e018a48460 content_archive: Add accessors for Rights ID and SDK Version 2019-09-21 16:43:10 -04:00
Zach Hilman
b4164d295b partition_data_manager: Add accessor for decrypted PRODINFO partition 2019-09-21 16:43:10 -04:00
Zach Hilman
4b91057688 services: Pass FileSystemController as reference to services that need it 2019-09-21 16:43:10 -04:00
Zach Hilman
1b04b72653 am: Unstub IApplicationFunctions EnsureSaveData (20) 
Creates a default save data for the application given a user ID.
 2019-09-21 16:43:10 -04:00
Zach Hilman
43af31836e filesystem: Pass Size Getter functions to IFileSystem for sizes 2019-09-21 16:43:10 -04:00
Zach Hilman
721a92775d sdmc_factory: Add SD Card size getters 2019-09-21 16:43:10 -04:00
Zach Hilman
e47b57a90f bis_factory: Add getters for NAND partition sizes 2019-09-21 16:43:10 -04:00
Zach Hilman
8abbc619a1 filesystem: Add FileSystemController to deglobalize FS services 2019-09-21 16:43:10 -04:00
Zach Hilman
0a8e540681 submisson_package: Fix edge case with improperly sized filenames 
Prevents a crash if the filename is less than 9 characters long.
 2019-09-21 16:43:10 -04:00
Zach Hilman
08c0783d34 sdmc_factory: Add accessor for SDMC Album directory 2019-09-21 16:43:10 -04:00
Zach Hilman
0084cceb20 sdmc_factory: Add accessor for SDMC PlaceholderCache 2019-09-21 16:43:10 -04:00
Zach Hilman
02b36b0eb5 sdmc_factory: Add accessor for content directory 2019-09-21 16:43:10 -04:00
Zach Hilman
49c44e3fae savedata_factory: Implement savedata creation and don't create dir on open 
Matches hardware behavior and eliminates some nasty behavior we were doing that wasn't hw-accurate at all.
 2019-09-21 16:43:10 -04:00
Zach Hilman
62d772eaed patch_manager: Add short-circuit edge-case to GetPatchVersionNames 
If title ID is 0, there are no add ons, prevents wasting time looking for them.
 2019-09-21 16:43:10 -04:00
Zach Hilman
06db4d94fd patch_manager: Add error checking to load dir to prevent crashes 
Prevents a crash if the load dir would be nullptr, instead logs an error and returns appropriately.
 2019-09-21 16:43:10 -04:00
Zach Hilman
9d9fc8a675 registered_cache: Process *.cnmt.nca files 
Needed to use the RegisteredCache/PlaceholderCache on gamecards.
 2019-09-21 16:43:10 -04:00
Zach Hilman
8500ca797f registered_cache: Implement PlaceholderCache to manage placeholder and installing content 2019-09-21 16:43:10 -04:00
Zach Hilman
256a50ad15 bis_factory: Fix mod loader edge-case with homebrew title IDs 
Fixes a bug where homebrew that has a title ID with the update bit set can cause issues with the PatchManager
 2019-09-21 16:43:10 -04:00
Zach Hilman
b71bda45ae bis_factory: Add accessors for BIS placeholder caches 2019-09-21 16:43:10 -04:00
Zach Hilman
9bee885282 bis_factory: Add accessor for NAND Image Directory 2019-09-21 16:43:10 -04:00
Zach Hilman
4dae5a52a8 bis_factory: Add accessors for BIS content directories 2019-09-21 16:43:10 -04:00
Zach Hilman
3a1899d143 bis_factory: Add accessors for BIS partitions 2019-09-21 16:43:10 -04:00
David
183c445c30
Merge pull request #2806 from FearlessTobi/port-4882 
Port citra-emu/citra#4882: "Add frametime logging for tracking performance over time"
 2019-09-21 20:09:55 +10:00
David
c7c8ffbc13
Merge pull request #2872 from FernandoS27/mem-gpu-opt 
Core/Memory: Only FlushAndInvalidate GPU if the page is marked as RasterizerCachedMemory
 2019-09-21 20:07:25 +10:00
David
25383b9ff2
Merge pull request #2576 from DarkLordZach/nsp-fix-1 
nsp: Fix various errors with loading and processing of extracted NSPs
 2019-09-21 20:05:24 +10:00
David Marcec
c2f966dbc1 Mark KickOffPb & SubmitGPFIFO as trace 
These functions are not stubbed and are called fairly often. Due to the nature of how often they're called, we should keep them marked as LOG_TRACE instead of LOG_DEBUG or LOG_WARNING
 2019-09-21 15:41:11 +10:00
David Marcec
0740758b25 disable clang-format temp 2019-09-20 10:25:12 +10:00
David Marcec
f9259c0383 Initial implementation of Ioctl2 & Ioctl3 
Purpose of Ioctl2 and Ioctl3 is to prevent the passing of raw pointers through ioctls
 2019-09-19 15:37:25 +10:00
Fernando Sahmkow
50259d7bdc Core/Memory: Only FlushAndInvalidate GPU if the page is marked as RasterizerCachedMemory 
This commit avoids Invalidating and Flushing the GPU if the page is not
marked as a RasterizerCache Page.
 2019-09-18 22:47:22 -04:00
bunnei
ddfdeea3af
Merge pull request #2667 from DarkLordZach/profile-editor 
acc: Implement IProfileEditor interface and 'Store'/'StoreWithImage' commands
 2019-09-14 00:46:18 -04:00
FearlessTobi
d36a7a43c5 Address review comments 2019-09-10 12:57:45 +02:00
fearlessTobi
684b616f0d Add frametime logging for tracking performance over time 
Co-Authored-By: jroweboy <jroweboy@gmail.com>
 2019-09-10 12:44:19 +02:00
David
07a0242535
Merge pull request #2847 from VelocityRa/nro-nacp-fix 
nro/ui: Show "Developer" field in Properties
 2019-09-09 16:45:28 +10:00
David
1487153e06
Merge pull request #2716 from lioncash/hle-global 
service/am: Remove usages of global system accessors
 2019-09-09 16:44:41 +10:00
David
6f7b349461
Merge pull request #2763 from lioncash/map-phys 
kernel/vm_manager: Minor cleanup
 2019-09-09 16:43:54 +10:00
Nick Renieris
bfc5bacecd nro: Implement ReadControlData 
With this, the "Developer" field in the Properties for homebrew is now populated.

Signed-off-by: Nick Renieris <velocityra@gmail.com>
 2019-09-08 00:40:21 +03:00
David
14d8c1b594
Merge pull request #2418 from DarkLordZach/srv-es 
es: Implement various ticket accessor commands from IEticketService
 2019-09-05 12:13:14 +10:00
David
8795645d97
Merge pull request #2707 from DarkLordZach/oss-miimodel 
system_archive: Add open-source reimplementation of MiiModel data
 2019-09-05 10:56:32 +10:00
Lioncash
d1abe8e92a service/am: Remove usages of global system accessors 
Avoids the use of global accessors, removing the reliance on global
state. This also makes dependencies explicit in the interface, as
opposed to being hidden
 2019-09-04 20:38:43 -04:00
Lioncash
f763e23083 kernel/vm_manager: Correct doxygen comment parameter tags for MapPhysicalMemory/UnmapPhysicalMemory 
Corrects the parameter names within the doxygen comments so that they
resolve properly.
 2019-09-04 19:58:55 -04:00
Lioncash
b0da7e4262 kernel/vm_manager: Move variables closer to usage spots in MapPhysicalMemory/UnmapPhysicalMemory 
Narrows the scope of variables down to where they're only necessary.
 2019-09-04 19:58:52 -04:00
David
d8e59a28ea
Merge pull request #2834 from Morph1984/audrenu_QueryAudioDeviceInputEvent 
audren_u: Stub IAudioDevice::QueryAudioDeviceInputEvent
 2019-09-05 09:51:50 +10:00
David
67bdd8ed58
Merge pull request #2836 from Morph1984/hid_vibration 
hid: Implement PermitVibration and IsVibrationPermitted
 2019-09-05 09:50:38 +10:00
David
0a4f0b6a5d
Merge pull request #2818 from MysticExile/fmt 
externals: update fmt to 6.0.0
 2019-09-05 09:50:17 +10:00
mailwl
a1d48b5f52 AM: Stub IApplicationFunctions::GetGpuErrorDetectedSystemEvent (#2827) 
* AM: Implement IApplicationFunctions::GetGpuErrorDetectedSystemEvent

* Remove unneeded event clear

* Fix event name
 2019-09-04 11:43:04 -04:00
bunnei
fe83ee102b
Merge pull request #2829 from Morph1984/audio 
service/audio/audren_u: Stub IAudioDevice::GetAudioDeviceOutputVolume
 2019-09-04 11:42:23 -04:00
Ethan
30448641f2 Fix clang-format 2019-09-04 16:53:29 +02:00
Morph1984
cd81194fc0
ditto 
Co-Authored-By: David <25727384+ogniK5377@users.noreply.github.com>
 2019-09-04 10:16:22 -04:00
Morph1984
ef98828d40
IsVibrationEnabled() as a const member func 2019-09-04 10:15:49 -04:00
Morph1984
d6969fa7d4
clang-format 2019-09-04 10:06:38 -04:00
Morph1984
ee35f7adf7
Update npad.h 2019-09-04 02:43:17 -04:00
Morph1984
5130b8a6a9
Update npad.cpp 2019-09-04 02:42:58 -04:00
Morph1984
1559477740
Update hid.h 2019-09-04 02:42:42 -04:00
Morph1984
a83eb90a78
Update hid.cpp 2019-09-04 02:42:22 -04:00
Morph1984
84815fa879
Add Kernel::EventPair audio_input_device_switch_event; 2019-09-03 23:50:56 -04:00
Morph1984
ec95c73a12
remove <f32> 
We can remove this since its already a f32 value
 2019-09-03 23:20:19 -04:00
Morph1984
1449ed9dbf
audren_u: Stub IAudioDevice::QueryAudioDeviceInputEvent 2019-09-03 23:13:32 -04:00
David
e1981b8b8d
Merge pull request #2708 from DarkLordZach/mii-db-source-crash 
mii: Handle logging of unknown database source
 2019-09-04 13:07:10 +10:00
Morph1984
58783b8a46
explicitly represent 1 as a float (1.0f instead of 1) 2019-09-03 23:06:32 -04:00
bunnei
19af91434e
Merge pull request #2793 from ReinUsesLisp/bgr565 
renderer_opengl: Implement RGB565 framebuffer format
 2019-09-03 22:36:32 -04:00
Morph1984
b1ca56bed2
Change u32 -> f32 
Volume is a f32 value. (SwIPC describes it as a u32, but it is actually f32 as corroborated by switchbrew docs and SetAudioDeviceOutputVolume)

 ```cpp
const f32 volume = rp.Pop<f32>();
```
 2019-09-03 22:30:20 -04:00
Morph1984
ba661c8d9a
service/audio/audren_u: Stub IAudioDevice::GetAudioDeviceOutputVolume 2019-09-03 16:05:33 -04:00
Lioncash
96cc9a9279 kernel/vm_manager: Correct behavior in failure case of UnmapPhysicalMemory() 
If an unmapping operation fails, we shouldn't be decrementing the amount
of memory mapped and returning that the operation was successful. We
should actually be returning the error code in this case.
 2019-08-29 19:29:43 -04:00
Lioncash
56c6f767ae kernel/vm_manager: Reserve memory ahead of time for slow path in MergeAdjacentVMA 
Avoids potentially expensive (depending on the size of the memory block)
allocations by reserving the necessary memory before performing both
insertions. This avoids scenarios where the second insert may cause a
reallocation to occur.
 2019-08-29 19:29:43 -04:00
Lioncash
a43ee8d752 kernel/vm_manager: std::move shared_ptr instance in MergeAdjacentVMA 
Avoids an unnecessary atomic reference count increment and decrement.
 2019-08-29 19:28:58 -04:00
Lioncash
785c4946dd kernel/vm_manager: Deduplicate iterator creation in MergeAdjacentVMA 
Avoids needing to read the same long sequence of code in both code
paths. Also makes it slightly nicer to read and debug, as the locals
will be able to be shown in the debugger.
 2019-08-29 19:28:57 -04:00
Lioncash
70485e690b kernel/vm_manager: Simplify some std::vector constructor calls 
Same behavior, one less magic constant to read.
 2019-08-29 19:28:04 -04:00
Lioncash
3f695333cd kernel/vm_manager: Simplify some assertion messages 
Assertions already log out the function name, so there's no need to
manually include the function name in the assertion strings.
 2019-08-29 19:26:42 -04:00
Ethan
5adbe66ae8 accommodate for fmt update 2019-08-29 21:34:51 +02:00
bunnei
b4a8cfbd00
Merge pull request #2748 from FernandoS27/align-memory 
VM_Manager: Align allocated host physical memory to 256bytes
 2019-08-21 12:10:10 -04:00
ReinUsesLisp
9a76e94b3d gpu: Change optional<reference_wrapper<T>> to T* for FramebufferConfig 2019-08-21 01:55:25 -03:00
bunnei
ef584f1a3a
Merge pull request #2747 from lioncash/audio 
service/audren_u: Unstub ListAudioDeviceName
 2019-08-18 09:08:25 -04:00
bunnei
52f54c728d
Merge pull request #2592 from FernandoS27/sync1 
Implement GPU Synchronization Mechanisms & Correct NVFlinger
 2019-07-26 14:26:44 -04:00
Fernando Sahmkow
024b5fe91a Kernel: Address Feedback 2019-07-19 11:28:57 -04:00
Fernando Sahmkow
9bede4eeed VM_Manager: Align allocated memory to 256bytes 
This commit ensures that all backing memory allocated for the Guest CPU
is aligned to 256 bytes. This due to how gpu memory works and the heavy
constraints it has in the alignment of physical memory.
 2019-07-19 10:06:08 -04:00
Lioncash
16730c4c43 service/audren_u: Handle audio USB output revision queries in ListAudioDeviceName() 
Audio devices use the supplied revision information in order to
determine if USB audio output is able to be supported. In this case, we
can only really handle using this revision information in
ListAudioDeviceName(), where it checks if USB audio output is supported
before supplying it as a device name.

A few other scenarios exist where the revision info is checked, such as:

- Early exiting from SetAudioDeviceOutputVolume if USB audio is
  attempted to be set when that device is unsupported.

- Early exiting and returning 0.0f in GetAudioDeviceOutputVolume when
  USB output volume is queried and it's an unsupported device.

- Falling back to AHUB headphones in GetActiveAudioDeviceName when the
  device type is USB output, but is unsupported based off the revision
  info.

In order for these changes to also be implemented, a few other changes
to the interface need to be made.

Given we now properly handle everything about ListAudioDeviceName(), we
no longer need to describe it as a stubbed function.
 2019-07-19 07:55:27 -04:00
Lioncash
b9ebab71be service/audren_u: Move revision testing code out of AudRenU 
The revision querying facilities are used by more than just audren. e.g.
audio devices can use this to test whether or not USB audio output is
supported.

This will be used within the following change.
 2019-07-19 07:55:23 -04:00
Lioncash
ed0485c599 service/audio: Remove global system accessors 
Trims out the lingering reliance on global state out of the audio code.
 2019-07-19 07:29:36 -04:00
Lioncash
7653e4babc service/audren_u: Remove unnecessary return value from GetActiveAudioDeviceName() 
This service function only ever returns a result and nothing more.
 2019-07-19 06:57:31 -04:00
Lioncash
6ecbc6c557 service/audren_u: Report proper device names 
AudioDevice and AudioInterface aren't valid device names on the Switch.
We should also be returning consistent names in
GetActiveAudioDeviceName().

While we're at it, we can also handle proper name output in
ListAudioDeviceName, by returning all the available devices on the
Switch.
 2019-07-19 06:57:30 -04:00
bunnei
5d369112d9
Merge pull request #2687 from lioncash/tls-process 
kernel/process: Allocate the process' TLS region during initialization
 2019-07-18 13:53:04 -04:00
Fernando Sahmkow
5e457bf258 Kernel: Downgrade WaitForAddress and SignalToAddress messages to Trace. 
This messages were originally set as warnning since few games used these
svcs and it was needed for debugging. This is no longer the case.
 2019-07-17 22:05:47 -04:00
Rodrigo Locatti
c3218c110f
Merge pull request #2726 from lioncash/access 
core: Remove CurrentArmInterface() global accessor
 2019-07-17 03:42:16 -03:00
Fernando Sahmkow
4882c058fd
Merge pull request #2690 from SciresM/physmem_fixes 
Implement MapPhysicalMemory/UnmapPhysicalMemory
 2019-07-14 09:16:46 -04:00
Lioncash
093e5440e2 core: Remove CurrentArmInterface() global accessor 
Replaces the final usage of the global accessor function and removes it.
Removes one more enabler of global state.
 2019-07-12 21:48:49 -04:00
David Marcec
ea5602b959 Clang format 2019-07-13 01:49:32 +10:00
David Marcec
73b37886c1 "AudioRenderer" thread should have a unique name 
Creating multiple "AudioRenderer" threads cause the previous thread to be overwritten. The thread will name be renamed to AudioRenderer-InstanceX, where X is the current instance number.
 2019-07-13 01:22:08 +10:00
Michael Scire
d4fc560c05 Remove unicorn mappings/unmappings 2019-07-11 15:12:33 -07:00
bunnei
79c382fafd
Merge pull request #2717 from SciresM/unmirror_memory 
Restore memory perms on svcUnmapMemory/UnloadNro
 2019-07-11 14:57:20 -04:00
bunnei
521fb325aa
Merge pull request #2723 from lioncash/mem 
core/arm: Remove obsolete Unicorn memory mapping
 2019-07-11 14:56:26 -04:00
Lioncash
f4ae449f73 service/am: Implement IsAutoSleepDisabled 
This simply queries whether or not auto-sleep facilities are disabled
and has no special handling. It's a basic getter function.
 2019-07-11 13:34:55 -04:00
Lioncash
b81f6f67f5 service/am: Implement SetAutoSleepDisabled 
Provides a basic implementation of SetAutoSleepDisabled. Until idle
handling is implemented, this is about the best we can do.

In the meantime, provide a rough documenting of specifics that occur
when this function is called on actual hardware.
 2019-07-11 13:09:03 -04:00
Lioncash
8fc806e88a yuzu: Remove setting for using Unicorn 
The JIT is mature enough that this setting can be removed, falling back
to Unicorn only on unsupported architectures. Any missing features from
Unicorn (of which there are extremely few), are mostly
developer-oriented, which most users don't care about.

Features should be coordinated with the JIT, not the interpreter,
anyhow.
 2019-07-11 05:59:13 -04:00
Lioncash
70624e1c1d core/arm: Remove obsolete Unicorn memory mapping 
This was initially necessary when AArch64 JIT emulation was in its
infancy and all memory-related instructions weren't implemented.

Given the JIT now has all of these facilities implemented, we can remove
these functions from the CPU interface.
 2019-07-11 05:35:46 -04:00
Michael Scire
072a9796f5 Restore memory perms on svcUnmapMemory/UnloadNro 
Prior to PR, Yuzu did not restore memory to RW-
on unmap of mirrored memory or unloading of NRO.

(In fact, in the NRO case, the memory was unmapped
instead of reprotected to --- on Load, so it was
actually lost entirely...)

This PR addresses that, and restores memory to RW-
as it should.

This fixes a crash in Super Smash Bros when creating
a World of Light save for the first time, and possibly
other games/circumstances.
 2019-07-11 01:38:28 -07:00
bunnei
93eaea109d
Merge pull request #2700 from ogniK5377/GetFriendList 
IFriendService::GetFriendList
 2019-07-10 16:29:48 -04:00
bunnei
463af08bed
Merge pull request #2611 from DarkLordZach/pm-info-cmd 
pm: Implement various pm commands for finding process and title IDs
 2019-07-10 16:28:29 -04:00
bunnei
d707a12b9a
Merge pull request #2650 from DarkLordZach/mii-iface-ver 
mii: Implement IDatabaseService SetInterfaceVersion
 2019-07-10 16:26:23 -04:00
Zach Hilman
adab188c2b system_archive: Add open-source reimplementation of MiiModel data 2019-07-10 07:21:36 -04:00
Zach Hilman
37a352e9d3 mii: Handle logging of unknown database source 2019-07-10 07:07:24 -04:00
David Marcec
0330f5d6f8 IFriendService::GetFriendList 
We don't have any friends implemented in Yuzu yet so it doesn't make sense to return any friends. For now we'll be returning 0 friends however the information provided will allow a proper implementation of this cmd when needed.
 2019-07-09 18:20:58 +10:00
Michael Scire
697206092e Prevent merging of device mapped memory blocks. 
This sets the DeviceMapped attribute for GPU-mapped memory blocks,
and prevents merging device mapped blocks. This prevents memory
mapped from the gpu from having its backing address changed by
block coalesce.
 2019-07-08 22:52:05 -07:00
Zach Hilman
6c3cceafdc
Merge pull request #2657 from ogniK5377/npad-assignments 
hid:StartLrAssignmentMode, hid:StopLrAssignmentMode, hid:SwapNpadAssignment
 2019-07-08 09:35:19 -04:00
David Marcec
5234e08a0d addressed issues 2019-07-08 14:51:40 +10:00
bunnei
7b28f954c9
Merge pull request #2651 from DarkLordZach/apm-boost-mode-1 
apm: Initial implementation of performance config and boost mode
 2019-07-07 21:40:30 -04:00
bunnei
8f5aae3074
Merge pull request #2642 from DarkLordZach/fsp-log-2 
fsp-srv: Implement Access Logging Functionality
 2019-07-07 21:39:40 -04:00
Zach Hilman
50d5414075 key_manager: Convert Ticket union to std::variant 2019-07-07 21:38:33 -04:00
Zach Hilman
d9ef20e5a5 es: Populate/synthesize tickets on construction 2019-07-07 21:38:33 -04:00
Zach Hilman
f8718ae779 key_manager: Add structure for Ticket parsing 2019-07-07 21:38:33 -04:00
Zach Hilman
b294b13584 es: Implement ETicket GetPersonalizedTicketData (17) 
Copies the raw personal ticket data into the buffer provided.
 2019-07-07 21:38:33 -04:00
Zach Hilman
c6a32dc077 es: Implement ETicket GetCommonTicketData (16) 
Copies the raw common ticket data for the specified rights ID into the buffer provided.
 2019-07-07 21:38:33 -04:00
Zach Hilman
44b0c19f6a es: Implement ETicket GetPersonalizedTicketSize (15) 
Returns the size of the buffer needed to hold the personal ticket associated with the rights ID.
 2019-07-07 21:38:33 -04:00
Zach Hilman
35b617b57f es: Implement ETicket GetCommonTicketSize (14) 
Returns the size of the buffer needed to hold the common ticket associated with the rights ID.
 2019-07-07 21:38:33 -04:00
Zach Hilman
669a21babb es: Implement ETicket ListPersonalizedTicket (12) 
Returns an application-specific number of entries of personal tickets, starting at offset 0.
 2019-07-07 21:38:33 -04:00
Zach Hilman
5d6bf75296 es: Implement ETicket ListCommonTicket (11) 
Returns an application specified count of entries of common tickets, starting at offset 0.
 2019-07-07 21:38:33 -04:00
Zach Hilman
11f45e6015 es: Implement ETicket CountPersonalizedTicket (10) 
Returns the number of personalized (console/user-unique) tickets in the KeyManager.
 2019-07-07 21:38:33 -04:00
Zach Hilman
71bc2182c2 es: Implement ETicket CountCommonTicket (9) 
Returns the number of common (non-console-unique) tickets in the KeyManager.
 2019-07-07 21:38:33 -04:00
Zach Hilman
475a7a4446 es: Implement ETicket GetTitleKey (8) 
Takes a rights ID as input and returns the associated title key, if it exists.
 2019-07-07 21:38:33 -04:00
Zach Hilman
f15f73a555 es: Implement ETicket ImportTicket (1) 
Takes a ticket and certificate and installs it to the KeyManager.
 2019-07-07 21:38:33 -04:00
Zach Hilman
e35fac2054 key_manager: Add accessors/helpers for ticket management 2019-07-07 21:38:33 -04:00
Zach Hilman
5275fd2789 key_manager: Add equality operator for RSAKeyPair 2019-07-07 21:38:33 -04:00
Michael Scire
ca6f08e3b1 Remove unused member function declaration 2019-07-07 13:02:41 -07:00
Michael Scire
ce64a9fab9 physmem: add helpers, cleanup logic. 2019-07-07 12:55:30 -07:00
Michael Scire
b901cd584e clang-format fixes 2019-07-07 12:08:29 -07:00
Michael Scire
1689784c19 address review commentary 2019-07-07 11:48:11 -07:00
Michael Scire
13a8fde3ad Implement MapPhysicalMemory/UnmapPhysicalMemory 
This implements svcMapPhysicalMemory/svcUnmapPhysicalMemory for Yuzu,
which can be used to map memory at a desired address by games since
3.0.0.

It also properly parses SystemResourceSize from NPDM, and makes
information available via svcGetInfo.

This is needed for games like Super Smash Bros. and Diablo 3 -- this
PR's implementation does not run into the "ASCII reads" issue mentioned
in the comments of #2626, which was caused by the following bugs in
Yuzu's memory management that this PR also addresses:
* Yuzu's memory coalescing does not properly merge blocks. This results
  in a polluted address space/svcQueryMemory results that would be
  impossible to replicate on hardware, which can lead to game code making
  the wrong assumptions about memory layout.
  * This implements better merging for AllocatedMemoryBlocks.
* Yuzu's implementation of svcMirrorMemory unprotected the entire
  virtual memory range containing the range being mirrored. This could
  lead to games attempting to map data at that unprotected
  range/attempting to access that range after yuzu improperly unmapped
  it.
  * This PR fixes it by simply calling ReprotectRange instead of
    Reprotect.
 2019-07-07 11:45:53 -07:00
Lioncash
56c7912159 kernel/process: Allocate the process' TLS region during initialization 
Prior to execution within a process beginning, the process establishes
its own TLS region for uses (as far as I can tell) related to exception
handling.

Now that TLS creation was decoupled from threads themselves, we can add
this behavior to our Process class. This is also good, as it allows us
to remove a stub within svcGetInfo, namely querying the address of that
region.
 2019-07-07 14:08:28 -04:00
Lioncash
eb6f55d880 kernel/process: Move main thread stack allocation to its own function 
Keeps this particular set of behavior isolated to its own function.
 2019-07-07 14:08:25 -04:00
Zach Hilman
a4ef86a021 mii: Implement IDatabaseService SetInterfaceVersion 
Appears to set a member variable used to affect the API that games access, and the method used to store data.
 2019-07-06 21:39:12 -04:00
Zach Hilman
9e689a81f8
Merge pull request #2674 from lioncash/reporter 
core/reporter: Minor changes
 2019-07-06 21:26:40 -04:00
Zach Hilman
fb9124b6cd
Merge pull request #2677 from lioncash/assert 
kernel/vm_manager: Handle stack/TLS IO region placement a little better
 2019-07-06 21:25:27 -04:00
Michael Scire
36259c01c2 clang-format fixes 2019-07-06 13:52:05 -07:00
Michael Scire
7fb7d3c218 am: Implement GetAccumulatedSuspendedTickValue 2019-07-06 12:13:34 -07:00
Lioncash
65c748fbd3 memory: Remove unused includes 
These aren't used within the central memory management code, so they can
be removed.
 2019-07-06 02:24:34 -04:00
Lioncash
63a5f48e7e memory: Remove unused PageTable forward declaration 
This isn't used by anything in the header file, so it can be removed.
 2019-07-06 02:24:34 -04:00
Lioncash
2a9e388290 kernel/vm_manager: Rename 'new map' to 'stack' 
Provides a more accurate name for the memory region and also
disambiguates between the map and new map regions of memory, making it
easier to understand.
 2019-07-06 02:24:30 -04:00
Lioncash
313cc36fec kernel/vm_manager: Handle stack/TLS IO region placement better 
Handles the placement of the stack a little nicer compared to the
previous code, which was off in a few ways. e.g.

The stack (new map) region, shouldn't be the width of the entire address
space if the size of the region calculation ends up being zero. It
should be placed at the same location as the TLS IO region and also have
the same size.

In the event the TLS IO region contains a size of zero, we should also
be doing the same thing. This fixes our memory layout a little bit and
also resolves some cases where assertions can trigger due to the memory
layout being incorrect.
 2019-07-05 21:57:31 -04:00
Lioncash
48807e9a24 core/reporter: Allow moves into SaveToFile() 
Taking the json instance as a constant reference, makes all moves into
the parameter non-functional, resulting in copies. Taking it by value
allows moves to function.
 2019-07-05 17:45:34 -04:00
Lioncash
2321656dbe core/reporter: Add missing includes and forward declarations 
Adds missing inclusions to prevent potential compilation issues.
 2019-07-05 17:45:24 -04:00
Lioncash
e721c344ae core/reporter: Remove unnecessary namespace qualifiers 
The Reporter class is part of the Core namespace, so the System class
doesn't need to be qualified.
 2019-07-05 17:09:26 -04:00
Lioncash
6ec48af222 core/reporter: Remove pessimizing move in GetHLERequestContextData() 
This can inhibit copy-elision, so we can remove this redundant move.
 2019-07-05 17:08:13 -04:00
Lioncash
f12eb40834 core/reporter: Make bracing consistent 
Makes all control statements braced, regardless of their size, making
code more uniform.
 2019-07-05 17:05:27 -04:00
Lioncash
7ad11e3867 core/reporter: Return in error case in SaveToFile() 
If the path couldn't be created, then we shouldn't be attempting to save
the file.
 2019-07-05 17:02:32 -04:00
Fernando Sahmkow
0fc98958a3 NVServices: Correct delayed responses. 2019-07-05 15:49:35 -04:00
Fernando Sahmkow
8c91d5c166 Nv_Host_Ctrl: Correct difference calculation 2019-07-05 15:49:34 -04:00
Fernando Sahmkow
f3a39e0c9c NVServices: Address Feedback 2019-07-05 15:49:33 -04:00
Fernando Sahmkow
d20ede40b1 NVServices: Styling, define constructors as explicit and corrections 2019-07-05 15:49:32 -04:00
Fernando Sahmkow
b391e5f638 NVFlinger: Correct GCC compile error 2019-07-05 15:49:31 -04:00
Fernando Sahmkow
0335a25d1f NVServices: Make NVEvents Automatic according to documentation. 2019-07-05 15:49:29 -04:00
Fernando Sahmkow
b6844bec60 NVServices: Correct CtrlEventWaitSync to block the ipc until timeout. 2019-07-05 15:49:28 -04:00
Fernando Sahmkow
7d1b974bca GPU: Correct Interrupts to interrupt on syncpt/value instead of event, mirroring hardware 2019-07-05 15:49:26 -04:00
Fernando Sahmkow
61697864c3 nvflinger: Make the force 30 fps still force 30 fps 2019-07-05 15:49:25 -04:00
Fernando Sahmkow
efdeab3a1d nv_services: Fixes to event liberation. 2019-07-05 15:49:24 -04:00
Fernando Sahmkow
ea97589624 nvflinger: Acquire buffers in the same order as they were queued. 2019-07-05 15:49:23 -04:00
Fernando Sahmkow
24408cce9b nv_services: Deglobalize NvServices 2019-07-05 15:49:22 -04:00
Fernando Sahmkow
0706d633bf nv_host_ctrl: Make Sync GPU variant always return synced result. 2019-07-05 15:49:20 -04:00
Fernando Sahmkow
78add28aab nvhost_ctrl: Corrections to event handling 2019-07-05 15:49:17 -04:00
Fernando Sahmkow
eef55f493b Gpu: Mark areas as protected. 2019-07-05 15:49:16 -04:00
Fernando Sahmkow
a45643cb3b nv_services: Stub CtrlEventSignal 2019-07-05 15:49:15 -04:00
Fernando Sahmkow
8942047d41 Gpu: Implement Hardware Interrupt Manager and manage GPU interrupts 2019-07-05 15:49:14 -04:00
Fernando Sahmkow
e0027eba85 nv_services: Implement NvQueryEvent, NvCtrlEventWait, NvEventRegister, NvEventUnregister 2019-07-05 15:49:13 -04:00
Fernando Sahmkow
7039ece0a0 nv_services: Create GPU channels correctly 2019-07-05 15:49:12 -04:00
Fernando Sahmkow
82b829625b video_core: Implement GPU side Syncpoints 2019-07-05 15:49:11 -04:00
Fernando Sahmkow
737e978f5b nv_services: Correct buffer queue fencing and GPFifo fencing 2019-07-05 15:49:10 -04:00
Fernando Sahmkow
ceb5f5079c nvflinger: Implement swap intervals 2019-07-05 15:49:08 -04:00
Zach Hilman
3f3a93f13b
Merge pull request #2669 from FearlessTobi/move-cpujit-setting 
yuzu: Move CPU Jit setting to Debug tab
 2019-07-04 15:33:59 -04:00
Zach Hilman
54a02d14fd
Merge pull request #2555 from lioncash/tls 
kernel/process: Decouple TLS handling from threads
 2019-07-04 15:32:32 -04:00
fearlessTobi
447bdac298 yuzu: Remove CPU Jit setting from the UI 
A normal user shouldn't change this, as it will slow down the emulation and can lead to bugs or crashes. The renaming is done in order to prevent users from leaving this on without a way to turn it off from the UI.
 2019-07-04 14:48:08 +02:00
bunnei
3c7eed16dc
Merge pull request #2658 from ogniK5377/QueryAudioDeviceOutputEvent 
IAudioDevice::QueryAudioDeviceOutputEvent
 2019-07-04 01:42:22 -04:00
bunnei
70b595a63b
Merge pull request #2638 from DarkLordZach/quest-flag 
set: Implement GetQuestFlag with config option
 2019-07-04 01:40:41 -04:00
Lioncash
e23110bd9f kernel/process: Default initialize all member variables 
Ensures a Process instance is always created with a deterministic
initial state.
 2019-07-03 20:31:40 -04:00
Lioncash
abdce723eb kernel/process: Decouple TLS handling from threads 
Extracts out all of the thread local storage management from thread
instances themselves and makes the owning process handle the management
of the memory. This brings the memory management slightly more in line
with how the kernel handles these allocations.

Furthermore, this also makes the TLS page management a little more
readable compared to the lingering implementation that was carried over
from Citra.
 2019-07-03 20:31:40 -04:00
Lioncash
55481df50f kernel/vm_manager: Add overload of FindFreeRegion() that operates on a boundary 
This will be necessary for making our TLS slot management slightly more
straightforward. This can also be utilized for other purposes in the
future.

We can implement the existing simpler overload in terms of this one
anyways, we just pass the beginning and end of the ASLR region as the
boundaries.
 2019-07-03 20:29:49 -04:00
Zach Hilman
beb3d77a79
Merge pull request #2613 from ogniK5377/InitalizeApplicationInfo 
Implemented InitializeApplicationInfo & InitializeApplicationInfoRestricted
 2019-07-03 20:23:56 -04:00
Zach Hilman
e86af37ecb
Merge pull request #2608 from ogniK5377/Time_GetSharedMemoryNativeHandle 
Implement Time::GetSharedMemoryNativeHandle
 2019-07-03 20:22:23 -04:00
Zach Hilman
471b2a4211 acc_su: Implement GetProfileEditor (205) 
Takes a UUID of a user and provides and interface that allows RW access to user data/settings.
 2019-07-03 07:57:41 -05:00
Zach Hilman
812fb30821 acc: Implement IProfileEditor-specific commands 'Store' and 'StoreWithImage' 
Verified with IDA
 2019-07-03 07:57:03 -05:00
Zach Hilman
02560d6482 profile_manager: Add setter for ProfileBase and ProfileData 
Needed by IProfileEditor 'Store' and 'StoreWithImage'
 2019-07-03 07:56:28 -05:00
Zach Hilman
39f6d57c34 acc: Add IProfileCommon for IProfile and IProfileEditor 
Since 2/3 of the commands are shared, this is likely how its done on HW.
 2019-07-03 07:55:54 -05:00
bunnei
58032e0085
Merge pull request #2604 from ogniK5377/INotificationService 
Implemented INotificationService
 2019-07-02 23:32:57 -04:00
Bakugo
b50557d1f0 file_sys: Rename other ContentRecordType members 2019-07-02 00:57:23 +01:00
David Marcec
965608e6d1 IAudioDevice::QueryAudioDeviceOutputEvent 
The event should only be signaled when an output audio device gets changed. Example, Speaker to USB headset. We don't identify different devices internally yet so there's no need to signal the event yet.
 2019-07-01 18:05:44 +10:00
Bakugo
c72ef5f405 file_sys/registered_cache: Improve missing metadata error 
This can happen when installing NSPs too, not just XCIs.
 2019-07-01 07:31:32 +01:00
Bakugo
9968c0883a file_sys/submission_package: Don't warn about missing DeltaFragment NCAs 
DeltaFragments are not useful to us and are often not included in patch NSPs.
 2019-07-01 06:46:05 +01:00
Bakugo
79163fca80 file_sys/registered_cache: Ignore DeltaFragment NCAs during installation 
DeltaFragments are only used to download and apply partial patches on a real console, and are not useful to us at all. Most patch NSPs do not include them, and when they do, it's a waste of space to install them.
 2019-07-01 06:37:22 +01:00
Bakugo
306a24aad7 file_sys: Rename ContentRecordType::Patch to DeltaFragment 
Avoids potential confusion, since patches and DeltaFragments are not the same thing. Actual full patches are listed under the Program type.
 2019-07-01 06:32:13 +01:00
David Marcec
472210bf72 hid:StartLrAssignmentMode, hid:StopLrAssignmentMode, hid:SwapNpadAssignment 
StartLrAssignmentMode and StopLrAssignmentMode don't require any implementation as it's just used for showing the screen of changing the controller orientation if the user wishes to do so.  Ever since #1634 this has not been needed as users can specify the controller orientation from the config and swap at any time. We store a private member just in case this gets used for anything extra in the future
 2019-07-01 15:12:57 +10:00
bunnei
d992909636
Merge pull request #2583 from FernandoS27/core-timing-safe 
Core_Timing: Make core_timing threadsafe by default.
 2019-06-30 12:54:00 -04:00
Zach Hilman
7e5d7773cc am: Implement SetCpuBoostMode in terms of APM 2019-06-28 22:46:51 -04:00
Zach Hilman
e2ad3e1fb0 core: Keep instance of APM Controller 2019-06-28 22:46:31 -04:00
Zach Hilman
e52306ca60 apm: Implement SetCpuBoostMode 2019-06-28 22:46:00 -04:00
Zach Hilman
1c6e6305ea apm: Add getters for performance config and mode 2019-06-28 22:45:31 -04:00
Zach Hilman
9175b00e7d apm: Add apm:am service 
8.0.0+ identical version of apm
 2019-06-28 22:44:30 -04:00
Zach Hilman
65eb9cbb28 apm: Add Controller class to manage speed data and application 2019-06-28 22:43:51 -04:00
Zach Hilman
d40f38967e fsp-srv: Implement GetAccessLogVersionInfo 
Returns some misc. data about logging to help the game determine if it should log.
 2019-06-28 21:05:42 -04:00
Zach Hilman
554e2f2f98 reporter: Add report class for filesystem access logs 2019-06-28 21:02:50 -04:00
Zach Hilman
db2fdd0352 fsp-srv: Implement OutputAccessLogToSdCard 
Allows games to log data to the SD.
 2019-06-28 21:02:34 -04:00
Zach Hilman
f477c5dfdd set: Implement GetQuestFlag 
Simply returns a true/false value indicating if the system is a kiosk system. This has been mapped to a config option for the purposes of yuzu.
 2019-06-28 18:38:47 -04:00
Zach Hilman
efa7d8d04b settings: Add config option for kiosk (quest) mode 2019-06-28 18:37:33 -04:00
bunnei
bb4a1e059c
Merge pull request #2533 from DarkLordZach/memory-frozen 
memory: Add class to manage and enforce memory freezing
 2019-06-28 14:03:38 -04:00
David Marcec
dfe4b3f723 Attemp clang format fix? 
Seems to be an issue with clang format
 2019-06-28 22:08:50 +10:00
David Marcec
7d417d501d Added errors.h to cmakelist 2019-06-28 15:31:29 +10:00
David Marcec
c2146c4eef Addressed issues 2019-06-28 15:29:38 +10:00
David Marcec
fd6549be73 Addressed issues 2019-06-28 15:19:51 +10:00
David Marcec
0b03e8a98f Implemented InitializeApplicationInfo & InitializeApplicationInfoRestricted 
InitializeApplicationInfoRestricted will need further implementation as it's checking for other user requirements about the game. As we're emulating, we're assuming the user owns the game so we skip these checks currently, implementation will need to be added further on
 2019-06-27 16:44:42 +10:00
Zach Hilman
bce4bfffb6 pm: Implement pm:shell and pm:dmnt GetApplicationPid 
Returns the process ID of the current application or 0 if no app is running.
 2019-06-26 19:07:34 -04:00
Zach Hilman
354c254cde pm: Implement pm:dmnt GetTitlePid 
Takes a title ID and searches for a matching process, returning error if it doesn't exist, otherwise the process ID.
 2019-06-26 19:06:51 -04:00
Zach Hilman
49af3bcdcb pm: Implement pm:info GetTitleId 
Searches the process list for a process with the specified ID, returning the title ID if it exists.
 2019-06-26 19:05:04 -04:00
bunnei
5829ba1ccc
Merge pull request #2548 from DarkLordZach/applet-shopn 
applets: Implement backend and default frontend for Parental Controls and EShop (ShopN) applets
 2019-06-26 15:55:24 -04:00
David Marcec
f67039c067 Addressed issues 2019-06-26 16:52:34 +10:00
Zach Hilman
d10fc2d727 glue: Correct missing bytes in ApplicationLaunchParameter 2019-06-25 22:25:10 -04:00
David Marcec
19dc36ce06 Implement Time::GetSharedMemoryNativeHandle 
This PR attempts to implement the shared memory provided by GetSharedMemoryNativeHandle. There is still more work to be done however that requires a rehaul of the current time module to handle clock contexts. This PR is mainly to get the basic functionality of the SharedMemory working and allow the use of addition to it whilst things get improved on.

Things to note:
Memory Barriers are used in the SharedMemory and a better solution would need to be done to implement this. Currently in this PR I’m faking the memory barriers as everything is sync and single threaded. They work by incrementing the counter and just populate the two data slots. On data reading, it will read the last added data.

Specific values in the shared memory would need to be updated periodically. This isn't included in this PR since we don't actively do this yet. In a later PR when time is refactored this should be done.

Finally, as we don't handle clock contexts. When time is refactored, we will need to update the shared memory for specific contexts. This PR does this already however since the contexts are all identical and not separated. We're just updating the same values for each context which in this case is empty.

Tiime:SetStandardUserSystemClockAutomaticCorrectionEnabled, Time:IsStandardUserSystemClockAutomaticCorrectionEnabled are also partially implemented in this PR. The reason the implementation is partial is because once again, a lack of clock contexts. This will be improved on in a future PR.

This PR closes issue #2556
 2019-06-26 00:45:53 +10:00
David Marcec
192f1f7ebe SizedNotificationInfo should be 0x10 bytes, user_uuid is incorrect, this should be the users account id 2019-06-25 15:19:37 +10:00
David Marcec
5d005b87a3 fixed spelling errors and fixed issue with Pop not returning the SizedNotificationInfo 2019-06-25 11:23:23 +10:00
Zach Hilman
3c4238657d applets: Pass current process title ID to applets 
Avoids using system accessor to get current process in applet code.
 2019-06-24 20:07:10 -04:00
Zach Hilman
01ff38cca8 general_frontend: Add documentation for parental controls and ecommerce applets 2019-06-24 20:05:11 -04:00
Zach Hilman
73dcb13619 web_browser: Only delete temporary directory if it was created 
Prevents crashes with ShopN applet occasionally.
 2019-06-24 20:05:11 -04:00
Zach Hilman
d018ac2c60 web_browser: Take ECommerce applet frontend optionally in constructor 
If it is needed but wasn't passed (or passed nullptr), the Shop handling code will alert and throw an error.
 2019-06-24 20:05:11 -04:00
Zach Hilman
54684feffa frontend: Add base class and default impl for ECommerce applet frontend 2019-06-24 20:05:11 -04:00
Zach Hilman
3898c3903e web_browser: Use function tables for execute and initialize 
Allows easy handling of multiple shim types, as they have enough in common to be the same backend but not enough to share init/exec.
 2019-06-24 20:05:11 -04:00
Zach Hilman
675aa5f719 web_browser: Correct structures and properly parse TLVs/ShimKind 
Much, much more HW-accurate and allows us to easily support all of the different web 'shim' types.
 2019-06-24 20:05:11 -04:00
Zach Hilman
e447d8aafa applets: Track ECommerce and Parental Control applet frontends 2019-06-24 20:05:11 -04:00
Zach Hilman
6ff9008230 web_browser: Rename OpenPage to OpenPageLocal 
This is more representative of what actually occurs, as web does support remote URLs which wouldn't need a romfs callback. This paves for easy future support of this with a call like 'OpenPageRemote' or similar.
 2019-06-24 20:05:11 -04:00
Zach Hilman
c96450f6e2 frontend: Add base class and default impl of parent controls applet frontend 2019-06-24 20:05:11 -04:00
Zach Hilman
9d2d349d7b applets: Implement Auth applet backend 
This is responsible for parental controls and supports verifying, changing, and registering PIN codes.
 2019-06-24 20:05:11 -04:00
Zach Hilman
d40a38df8d core: Keep track of ARPManager and register current application on boot 2019-06-24 19:27:35 -04:00
Zach Hilman
ce21973022 glue: Implement arp:w and arp:r services 
These keep track of running process' launch properties and control properties and allows for issuing and reading them by process and title ID.
 2019-06-24 19:26:16 -04:00
Zach Hilman
df3ee4f444 glue: Add errors for glue/arp services 2019-06-24 19:20:28 -04:00
Zach Hilman
4fab0d392b glue: Add scaffolding for bgtc:t and bgtc:sc services 2019-06-24 19:20:06 -04:00
Zach Hilman
9003e19797 arp: Move to glue services 
Glue is the name of the sysmodule that contains both arp and bgtc.
 2019-06-24 19:17:48 -04:00
Zach Hilman
5f8d2a2044 glue: Add manager to keep track of application registry 
Manages mapping between title IDs and application launch and control properties.
 2019-06-24 19:17:13 -04:00
Zach Hilman
db2e5e5fa6 registered_cache: Add getter to determine source slot in content provider union 
Used to determine StorageId source for application data.
 2019-06-24 19:10:17 -04:00
Zach Hilman
a468273221 patch_manager: Add getter for title version 2019-06-24 19:05:50 -04:00
David Marcec
e49ae3bf92 Implemented INotificationService 2019-06-24 12:26:45 +10:00
Thomas May
334e6370f9 Update reporter.cpp 2019-06-22 14:39:52 +01:00
bunnei
69e490b303
Merge pull request #2602 from lioncash/cast 
service/acc: Silence truncation warnings
 2019-06-21 15:27:25 -04:00
bunnei
8f8fa82c83
Merge pull request #2575 from DarkLordZach/process-id-types 
kernel: Differentiate kernel and user processes when picking ID
 2019-06-21 15:25:50 -04:00
bunnei
e2f7933b3f
Merge pull request #2546 from DarkLordZach/kips 
loader, file_sys: Add support for parsing and loading KIP (Kernel Internal Process) files
 2019-06-21 14:28:18 -04:00
bunnei
96412848a9
Merge pull request #2482 from DarkLordZach/prepo 
core: Add detailed local reporting feature for development
 2019-06-21 14:05:18 -04:00
Lioncash
82cd87f6c2 service/acc: Silence truncation warnings 
The sanitizing function ensures that the returned type is always the
correct type. This eliminates warnings without extra casts.
 2019-06-21 10:04:31 -04:00
Zach Hilman
4111971cbd freezer: Update documentation 2019-06-20 19:22:53 -04:00
Zach Hilman
ed82fa3a91 core: Move Freezer class to tools namespace 2019-06-20 19:22:53 -04:00
Zach Hilman
c9983ad9a7 freezer: Add documentation for methods 2019-06-20 19:22:04 -04:00
Zach Hilman
1b7d619914 memory: Add class to manage and enforce memory freezing 2019-06-20 19:22:04 -04:00
bunnei
80a8456af8
Merge pull request #2596 from FernandoS27/revert-2590 
Revert PR 2590.
 2019-06-20 13:04:06 -04:00
Hexagon12
908a5a00c5
Merge pull request #2595 from jonsn0w/patch-1 
Update content_archive.cpp
 2019-06-20 10:03:24 +03:00
Fernando Sahmkow
26fcdf087d Revert PR 2590. 
Even though it has been proven that IAudioRenderer:SystemEvent is 
actually an automatic event. The current implementation of such event is 
all thought to be manual. Thus it's implementation needs to be corrected 
when doing such change. As it is right now this PR introduced a series 
of regressions on softlocks on multiple games. Therefore, this pr 
reverts such change until a correct implementation is made.
 2019-06-19 23:19:19 -04:00
bunnei
c28694d907
Merge pull request #2591 from lioncash/record 
core: Remove unused CiTrace source files
 2019-06-19 22:28:26 -04:00
bunnei
ca470890a3
Merge pull request #2590 from lioncash/event 
service/audio/audren_u: Correct event reset type for the system event
 2019-06-19 22:27:52 -04:00
jonsn0w
e78d069a81
Update content_archive.cpp 
log clutter in debug logs when theres really no need
 2019-06-19 22:01:41 -04:00
Lioncash
61d2498f00 core: Remove unused CiTrace source files 
These source files have been unused for the entire lifecycle of the
project. They're a hold-over from Citra and only add to the build time
of the project, so they can be removed.

There's also likely no way this would ever work in yuzu in its current
form without revamping quite a bit of it, given how different the GPU on
the Switch is compared to the 3DS.
 2019-06-18 16:57:59 -04:00
Lioncash
5799404b78 service/audio/audren_u: Correct event reset type for the system event 
This is actually an auto-reset event in the audio service itself, not a
manual one.
 2019-06-18 09:23:20 -04:00
David Marcec
6ca20ad7ba Addressed issues 2019-06-17 08:17:26 +10:00
Fernando Sahmkow
90792cdb6e Core_Timing: Make core_timing threadsafe by default. 
The old implementation had faulty Threadsafe methods where events could
be missing. This implementation unifies unsafe/safe methods and makes
core timing thread safe overall.
 2019-06-16 14:14:35 -04:00
David Marcec
50e3269f3b Signalled accumulated_suspended_tick_changed_event on creation based on RE 2019-06-16 22:18:54 +10:00
David Marcec
5fb6781c61 Cleanup 2019-06-16 20:18:35 +10:00
David Marcec
335127af69 Impl'd IsUserAccountSwitchLocked, SetAudioOutVolume, GetAudioOutVolume & Partial impl of GetAccumulatedSuspendedTickChangedEvent 
IPC-100 was changed to InitializeApplicationInfoOld instead of InitializeApplicationInfo. IPC-150 makes an indentical call to IPC-100 however does extra processing. They should not have the same name as it's quite confusing to debug.
 2019-06-16 19:06:33 +10:00
Zach Hilman
c140b6ae2c
Merge pull request #2581 from lioncash/hex 
common/hex_util: Combine HexVectorToString() and HexArrayToString()
 2019-06-15 16:47:13 -04:00
bunnei
0360c40e90
Merge pull request #2582 from lioncash/reserved 
file_sys/ips_layer: Remove unnecessary reserve() call
 2019-06-14 11:24:18 -04:00
Zach Hilman
a9521c983b
Merge pull request #2580 from lioncash/redundant 
kernel/vm_manager: Remove redundant Reset call in destructor
 2019-06-12 19:26:07 -04:00
Zach Hilman
0f08f2d562
Merge pull request #2577 from lioncash/fs 
file_sys/card_image: Minor cleanup
 2019-06-12 19:23:33 -04:00
Lioncash
18c1d91920
file_sys/ips_layer: Remove unnecessary reserve() call 
Given 'replace' is assigned to on the following line, this isn't
necessary, given the underlying data is going to be overwritten
entirely.
 2019-06-12 18:12:45 -04:00
Lioncash
a62088539e
common/hex_util: Combine HexVectorToString() and HexArrayToString() 
These can be generified together by using a concept type to designate
them. This also has the benefit of not making copies of potentially very
large arrays.
 2019-06-12 17:54:05 -04:00
Lioncash
c7daddb715
file_sys/card_image: Remove obsolete TODO 
We already support Rev 1+.
 2019-06-12 16:52:19 -04:00
Lioncash
0af3b4d9f4
kernel/vm_manager: Remove redundant Reset call in destructor 
This is performing more work than would otherwise be necessary during
VMManager's destruction. All we actually want to occur in this scenario
is for any allocated memory to be freed, which will happen automatically
as the VMManager instance goes out of scope.

Anything else being done is simply unnecessary work.
 2019-06-12 16:10:00 -04:00
Lioncash
a602bcaaf8
file_sys/nca_metadata: Update CNMT structures 
Names a few more entries in relevant structures. Information based off
SwitchBrew and my own RE.
 2019-06-10 23:51:06 -04:00
Lioncash
7bdef6106e
file_sys/card_image: Deduplicate casts within AddNCAFromPartition() 
Makes for nicer reading.
 2019-06-10 23:27:14 -04:00
Lioncash
81d361d9f8
file_sys/card_image: Make bracing consistent 
Makes for more consistent reading.
 2019-06-10 23:27:13 -04:00
Lioncash
e34368249f
file_sys/card_image: Assign collapsed NCA contents directly to ncas member 
Same thing, significantly less noisy.
 2019-06-10 23:27:13 -04:00
Lioncash
288d027e89
file_sys/card_image: Deduplicate type cast 
Same thing, less duplication. We can also std::move raw into the
PartitionFilesystem constructor.
 2019-06-10 23:27:05 -04:00
Lioncash
825ffd7b1f
file_sys/card_image: Get rid of a magic number 
We can just use the size of the array to dehardcode it.
 2019-06-10 22:58:08 -04:00
Lioncash
bf35138d1d
file_sys/card_image: Use std::array deduction guides 
Same thing, less code.
 2019-06-10 22:57:53 -04:00
Zach Hilman
fc0bf91a96 kernel: Differentiate kernel and user processes when picking ID 
This allows kernel internal type processes to be assigned IDs in the KIP range while userland processes are assigned in the user range.
 2019-06-10 00:28:33 -04:00
Zach Hilman
b957a4862f nsp: Correct status codes for extracted NSPs 
Avoids all extracted NSPs being marked as error file type because they don't have program NCAs.
 2019-06-10 00:21:41 -04:00
Zach Hilman
1c75945dc4 nsp: Use title ID from NPDM metadata for extracted type NSPs 
Avoids 0 being used as title ID for all extracted NSPs.
 2019-06-10 00:19:23 -04:00
Zach Hilman
425cdf946c arm_dynarmic: Check if jit is nullptr when preparing reschedule 
Prevents crash with multiprocess loading.
 2019-06-10 00:14:25 -04:00
Zach Hilman
364932df3a
Merge pull request #2571 from lioncash/ref 
kernel/process: Make Create()'s name parameter be taken by value
 2019-06-09 20:43:57 -04:00
Lioncash
fea6568955 kernel/process: Make Create()'s name parameter be taken by value 
Makes the interface more flexible in terms of how Create() may be
called, while still allowing the parameter itself to be moved into.
 2019-06-09 18:47:37 -04:00
Lioncash
3f87664d8f kernel/svc: Implement TotalMemoryUsedWithoutMmHeap/TotalMemoryAvailableWithoutMmHeap 
Given we don't currently implement the personal heap yet, the existing
memory querying functions are essentially doing what the memory querying
types introduced in 6.0.0 do.

So, we can build the necessary machinery over the top of those and just
use them as part of info types.
 2019-06-09 18:22:30 -04:00
Lioncash
c1a8f684df kernel/svc: Amend naming for TotalMemoryUsage in svcGetInfo() 
Disambiguates and makes the name a little more consistent with
TotalPhysicalMemoryUsed.
 2019-06-09 18:12:05 -04:00
Lioncash
81b1102090 kernel/svc: Remove duplicate enum entry in svcGetInfo() 2019-06-09 18:08:37 -04:00
Zach Hilman
11f2f0f45c constants: Extract backup JPEG used by account services 2019-06-07 17:46:57 -04:00
Zach Hilman
de33ad25f5
Merge pull request #2514 from ReinUsesLisp/opengl-compat 
video_core: Drop OpenGL core in favor of OpenGL compatibility
 2019-06-07 17:23:25 -04:00
Zach Hilman
9db119f8a2 kernel_executable: Optimize BLZ decompression 2019-06-06 19:20:15 -04:00
Zach Hilman
adb8a9152b
Merge pull request #2549 from lioncash/header 
kernel/process: Remove unused boost header include
 2019-06-06 14:31:46 -04:00
bunnei
03d9bbaa90
Merge pull request #2551 from lioncash/dtor 
service/ns: Add missing override specifiers
 2019-06-06 10:37:28 -04:00
bunnei
e4fea833d4
Merge pull request #2419 from DarkLordZach/srv-lr-iface 
lr: Add command handler skeletons for Open*LocationResolver
 2019-06-05 18:05:50 -04:00
Lioncash
8304aaf282 service/ns: Add missing override specifiers 2019-06-05 16:20:24 -04:00
Zach Hilman
799302bc9d
Merge pull request #2526 from lioncash/global 
core/telemetry_session: Remove usages of the global system accessor
 2019-06-05 15:57:48 -04:00
Zach Hilman
81e09bb121
Merge pull request #2545 from lioncash/timing 
core/core_timing_util: Use std::chrono types for specifying time units
 2019-06-05 15:52:37 -04:00
Zach Hilman
2beaaa35c5
Merge pull request #2510 from SciresM/desired_language 
Implement/Fix IApplicationFunctions::GetDesiredLanguage
 2019-06-05 15:39:33 -04:00
Lioncash
19dcb50692 kernel/process: Remove unused boost header include 
Boost headers typically include a lot of other headers, so removing this
can prevent a bit of unnecessary compiler churn when building.
 2019-06-05 14:03:29 -04:00
Zach Hilman
c417b4fe28 game_list: Accept *.kip as a file extension of executables 2019-06-05 00:33:05 -04:00
Zach Hilman
ce9f7ac4f2 loader: Add recognition for KIP file type 2019-06-05 00:22:07 -04:00
Zach Hilman
a76bd49268 loader: Add KIP and INI file parser-specific errors 2019-06-05 00:21:44 -04:00
Zach Hilman
c3548967b1 loader: Add AppLoader_KIP for KIP files 2019-06-05 00:21:17 -04:00
Zach Hilman
b550a01f74 program_metadata: Add function to load meta from raw parameters 
Needed for KIP loading as KIPs do not have an NPDM but do have the essential parts of the data within.
 2019-06-05 00:20:26 -04:00
Zach Hilman
0f37096820 partition_data_manager: Remove KIP processing and use FileSys 
Previously, this TU contained the necessary headers to parse KIP/INI but now it should just use the FileSys class.
 2019-06-05 00:19:29 -04:00
Zach Hilman
421c3e831a file_sys: Add classes to parse KIP1 and INI1 files 2019-06-05 00:18:25 -04:00
Lioncash
2548661c08 core/core_timing_util: Amend casing of cyclesTo* functions 
Makes the casing consistent with all of our general function naming
conventions.
 2019-06-04 20:31:46 -04:00
Lioncash
42f5fd0ab3 core/core_timing_util: Use std::chrono types for specifying time units 
Makes the interface more type-safe and consistent in terms of return
values.
 2019-06-04 20:31:24 -04:00
Lioncash
79189c7e3e core/core_timing_utils: Simplify overload set 
Removes unused overloads, simplifying the overall interface,
deduplicating some code.
 2019-06-04 19:44:05 -04:00
Lioncash
e32bf646cf yuzu/bootmanager: Treat the resolution factor as a u32 
Treating it as a u16 can result in a sign-conversion warning when
performing arithmetic with it, as u16 promotes to an int when aritmetic
is performed on it, not unsigned int.

This also makes the interface more uniform, as the layout interface now
operates on u32 across the board.
 2019-06-03 15:34:31 -04:00
bunnei
ed74a3cb8b
Merge pull request #1931 from DarkLordZach/mii-database-1 
mii: Implement MiiManager backend and several mii service commands
 2019-05-30 13:26:40 -04:00
ReinUsesLisp
7259f7a733 rasterizer_opengl: Remove OpenGL core profile 2019-05-30 13:21:00 -03:00
bunnei
665b7e8e18
Merge pull request #2518 from ReinUsesLisp/sdl2-window 
yuzu_cmd: Split emu_window OpenGL implementation into its own file
 2019-05-29 11:01:12 -04:00
Lioncash
8bbe930fac core/core: Remove unnecessary includes 
The contents of these includes aren't used anywhere in this translation
unit.
 2019-05-29 00:00:27 -04:00
Lioncash
84a8fb9264 core/loader: Remove LoadKernelSystemMode 
This is a hold-over from Citra and doesn't apply to yuzu.
 2019-05-28 22:28:44 -04:00
Lioncash
b1a4ab2ccc core/telemetry_session: Remove unnecessary web service nulling out in destructor 
This will automatically occur when the backend instance goes out of
scope at the end of the destructor's execution.
 2019-05-28 22:28:18 -04:00
Lioncash
215fd82738 core/telemetry_session: Remove usages of the global system accessor 
Makes the dependency explicit in the TelemetrySession's interface
instead of making it a hidden dependency.

This also revealed a hidden issue with the way the telemetry session was
being initialized. It was attempting to retrieve the app loader and log
out title-specific information. However, this isn't always guaranteed to
be possible.

During the initialization phase, everything is being constructed. It
doesn't mean an actual title has been selected. This is what the Load()
function is for. This potentially results in dead code paths involving
the app loader. Instead, we explicitly add this information when we know
the app loader instance is available.
 2019-05-28 22:28:15 -04:00
Lioncash
05af9d915c core/telemetry_session: Explicitly delete copy and move constructors 
NonCopyable is misleading here. It also makes the class non-moveable as
well, so we can be explicit about this.
 2019-05-28 21:07:38 -04:00
Lioncash
2fb3b9b951 core/telemetry_session: Remove unused include 2019-05-28 20:56:22 -04:00
bunnei
cfd885163f
Merge pull request #2519 from lioncash/sign 
loader/nso, core/core_timing_util: Silence sign-comparison warning
 2019-05-27 12:26:17 -04:00
Zach Hilman
52b80d231c ncm: Implement LR OpenAddOnContentLocationResolver (2) 
Returns an object of type IAddOnContentLocationResolver for the provided StorageId.
 2019-05-26 20:37:13 -04:00
Zach Hilman
e0920ef4ba ncm: Implement LR OpenRegisteredLocationResolver (1) 
Returns an object of type IRegisteredLocationResolver for the StorageId.
 2019-05-26 18:24:48 -04:00
Zach Hilman
33ac193bf6 ncm: Implement LR OpenLocationResolver (0) 
Returns an object of type ILocationResolver with the provided StorageId.
 2019-05-26 18:24:48 -04:00
Zach Hilman
b77fde7c5c loader: Move NSO module tracking to AppLoader 
Also cleanup of general stuff
 2019-05-26 11:40:46 -04:00
ReinUsesLisp
37eaf39b44 emu_window: Pass OnMinimalClientAreaChangeRequest argument by copy 
There's no performance improvement in passing an unsigned pair by
reference.
 2019-05-26 00:54:13 -03:00
bunnei
bb248a2710
Merge pull request #2509 from lioncash/aoc 
service/aoc_u: Minor cleanup
 2019-05-25 23:00:12 -04:00
Lioncash
0fa039d8d0 core_timing_util: Silence sign-comparison warnings 
We can just make the conversion explicit instead of implicit here to
silence -Wsign-compare warnings.
 2019-05-25 17:01:18 -04:00
Lioncash
e5159cfb84 loader/nso: Silence sign-comparison warning 
This was previously performing a size_t == int comparison. Silences a
-Wsign-compare warning.
 2019-05-25 16:53:33 -04:00
Zach Hilman
cdf52b9374 prepo: Save reports from PlayReport service 
Logs a lot of seemingly innocuous telemetry games generate.
 2019-05-25 16:09:20 -04:00
Zach Hilman
34e9736910 fatal: Save report on fatal:u call 
Matches offical behavior with creport and replaces old log/text based report system.
 2019-05-25 16:09:20 -04:00
Zach Hilman
fc309bf893 service: Save report on unimplemented function call 2019-05-25 16:09:20 -04:00
Zach Hilman
24392c8ec8 applets/error: Save report on error applet 
This matches official behavior with the erpt/eclct/eupld service chain.
 2019-05-25 16:09:20 -04:00
Zach Hilman
bdc47693f1 applets: Save report on stubbed applet 
This also reworks the applet data storage to be peekable.
 2019-05-25 16:09:20 -04:00
Zach Hilman
186db894b9 svc: Save report on call to svcBreak 2019-05-25 16:09:20 -04:00
Zach Hilman
2dde8f5cfe core: Add Reporter class to take/save reports 2019-05-25 16:09:20 -04:00
Zach Hilman
658d2ee97d settings: Add 'Reporting Services' config option 
Full enable/disable for all reports.
 2019-05-25 16:09:20 -04:00
Zach Hilman
5574be21cc arm_interface: Expand backtrace generation 
Returns results as a vector of entries for further processing. Logs addresses, offsets, and mangled name.
 2019-05-25 16:06:53 -04:00
Zach Hilman
2179ad7483 core: Track load offsets of NSO modules 
Needed for backtrace decomposition
 2019-05-25 16:06:53 -04:00
bunnei
d4f8fe24d9
Merge pull request #2489 from FearlessTobi/port-4716 
Port citra-emu/citra#4716: "HLE/IPC: HLEContext can memorize the client thread and use it for SleepClientThread"
 2019-05-24 18:23:15 -04:00
Michael Scire
016f2eab73 Fix bitmask logic inversion 2019-05-23 02:37:13 -07:00
Michael Scire
2ed896075e fix introduced clang-format errors 2019-05-23 01:39:22 -07:00
Michael Scire
d81b58f320 Address review comments 2019-05-23 01:28:27 -07:00
Michael Scire
7fba9c7224 clang-format fixes 2019-05-23 01:14:11 -07:00
Michael Scire
7dbf4c1ae5 Implement IApplicationFunctions::GetDesiredLanguage 2019-05-23 00:55:56 -07:00
Lioncash
3e7d37301a service/aoc: Avoid allocating and discarding data 
Previously, the code was accumulating data into a std::vector and then
tossing all of it away if a setting was disabled.

Instead, we can just check if it's disabled and do no work at all if
possible. If it's enabled, then we can append to the vector and
allocate.

Unlikely to impact usage much, but it is slightly less sloppy with
resources.
 2019-05-23 00:26:21 -04:00
Lioncash
d0e200a894 service/aoc: Remove unnecessary includes 
Removes two header dependencies related to file handling that aren't
actually used within the source file.
 2019-05-22 23:26:12 -04:00
Lioncash
819d229e76 service/aoc: Pop all passed values where applicable 
A few of the aoc service stubs/implementations weren't fully popping all
of the parameters passed to them. This ensures that all parameters are
popped and, at minimum, logged out.
 2019-05-22 23:24:27 -04:00
bunnei
13dda1d8ed
Merge pull request #2410 from lioncash/affinity 
kernel/svc: Reorganize and fix up the initial handling of svcSetThreadCoreMask()
 2019-05-19 13:59:52 -04:00
Hexagon12
6fd247c84a
Merge pull request #2439 from lioncash/audren 
service/audren_u: Get rid of magic values within GetAudioRendererWorkBufferSize
 2019-05-19 15:23:04 +01:00
Hexagon12
594328f494
Merge pull request #2463 from lioncash/set 
service/set: Correct and simplify behavior related to copying language codes
 2019-05-19 15:17:39 +01:00
Hexagon12
3ff0c70c72
Merge pull request #2487 from lioncash/service-return 
service/am: Add missing return in error case for IStorageAccessor's Read/Write()
 2019-05-19 14:59:40 +01:00
Hexagon12
edf8c0a545
Merge pull request #2490 from lioncash/float 
ipc_helpers: Amend floating-point type in Pop<double> specialization
 2019-05-19 14:50:30 +01:00
Sebastian Valle
27033de2e5
Merge pull request #2486 from lioncash/resetname 
core/kernel/object: Rename ResetType enum members for clarity
 2019-05-19 08:47:59 -05:00
Lioncash
242273788a ipc_helpers: Amend floating-point type in Pop<double> specialization 
Currently, this overload isn't used, so this wasn't actually hit in any
code, only the float overload is used.
 2019-05-18 22:05:33 -04:00
Tobias
5993133d5e
Address review comment 
Co-Authored-By: Mat M. <mathew1800@gmail.com>
 2019-05-19 02:14:30 +02:00
Lioncash
d5cce86431 kernel/svc: Mark GetThreadList() and UnmapProcessCodeMemory() as internally linked 
These are only used from within this translation unit, so they don't
need to have external linkage. They were intended to be marked with this
anyways to be consistent with the other service functions.
 2019-05-18 19:10:34 -04:00
Lioncash
88c263ee8e service/am: Add missing return in error case for IStorageAccessor's Read()/Write(). 
Previously this would fall through and return successfully, despite
being an out of bounds read or write.
 2019-05-18 18:50:04 -04:00
Lioncash
a47aaa7f1b core/kernel/object: Rename ResetType enum members 
Renames the members to more accurately indicate what they signify.
"OneShot" and "Sticky" are kind of ambiguous identifiers for the reset
types, and can be kind of misleading. Automatic and Manual communicate
the kind of reset type in a clearer manner. Either the event is
automatically reset, or it isn't and must be manually cleared.

The "OneShot" and "Sticky" terminology is just a hold-over from Citra
where the kernel had a third type of event reset type known as "Pulse".
Given the Switch kernel only has two forms of event reset types, we
don't need to keep the old terminology around anymore.
 2019-05-18 15:52:51 -04:00
Weiyi Wang
8d6342384b HLE/IPC: HLEContext can memorize the client thread and use it for SleepClientThread 
This reduces the boilerplate that services have to write out the current thread explicitly. Using current thread instead of client thread is also semantically incorrect, and will be a problem when we implement multicore (at which time there will be multiple current threads)
 2019-05-18 19:53:39 +02:00
Lioncash
c823cf6594 service/set: Correct and simplify behavior related to copying language codes 
This corrects cases where it was possible to write more entries into the
write buffer than were requested. Now, we check the size of the buffer
before actually writing into them.

We were also returning the wrong value for
GetAvailableLanguageCodeCount2(). This was previously returning 64, but
only 17 should have been returned. 64 entries is the size of the static
array used in MakeLanguageCode() within the service binary itself, but
isn't the actual total number of language codes present.
 2019-05-09 21:28:36 -04:00
bunnei
7cb17834c7
Merge pull request #2437 from lioncash/audctl 
service/audctl: Update documentation comments to be relative to 8.0.0
 2019-05-09 13:24:13 -04:00
bunnei
5907619a04
Merge pull request #2445 from FearlessTobi/port-4749 
Port citra-emu/citra#4749: "web_service: Misc fixes"
 2019-05-09 13:22:00 -04:00
bunnei
5b6571c170
Merge pull request #2453 from lioncash/enum 
core/memory: Remove unused FlushMode enum
 2019-05-09 13:19:49 -04:00
Lioncash
495a8d8d95 core/memory: Remove unused FlushMode enum 
Recent changes to memory-related code resulted in this being unused, so
we can remove it.
 2019-05-07 13:55:17 -04:00
zhupengfei
10c4f23953 core/telemetry_session: Only create the backend when we really need it 
The backend is not used until we decide to submit the testcase/telemetry, and creating it early prevents users from updating the credentials properly while the games are running.
 2019-05-04 19:45:48 +02:00
Lioncash
1230a0e7ce
core/frontend/emu_window: Make GraphicsContext's destructor virtual 
This class is used in a polymorphic context, so destruction of the
context will lead to undefined behavior if the destructor isn't virtual.
 2019-05-04 01:47:38 -04:00
Lioncash
2bcb8a20b4 service/audren_u: Handle variadic command buffers in GetWorkBufferSize() 
Also introduced in REV5 was a variable-size audio command buffer. This
also affects how the size of the work buffer should be determined, so we
can add handling for this as well.

Thankfully, no other alterations were made to how the work buffer size
is calculated in 7.0.0-8.0.0. There were indeed changes made to to how
some of the actual audio commands are generated though (particularly in
REV7), however they don't apply here.
 2019-04-30 23:52:28 -04:00
Lioncash
03746be097 service/audren_u: Handle version 2 of performance frame info in GetWorkBufferSize() 
Introduced in REV5. This is trivial to add support for, now that
everything isn't a mess of random magic constant values.

All this is, is a change in data type sizes as far as this function
cares.
 2019-04-30 23:52:28 -04:00
Lioncash
de93507a5a service/audren_u: Clean up work buffer calculations 
"Unmagics" quite a few magic constants within this code, making it much
easier to understand. Particularly given this factors out specific
sections into their own self-contained lambda functions.
 2019-04-30 23:51:59 -04:00
Lioncash
75a8b304d4 loader/nso: Remove left-in debug pragma 
Unintentionally introduced in 552d5071fa
 2019-04-30 22:55:53 -04:00
Lioncash
19632d2421 kernel/svc: Make svcCreateThread/svcStartThread/svcSleepThread/svcExitThread calls show up in the debug log 
These are actually quite important indicators of thread lifetimes, so
they should be going into the debug log, rather than being treated as
misc info and delegated to the trace log.
 2019-04-29 01:38:27 -04:00
Lioncash
d672c6e759 kernel/svc: Reorganize svcSetThreadCoreMask() 
Makes the code much nicer to follow in terms of behavior and control
flow. It also fixes a few bugs in the implementation.

Notably, the thread's owner process shouldn't be accessed in order to
retrieve the core mask or ideal core. This should be done through the
current running process. The only reason this bug wasn't encountered yet
is because we currently only support running one process, and thus every
owner process will be the current process.

We also weren't checking against the process' CPU core mask to see if an
allowed core is specified or not.

With this out of the way, it'll be less noisy to implement proper
handling of the affinity flags internally within the kernel thread
instances.
 2019-04-29 01:38:27 -04:00
Lioncash
69a2003a8e kernel/thread: Update thread processor ID flags 
Adds the missing flags to the enum and documents them.
 2019-04-29 01:37:51 -04:00
bunnei
2be32eb3d2
Merge pull request #2412 from lioncash/system 
kernel/vm_manager: Remove usages of global system accessors
 2019-04-28 22:27:14 -04:00
Lioncash
565fce71b1 service/audctl: Update documentation comments to be relative to 8.0.0 
The state of these service calls are still the same in version 8.0.0.
 2019-04-27 23:17:58 -04:00
Zach Hilman
4e462d1fd7 mii_manager: Fix incorrect loop condition in mii UUID generation code 2019-04-25 08:57:23 -04:00
Zach Hilman
851c01c45e profile_select: Port Service::Account::UUID to Common::UUID 2019-04-25 08:13:11 -04:00
Zach Hilman
1aa2b99a98 mii: Implement Delete and Destroy file 2019-04-25 08:07:57 -04:00
Zach Hilman
c40cff454d mii: Implement IsUpdated command (IPC 0) 2019-04-25 08:07:57 -04:00
Zach Hilman
f0db2e3ef3 mii_manager: Cleanup and optimization 2019-04-25 08:07:57 -04:00
Zach Hilman
e25a7891e9 mii: Implement IDatabaseService commands using MiiManager 
Since the MiiManager was designed around the IPC interface, this is quite easy. Only functions that were clearly defined were implemented.
 2019-04-25 08:07:57 -04:00
Zach Hilman
daf5b8c61b mii: Add MiiManager class to manage Mii database 
Provides serialization/deserialization to the database in system save files, accessors for database state and proper handling of both major Mii formats (MiiInfo and MiiStoreData)
 2019-04-25 08:07:57 -04:00
Zach Hilman
ca5638a142 common: Extract UUID to its own class 
Since the Mii database uses UUIDs very similar to the Accounts database, it makes no sense to not share code between them.
 2019-04-25 08:07:57 -04:00
bunnei
78574e7a47
Merge pull request #2416 from lioncash/wait 
kernel/svc: Clean up wait synchronization related functionality
 2019-04-24 22:56:08 -04:00
bunnei
94db649205
Merge pull request #2424 from FernandoS27/compat 
Allow picking a Compatibility Profile for OpenGL.
 2019-04-24 22:54:27 -04:00
bunnei
53f746fa9a
Merge pull request #2228 from DarkLordZach/applet-manager-p1 
applets: Add AppletManager and implement PhotoViewer and Error applets
 2019-04-24 22:53:21 -04:00
bunnei
9cab042674
Merge pull request #2420 from lioncash/audctl 
service/audctl: Implement GetTargetVolumeMin() and GetTargetVolumeMax()
 2019-04-22 22:12:48 -04:00
Fernando Sahmkow
788497fd9d Allow picking a Compatibility Profile for OpenGL. 
This option allows picking the compatibility profile since a lot of bugs
are fixed in it. We devs will use this option to easierly debug current
problems in our Core implementation.:wq
 2019-04-20 00:05:24 -04:00
bunnei
62c2404d3c
Merge pull request #2415 from lioncash/const 
kernel/wait_object: Make GetHighestPriorityReadyThread() a const member function
 2019-04-19 19:12:02 -04:00
bunnei
b6faea0dd2
Merge pull request #2421 from lioncash/svc-call 
kernel/svc: Name supervisor call 0x36
 2019-04-19 19:10:20 -04:00
bunnei
40dc893c37
Merge pull request #2374 from lioncash/pagetable 
core: Reorganize boot order
 2019-04-19 19:09:20 -04:00
Lioncash
f8be3f55da kernel/svc: Name supervisor call 0x36 
This call was added to the SVC handlers in the 8.0.0 kernel, so we can
finally give it a name.
 2019-04-19 14:34:56 -04:00
Lioncash
19f8f86bdb service/audctl: Implement GetTargetVolumeMin() and GetTargetVolumeMax() 
These two service functions are literally hardcoded to always return
these values without any other error checking.
 2019-04-18 16:39:54 -04:00
bunnei
83b830eb2f
Merge pull request #2397 from lioncash/thread-unused 
kernel/thread: Remove unused guest_handle member variable
 2019-04-17 21:46:46 -04:00
Zach Hilman
2adb226b26 web_browser: Make OpenPage non-const 2019-04-17 11:35:24 -04:00
Zach Hilman
8f8049e846 main: Add GMainWindow hooks for Error display 2019-04-17 11:35:24 -04:00
Zach Hilman
f6e2295055 general_backend: Move StubApplet and add backend PhotoViewer 2019-04-17 11:35:24 -04:00
Zach Hilman
80c9e4d3ab general_frontend: Add frontend scaffold for PhotoViewer applet 2019-04-17 11:35:24 -04:00
Zach Hilman
d9f6715d45 frontend: Add frontend receiver for Error applet 2019-04-17 11:35:24 -04:00
Zach Hilman
de3cfb1d37 applets: Add Error applet 
Responsible for displaying error codes and messages
 2019-04-17 11:35:24 -04:00
Zach Hilman
d273bec68f applets: Port current applets to take frontend in constructor 
As opposed to using Core::System::GetInstance()
 2019-04-17 11:35:24 -04:00
Zach Hilman
f7540157e4 web_browser: Make OpenPage const 2019-04-17 11:35:24 -04:00
Zach Hilman
ec0bc3061e core: Remove specific applets in favor of AppletManager 2019-04-17 11:35:24 -04:00
Zach Hilman
6cea62b756 am: Delegate applet creation to AppletManager 2019-04-17 11:35:24 -04:00
Zach Hilman
e51d33f0ce applets: Add AppletManager class to control lifetime 2019-04-17 11:35:24 -04:00
Lioncash
c268ffd831 kernel/thread: Unify wait synchronization types 
This is a holdover from Citra, where the 3DS has both
WaitSynchronization1 and WaitSynchronizationN. The switch only has one
form of wait synchronizing (literally WaitSynchonization). This allows
us to throw out code that doesn't apply at all to the Switch kernel.

Because of this unnecessary dichotomy within the wait synchronization
utilities, we were also neglecting to properly handle waiting on
multiple objects.

While we're at it, we can also scrub out any lingering references to
WaitSynchronization1/WaitSynchronizationN in comments, and change them
to WaitSynchronization (or remove them if the mention no longer
applies).
 2019-04-17 09:30:56 -04:00
Lioncash
433b59c112 kernel/svc: Migrate svcCancelSynchronization behavior to a thread function 
The actual behavior of this function is slightly more complex than what
we're currently doing within the supervisor call. To avoid dumping most
of this behavior in the supervisor call itself, we can migrate this to
another function.
 2019-04-17 09:30:56 -04:00
Lioncash
6b2bece81f kernel/wait_object: Make GetHighestPriorityReadyThread() a const member function 
This doesn't actually modify internal state of a wait object, so it can
be const qualified.
 2019-04-17 06:44:34 -04:00
Lioncash
b6a87b422e kernel/vm_manager: Remove usages of global system accessors 
Makes the dependency on the system instance explicit within VMManager's
interface.
 2019-04-16 20:02:50 -04:00
bunnei
9186f76b07
Merge pull request #2382 from lioncash/table 
service: Update service function tables
 2019-04-15 21:46:15 -04:00
bunnei
fc64156533
Merge pull request #2393 from lioncash/svc 
kernel/svc: Implement svcMapProcessCodeMemory/svcUnmapProcessCodeMemory
 2019-04-15 21:43:56 -04:00
Lioncash
3283aa1e20 svc: Specify handle value in thread's name 
Allows the handle to be seen alongside the entry point.
 2019-04-15 15:56:18 -04:00
Lioncash
e3566e6c1d kernel/thread: Remove BoostPriority() 
This is a holdover from Citra that currently remains unused, so it can
be removed from the Thread interface.
 2019-04-15 06:59:19 -04:00
Lioncash
09caf8a756 kernel/thread: Remove unused guest_handle member variable 
This member variable is entirely unused. It was only set but never
actually utilized. Given that, we can remove it to get rid of noise in
the thread interface.
 2019-04-14 06:06:06 -04:00
bunnei
1f4dfb3998
Merge pull request #2378 from lioncash/ro 
ldr: Minor amendments to IPC-related parameters
 2019-04-13 22:16:10 -04:00
bunnei
6088898b02
Merge pull request #2357 from zarroboogs/force-30fps-mode 
Add a toggle to force 30FPS mode
 2019-04-13 22:14:04 -04:00
bunnei
a788c861bd
Merge pull request #2381 from lioncash/fs 
fsp_srv: Minor cleanup related changes
 2019-04-13 22:09:58 -04:00
bunnei
065f83c6c3
Merge pull request #2017 from jroweboy/glwidget 
Frontend: Migrate to QOpenGLWindow and support shared contexts
 2019-04-13 22:08:40 -04:00
Lioncash
4d293bb5cb kernel/svc: Implement svcUnmapProcessCodeMemory 
Essentially performs the inverse of svcMapProcessCodeMemory. This unmaps
the aliasing region first, then restores the general traits of the
aliased memory.

What this entails, is:

- Restoring Read/Write permissions to the VMA.
- Restoring its memory state to reflect it as a general heap memory region.
- Clearing the memory attributes on the region.
 2019-04-12 21:56:03 -04:00
Lioncash
76a2465655 kernel/svc: Implement svcMapProcessCodeMemory 
This is utilized for mapping code modules into memory. Notably, the
ldr service would call this in order to map objects into memory.
 2019-04-12 21:55:50 -04:00
Lioncash
612e1388df core/core: Move process execution start to System's Load() 
This gives us significantly more control over where in the
initialization process we start execution of the main process.

Previously we were running the main process before the CPU or GPU
threads were initialized (not good). This amends execution to start
after all of our threads are properly set up.
 2019-04-11 22:11:41 -04:00
Lioncash
32a6ceb4e5 core/process: Remove unideal page table setting from LoadFromMetadata() 
Initially required due to the split codepath with how the initial main
process instance was initialized. We used to initialize the process
like:

Init() {
    main_process = Process::Create(...);
    kernel.MakeCurrentProcess(main_process.get());
}

Load() {
    const auto load_result = loader.Load(*kernel.GetCurrentProcess());
    if (load_result != Loader::ResultStatus::Success) {
        // Handle error here.
    }
    ...
}

which presented a problem.

Setting a created process as the main process would set the page table
for that process as the main page table. This is fine... until we get to
the part that the page table can have its size changed in the Load()
function via NPDM metadata, which can dictate either a 32-bit, 36-bit,
or 39-bit usable address space.

Now that we have full control over the process' creation in load, we can
simply set the initial process as the main process after all the loading
is done, reflecting the potential page table changes without any
special-casing behavior.

We can also remove the cache flushing within LoadModule(), as execution
wouldn't have even begun yet during all usages of this function, now
that we have the initialization order cleaned up.
 2019-04-11 22:11:41 -04:00
Lioncash
a4b0a8559c core/core: Move main process creation into Load() 
Now that we have dependencies on the initialization order, we can move
the creation of the main process to a more sensible area: where we
actually load in the executable data.

This allows localizing the creation and loading of the process in one
location, making the initialization of the process much nicer to trace.
 2019-04-11 22:11:40 -04:00
Lioncash
6d0551196d video_core/gpu: Create threads separately from initialization 
Like with CPU emulation, we generally don't want to fire off the threads
immediately after the relevant classes are initialized, we want to do
this after all necessary data is done loading first.

This splits the thread creation into its own interface member function
to allow controlling when these threads in particular get created.
 2019-04-11 22:11:40 -04:00
Lioncash
f2331a804a core/cpu_core_manager: Create threads separately from initialization. 
Our initialization process is a little wonky than one would expect when
it comes to code flow. We initialize the CPU last, as opposed to
hardware, where the CPU obviously needs to be first, otherwise nothing
else would work, and we have code that adds checks to get around this.

For example, in the page table setting code, we check to see if the
system is turned on before we even notify the CPU instances of a page
table switch. This results in dead code (at the moment), because the
only time a page table switch will occur is when the system is *not*
running, preventing the emulated CPU instances from being notified of a
page table switch in a convenient manner (technically the code path
could be taken, but we don't emulate the process creation svc handlers
yet).

This moves the threads creation into its own member function of the core
manager and restores a little order (and predictability) to our
initialization process.

Previously, in the multi-threaded cases, we'd kick off several threads
before even the main kernel process was created and ready to execute (gross!).
Now the initialization process is like so:

Initialization:
  1. Timers

  2. CPU

  3. Kernel

  4. Filesystem stuff (kind of gross, but can be amended trivially)

  5. Applet stuff (ditto in terms of being kind of gross)

  6. Main process (will be moved into the loading step in a following
                   change)

  7. Telemetry (this should be initialized last in the future).

  8. Services (4 and 5 should ideally be alongside this).

  9. GDB (gross. Uses namespace scope state. Needs to be refactored into a
          class or booted altogether).

  10. Renderer

  11. GPU (will also have its threads created in a separate step in a
           following change).

Which... isn't *ideal* per-se, however getting rid of the wonky
intertwining of CPU state initialization out of this mix gets rid of
most of the footguns when it comes to our initialization process.
 2019-04-11 22:11:40 -04:00
bunnei
83a2fb3c3a
Merge pull request #2360 from lioncash/svc-global 
kernel/svc: Deglobalize the supervisor call handlers
 2019-04-11 21:50:05 -04:00
bunnei
e2f2155dab
Merge pull request #2388 from lioncash/constexpr 
kernel: Make handle type declarations constexpr
 2019-04-11 21:49:45 -04:00
Lioncash
6300ccbc3c kernel: Make handle type declarations constexpr 
Some objects declare their handle type as const, while others declare it
as constexpr. This makes the const ones constexpr for consistency, and
prevent unexpected compilation errors if these happen to be attempted to be
used within a constexpr context.
 2019-04-11 16:34:53 -04:00
Lioncash
ca96dc4676 service: Update service function tables 
Updates function tables based off information from SwitchBrew.
 2019-04-11 02:47:00 -04:00
Lioncash
dae2449880 ldr: Mark IsValidNROHash() as a const member function 
This doesn't modify instance state, so it can be made const.
 2019-04-10 15:57:02 -04:00
Lioncash
0032cf3818 ldr: Amend parameters for LoadNro/UnloadNro LoadNrr/UnloadNrr 
The initial two words indicate a process ID. Also UnloadNro only
specifies one address, not two.
 2019-04-10 15:56:43 -04:00
Lioncash
8676832064 fsp_srv: Remove unnecessary parameter popping in IDirectory's Read() 
IDirectory's Read() function doesn't take any input parameters. It only
uses the output parameters that we already provide.
 2019-04-10 13:04:08 -04:00
Lioncash
fc436bb09b fsp_srv: Log out option values in IFile's Read and Write functions 
These indicate options that alter how a read/write is performed.

Currently we don't need to handle these, as the only one that seems to
be used is for writes, but all the custom options ever seem to do is
immediate flushing, which we already do by default.
 2019-04-10 13:01:52 -04:00
Lioncash
08d507a196 kernel/server_session: Remove obsolete TODOs 
These are holdovers from Citra.
 2019-04-09 23:34:49 -04:00
bunnei
61f63bb994
Merge pull request #1957 from DarkLordZach/title-provider 
file_sys: Provide generic interface for accessing game data
 2019-04-09 19:16:37 -04:00
Lioncash
2abf979c35 kernel/process: Set page table when page table resizes occur. 
We need to ensure dynarmic gets a valid pointer if the page table is
resized (the relevant pointers would be invalidated in this scenario).

In this scenario, the page table can be resized depending on what kind
of address space is specified within the NPDM metadata (if it's
present).
 2019-04-09 13:00:56 -04:00
zarroboogs
be6466d5c0 added a toggle to force 30fps mode 2019-04-09 02:14:03 +03:00
Lioncash
b117ca5fce kernel/svc: Deglobalize the supervisor call handlers 
Adjusts the interface of the wrappers to take a system reference, which
allows accessing a system instance without using the global accessors.

This also allows getting rid of all global accessors within the
supervisor call handling code. While this does make the wrappers
themselves slightly more noisy, this will be further cleaned up in a
follow-up. This eliminates the global system accessors in the current
code while preserving the existing interface.
 2019-04-07 20:30:05 -04:00
bunnei
3c1ce290d0
Merge pull request #2361 from lioncash/pagetable 
core/memory: Minor simplifications to page table management
 2019-04-07 17:50:31 -04:00
bunnei
52ad5fa0e8
Merge pull request #2356 from lioncash/pair 
kernel/{server_port, server_session}: Return pairs instead of tuples from pair creation functions
 2019-04-07 17:48:00 -04:00
Lioncash
36a1e6a982 core/memory: Remove unused enum constants 
These are holdovers from Citra and can be removed.
 2019-04-07 03:04:55 -04:00
Lioncash
abae7577d2 core/memory: Remove GetCurrentPageTable() 
Now that nothing actually touches the internal page table aside from the
memory subsystem itself, we can remove the accessor to it.
 2019-04-07 02:47:37 -04:00
Lioncash
a6a82bb004 arm/arm_dynarmic: Remove unnecessary current_page_table member 
Given the page table will always be guaranteed to be that of whatever
the current process is, we no longer need to keep this around.
 2019-04-07 02:43:51 -04:00
Lioncash
e779686a76 kernel: Handle page table switching within MakeCurrentProcess() 
Centralizes the page table switching to one spot, rather than making
calling code deal with it everywhere.
 2019-04-07 01:12:54 -04:00
Lioncash
7a7ffa602d kernel/server_session: Return a std::pair from CreateSessionPair() 
Keeps the return type consistent with the function name. While we're at
it, we can also reduce the amount of boilerplate involved with handling
these by using structured bindings.
 2019-04-06 01:42:03 -04:00
Lioncash
04d265562f kernel/server_port: Return a std::pair from CreatePortPair() 
Returns the same type that the function name describes.
 2019-04-06 01:36:53 -04:00
bunnei
7d1c0fd1ad
Merge pull request #2325 from lioncash/name 
kernel/server_session: Provide a GetName() override
 2019-04-05 23:48:13 -04:00
bunnei
54c7e8e40e
Merge pull request #2240 from FearlessTobi/port-4651 
Port citra-emu/citra#4651: "gdbstub: Fix some bugs in IsMemoryBreak() and ServeBreak. Add workaround to let watchpoints break into GDB."
 2019-04-05 23:46:37 -04:00
bunnei
00207cc965
Merge pull request #2340 from lioncash/view 
file_sys/fsmitm_romfsbuild: Utilize a string_view in romfs_calc_path_hash
 2019-04-05 23:40:16 -04:00
bunnei
e86b26cd2b
Merge pull request #2334 from lioncash/override 
core: Add missing override specifiers where applicable
 2019-04-05 23:39:52 -04:00
bunnei
23d3cd7604
Merge pull request #2341 from lioncash/compare 
file_sys/nca_metadata: Remove unnecessary comparison operators for TitleType
 2019-04-05 23:38:37 -04:00
bunnei
d6cddffb78
Merge pull request #2339 from lioncash/rank 
service/fsp_srv: Update SaveDataInfo and SaveDataDescriptor structs
 2019-04-05 23:36:46 -04:00
bunnei
b8fbd125e6
Merge pull request #2343 from lioncash/todo 
file_sys/program_metadata: Remove obsolete TODOs
 2019-04-05 23:35:54 -04:00
bunnei
854ac468b9
Merge pull request #2329 from lioncash/sanitize 
kernel/svc: Properly sanitize mutex address in WaitProcessWideKeyAtomic
 2019-04-05 23:35:06 -04:00
bunnei
150a3c0890
Merge pull request #2344 from lioncash/result 
hle/result: Remove unnecessary bitfield entry for ResultCode
 2019-04-05 23:34:42 -04:00
Lioncash
5dfcf7cf26 hle/result: Remove unnecessary bitfield entry for ResultCode 
This is a hold over from the 3DS error codes in Citra.
 2019-04-05 16:34:34 -04:00
Lioncash
37b23efece file_sys/program_metadata: Remove obsolete TODOs 
BitField has been trivially copyable since
e99a148628, so we can eliminate these
TODO comments and use ReadObject() directly instead of memcpying the
data.
 2019-04-05 15:57:47 -04:00
Lioncash
a1868286b0 file_sys/nca_metadata: Remove unnecessary comparison operators for TitleType 
enum class elements from the same enum can already be compared against
one another without the need for explicitly defined comparison
operators.
 2019-04-05 15:20:07 -04:00
Lioncash
28e36de56f file_sys/fsmitm_romfsbuild: Utilize a string_view in romfs_calc_path_hash() 
The given string instance doesn't need to be copied entirely, we can
just use a view instead.
 2019-04-05 15:12:20 -04:00
Lioncash
c05c8a7a06 service/fsp_srv: Don't pass SaveDataDescriptor instances by value. 
Passing around a 64 byte data struct by value is kind of wasteful,
instead pass a reference to the struct.
 2019-04-05 11:04:01 -04:00
Lioncash
d0ed3ff4b7 service/fsp_srv: Remove unnecessary unknown member in OpenSaveDataFileSystem 
The unknown member here is actually padding due to being passed as a
struct. We can do the same, and remove the need to pop a padding word.
 2019-04-05 11:04:01 -04:00
Lioncash
d9ee58a3b5 service/fsp_srv: Update SaveDataInfo and SaveDataDescriptor structs 
I realized that I updated the documentation on SwitchBrew a while ago,
but never actually updated the structs within yuzu.
 2019-04-05 11:03:53 -04:00
bunnei
d6b7195192
Merge pull request #2338 from lioncash/fs 
filesystem: Use a std::string_view in OpenFile()
 2019-04-05 10:52:54 -04:00
bunnei
7c1af3aa10
Merge pull request #2292 from lioncash/nacp 
file_sys/control_metadata: Amend naming of members
 2019-04-04 22:37:42 -04:00
Lioncash
15e0c4c4ec filesystem: Use a std::string_view in OpenFile() 
Rather than make a full copy of the path, we can just use a string view
and truncate the viewed portion of the string instead of creating a totally
new truncated string.
 2019-04-04 20:59:00 -04:00
Lioncash
7f506be2ee hle/service: Resolve unused variable warnings 
In several places, we have request parsers where there's nothing to
really parse, simply because the HLE function in question operates on
buffers. In these cases we can just remove these instances altogether.

In the other cases, we can retrieve the relevant members from the parser
and at least log them out, giving them some use.
 2019-04-04 13:18:09 -04:00
Lioncash
5b0a9f8ba8 core: Add missing override specifiers where applicable 
Applies the override specifier where applicable. In the case of
destructors that are  defaulted in their definition, they can
simply be removed.

This also removes the unnecessary inclusions being done in audin_u and
audrec_u, given their close proximity.
 2019-04-04 12:19:44 -04:00
bunnei
acde8d3f68
Merge pull request #2328 from lioncash/transfer 
service/am: Correct behavior of CreateTransferMemoryStorage()
 2019-04-03 21:54:32 -04:00
bunnei
d6374b2522
Merge pull request #2093 from FreddyFunk/disk-cache-better-compression 
Better LZ4 compression utilization for the disk based shader cache and the yuzu build system
 2019-04-03 21:50:29 -04:00
bunnei
a655b59cef
Merge pull request #2324 from lioncash/enum-unused 
kernel/object: Remove unused handle type entry
 2019-04-03 21:47:09 -04:00
Lioncash
a973271b8c file_sys/control_metadata: Amend naming of members 
Quite a bit of these were out of sync with Switchbrew (and in some cases
entirely wrong). While we're at it, also expand the section of named
members. A segment within the control metadata is used to specify
maximum values for the user, device, and cache storage max sizes and
journal sizes.

These appear to be generally used by the am service (e.g. in
CreateCacheStorage, etc).
 2019-04-03 21:18:12 -04:00
Lioncash
c39c8e6982 kernel/svc: Properly sanitize mutex address in WaitProcessWideKeyAtomic 
We need to be checking whether or not the given address is within the
kernel address space or if the given address isn't word-aligned and bail
in these scenarios instead of trashing any kernel state.
 2019-04-03 20:25:41 -04:00
Lioncash
ea8f633dc0 service/am: Correct behavior of CreateTransferMemoryStorage() 
For whatever reason, shared memory was being used here instead of
transfer memory, which (quite clearly) will not work based off the name
of the function.

This corrects this wonky usage of shared memory.
 2019-04-03 17:49:21 -04:00
Lioncash
140cd5e209 kernel/transfer_memory: Add accessors to data and sizes 
Also amend erroneous use of size_t. We should be using u64 here.
 2019-04-03 17:49:16 -04:00
bunnei
a6d5ff05dc
Merge pull request #2294 from lioncash/fatal 
service/am: Implement EnterFatalSection/LeaveFatalSection
 2019-04-03 12:12:07 -04:00
bunnei
580e3564c9
Merge pull request #2305 from lioncash/shared 
kernel/shared_memory: Sanitize supplied size when unmapping
 2019-04-03 11:48:11 -04:00
bunnei
74a4a50470
Merge pull request #2314 from lioncash/const 
kernel/thread: Minor interface cleanup
 2019-04-03 11:46:17 -04:00
Lioncash
a074363a5d kernel/server_session: Provide a GetName() override 
Given server sessions can be given a name, we should allow retrieving
it instead of using the default implementation of GetName(), which would
just return "[UNKNOWN KERNEL OBJECT]".
 2019-04-03 10:39:06 -04:00
Lioncash
7ccb0b16cd kernel/object: Remove unused handle type entry 
The AddressArbiter type isn't actually used, given the arbiter itself
isn't a direct kernel object (or object that implements the wait object
facilities).

Given this, we can remove the enum entry entirely.
 2019-04-03 10:24:32 -04:00
bunnei
e796351a0d
Merge pull request #2270 from lioncash/plist 
kernel/svc: Implement svcGetProcessList and svcGetThreadList
 2019-04-02 21:40:39 -04:00
bunnei
57279e1981
Merge pull request #2313 from lioncash/reslimit 
kernel/resource_limit: Remove the name member from resource limits
 2019-04-02 16:03:54 -04:00
Lioncash
28719ee3b4 kernel/svc: Implement svcGetThreadList 
Similarly like svcGetProcessList, this retrieves the list of threads
from the current process. In the kernel itself, a process instance
maintains a list of threads, which are used within this function.

Threads are registered to a process' thread list at thread
initialization, and unregistered from the list upon thread destruction
(if said thread has a non-null owning process).

We assert on the debug event case, as we currently don't implement
kernel debug objects.
 2019-04-02 00:48:40 -04:00
Lioncash
cb2bce8006 kernel/svc: Implement svcGetProcessList 
This service function simply copies out a specified number of kernel
process IDs, while simultaneously reporting the total number of
processes.
 2019-04-02 00:47:14 -04:00
ReinUsesLisp
592a24ae53 process: Fix up compilation 2019-04-02 01:44:32 -03:00
bunnei
29df6bbbd3
Merge pull request #2281 from lioncash/memory 
kernel/codeset: Make CodeSet's memory data member a regular std::vector
 2019-04-01 22:20:05 -04:00
Lioncash
4366241739 kernel/thread: Make AllWaitObjectsReady() a const qualified member function 
Now that ShouldWait() is a const qualified member function, this one can
be made const qualified as well, since it can handle passing a const
qualified this pointer to ShouldWait().
 2019-04-01 18:23:50 -04:00
Lioncash
20cc0b8d3c kernel/wait_object: Make ShouldWait() take thread members by pointer-to-const 
Given this is intended as a querying function, it doesn't make sense to
allow the implementer to modify the state of the given thread.
 2019-04-01 18:19:45 -04:00
Lioncash
2d70c30fb2 kernel/thread: Avoid sign conversion within GetCommandBufferAddress() 
Previously this was performing a u64 + int sign conversion. When dealing
with addresses, we should generally be keeping the arithmetic in the
same signedness type.

This also gets rid of the static lifetime of the constant, as there's no
need to make a trivial type like this potentially live for the entire
duration of the program.
 2019-04-01 17:59:45 -04:00
Lioncash
26d0381161 kernel/thread: Make parameter of GetWaitObjectIndex() const qualified 
The pointed to member is never actually modified, so it can be made
const.
 2019-04-01 17:48:33 -04:00
Lioncash
d09e98f566 kernel/resource_limit: Remove the name member from resource limits 
This doesn't really provide any benefit to the resource limit interface.
There's no way for callers to any of the service functions for resource
limits to provide a custom name, so all created instances of resource
limits other than the system resource limit would have a name of
"Unknown".

The system resource limit itself is already trivially identifiable from
its limit values, so there's no real need to take up space in the object to
identify one object meaningfully out of N total objects.
 2019-04-01 16:49:28 -04:00
bunnei
62860dc0b0
Merge pull request #2301 from FearlessTobi/remove-amiibo-setting 
core/yuzu: Remove enable_nfc setting
 2019-04-01 15:02:08 -04:00
Lioncash
781ab8407b general: Use deducation guides for std::lock_guard and std::unique_lock 
Since C++17, the introduction of deduction guides for locking facilities
means that we no longer need to hardcode the mutex type into the locks
themselves, making it easier to switch mutex types, should it ever be
necessary in the future.
 2019-04-01 12:53:47 -04:00
bunnei
d9b7bc4474
Merge pull request #2304 from lioncash/memsize 
kernel/process: Report total physical memory used to svcGetInfo slightly better
 2019-03-30 20:11:17 -04:00
bunnei
ba3d95e550
Merge pull request #2308 from lioncash/deduction 
kernel/scheduler: Minor tidying up
 2019-03-30 19:59:10 -04:00
Lioncash
824b8e4086 kernel/scheduler: Remove unused parameter to AddThread() 
This was made unused in b404fcdf14, but
the parameter itself wasn't removed.
 2019-03-30 05:29:33 -04:00
Lioncash
cb805f45ae kernel/scheduler: Use deduction guides on mutex locks 
Since C++17, we no longer need to explicitly specify the type of the
mutex within the lock_guard. The type system can now deduce these with
deduction guides.
 2019-03-30 05:28:43 -04:00
Lioncash
4b33a346ed service/fatal: Mark local variables as const where applicable 2019-03-30 03:06:23 -04:00
Lioncash
11505d3d9f service/fatal: Remove unnecessary semicolon 
Resolves a -Wextra-semi warning.
 2019-03-30 03:04:16 -04:00
Lioncash
cc737e5832 service/fatal: Name FatalInfo structure members 
Based off RE, most of these structure members are register values, which
makes, sense given this service is used to convey fatal errors.

One member indicates the program entry point address, one is a set of
bit flags used to determine which registers to print, and one member
indicates the architecture type.

The only member that still isn't determined is the final member within
the data structure.
 2019-03-30 03:01:20 -04:00
Lioncash
108be41316 kernel/shared_memory: Remove unused core/memory.h include 
Nothing from this header is used, so we can remove this include, getting
rid of a dependency on it.
 2019-03-29 18:16:22 -04:00
Lioncash
c6147a439d kernel/shared_memory: Sanitize supplied size when unmapping 
The kernel makes sure that the given size to unmap is always the same
size as the entire region managed by the shared memory instance,
otherwise it returns an error code signifying an invalid size.

This is similarly done for transfer memory (which we already check for).
 2019-03-29 18:16:19 -04:00
unknown
c791192d64 Addressed feedback 2019-03-29 18:12:42 +01:00
unknown
6a1a2d4aa5 core: Do not link LZ4 to core. Use common/data_compression for nso segment decompression instead. 2019-03-29 16:42:34 +01:00
fearlessTobi
ff7e6a42c1 core/yuzu: Remove enable_nfc setting 
This was initially added to prevent problems from stubbed/not implemented NFC services, but as we never encountered such and as it's only used in a deprecated function anyway, I guess we can just remove it to prevent more clutter of the settings.
 2019-03-29 15:02:28 +01:00
Lioncash
3a846aa80f kernel/process: Report total physical memory used to svcGetInfo 
Reports the (mostly) correct size through svcGetInfo now for queries to
total used physical memory. This still doesn't correctly handle memory
allocated via svcMapPhysicalMemory, however, we don't currently handle
that case anyways.
 2019-03-28 22:59:20 -04:00
Lioncash
2289e895aa kernel/process: Store the total size of the code memory loaded 
This will be necessary to properly report the used memory size in
svcGetInfo.
 2019-03-28 22:51:17 -04:00
bunnei
f770c17d01
Merge pull request #2266 from FernandoS27/arbitration 
Kernel: Fixes to Arbitration and SignalProcessWideKey Management
 2019-03-28 21:42:24 -04:00
bunnei
b404fcdf14
Merge pull request #2265 from FernandoS27/multilevelqueue 
Replace old Thread Queue for a new Multi Level Queue
 2019-03-28 21:41:40 -04:00
Lioncash
5d4ab5ec2f kernel/process: Store the main thread stack size to a data member 
This will be necessary in order to properly report memory usage within
svcGetInfo.
 2019-03-28 18:45:06 -04:00
Lioncash
427f1e3e3d kernel/process: Make Run's stack size parameter a u64 
This will make operating with the process-related SVC commands much
nicer in the future (the parameter representing the stack size in
svcStartProcess is a 64-bit value).
 2019-03-28 18:26:12 -04:00
Lioncash
2aca7b9e1e kernel/process: Ensure that given stack size is always page-aligned 
The kernel always makes sure that the given stack size is aligned to
page boundaries.
 2019-03-28 18:25:00 -04:00
bunnei
16dc3a1dd5
Merge pull request #2284 from lioncash/heap-alloc 
kernel/vm_manager: Unify heap allocation/freeing functions
 2019-03-28 17:56:49 -04:00
Zach Hilman
552d5071fa patch_manager: Dump NSO name with build ID 2019-03-27 20:09:01 -04:00
Fernando Sahmkow
db42bcb306 Fixes and corrections on formatting. 2019-03-27 14:49:43 -04:00
Fernando Sahmkow
dde0814837 Use MultiLevelQueue instead of old ThreadQueueList 2019-03-27 14:34:32 -04:00
Zach Hilman
41d2565f29 game_list: Register content with ContentProvider 2019-03-26 22:05:37 -04:00
Zach Hilman
60f39060c6 core: Port current uses of RegisteredCache to ContentProvider 2019-03-26 22:05:37 -04:00
Zach Hilman
45cb41f517 core: Store system-wide ContentProvider for the emulator 2019-03-26 22:05:37 -04:00
Zach Hilman
a6c7ae6fe8 file_sys: Create ContentProvider interface and default implementations 2019-03-26 22:03:26 -04:00
Lioncash
758d84db9a service/am: Implement EnterFatalSection and LeaveFatalSection 
These functions act in tandem similar to how a lock or mutex require a
balanced lock()/unlock() sequence.

EnterFatalSection simply increments a counter for how many times it has
been called, while LeaveFatalSection ensures that a previous call to
EnterFatalSection has occured. If a previous call has occurred (the
counter is not zero), then the counter gets decremented as one would
expect. If a previous call has not occurred (the counter is zero), then
an error code is returned.
 2019-03-26 17:02:42 -04:00
Lioncash
96d518a59f service/am: Sort ISelfController's member functions according to table order 
Makes the declaration order of the handling functions consistent with
the handler table itself.
 2019-03-26 17:02:29 -04:00
bunnei
47f2405ab1
Merge pull request #2285 from lioncash/unused-struct 
kernel/process: Remove unused AddressMapping struct
 2019-03-26 11:17:03 -04:00
bunnei
595511876e
Merge pull request #2287 from lioncash/coretiming-cb 
core/core_timing: Make callback parameters consistent
 2019-03-25 21:06:33 -04:00
bunnei
8a24a804c5
Merge pull request #2286 from lioncash/fwd 
kernel/kernel: Remove unnecessary forward declaration
 2019-03-25 21:05:33 -04:00
Lioncash
b26481c94b core/cheat_engine: Make MemoryReadImpl and MemoryWriteImpl internally linked 
These don't need to be visible outside of the translation unit, so they
can be enclosed within an anonymous namespace.
 2019-03-24 18:34:42 -04:00
Lioncash
c5d41fd812 core/core_timing: Make callback parameters consistent 
In some cases, our callbacks were using s64 as a parameter, and in other
cases, they were using an int, which is inconsistent.

To make all callbacks consistent, we can just use an s64 as the type for
late cycles, given it gets rid of the need to cast internally.

While we're at it, also resolve some signed/unsigned conversions that
were occurring related to the callback registration.
 2019-03-24 18:12:17 -04:00
Lioncash
bd7ec1a749 kernel/kernel: Remove unnecessary forward declaration 
This is no longer necessary, as ResultVal isn't used anywhere in the
header.
 2019-03-24 17:48:54 -04:00
Lioncash
7c4bc7b883 kernel/process: Remove unused AddressMapping struct 
Another leftover from citra that's now no longer necessary.
 2019-03-24 17:40:11 -04:00
Lioncash
1e92ba2785 kernel/vm_manager: Handle shrinking of the heap size within SetHeapSize() 
One behavior that we weren't handling properly in our heap allocation
process was the ability for the heap to be shrunk down in size if a
larger size was previously requested.

This adds the basic behavior to do so and also gets rid of HeapFree, as
it's no longer necessary now that we have allocations and deallocations
going through the same API function.

While we're at it, fully document the behavior that this function
performs.
 2019-03-24 17:08:30 -04:00
Lioncash
99a163478b kernel/vm_manager: Rename HeapAllocate to SetHeapSize 
Makes it more obvious that this function is intending to stand in for
the actual supervisor call itself, and not acting as a general heap
allocation function.

Also the following change will merge the freeing behavior of HeapFree
into this function, so leaving it as HeapAllocate would be misleading.
 2019-03-24 17:08:30 -04:00
Lioncash
abdb81ccaf kernel/vm_manager: Handle case of identical calls to HeapAllocate 
In cases where HeapAllocate is called with the same size of the current
heap, we can simply do nothing and return successfully.

This avoids doing work where we otherwise don't have to. This is also
what the kernel itself does in this scenario.
 2019-03-24 17:08:30 -04:00
Lioncash
9f63acac0f kernel/vm_manager: Remove unused class variables 
Over time these have fallen out of use due to refactoring, so these can
be removed.
 2019-03-24 17:08:30 -04:00
Lioncash
52980df1aa kernel/vm_manager: Remove unnecessary heap_used data member 
This isn't required anymore, as all the kernel ever queries is the size
of the current heap, not the total usage of it.
 2019-03-24 17:08:16 -04:00
Lioncash
586cab6172 kernel/vm_manager: Tidy up heap allocation code 
Another holdover from citra that can be tossed out is the notion of the
heap needing to be allocated in different addresses. On the switch, the
base address of the heap will always be managed by the memory allocator
in the kernel, so this doesn't need to be specified in the function's
interface itself.

The heap on the switch is always allocated with read/write permissions,
so we don't need to add specifying the memory permissions as part of the
heap allocation itself either.

This also corrects the error code returned from within the function.
If the size of the heap is larger than the entire heap region, then the
kernel will report an out of memory condition.
 2019-03-24 16:17:31 -04:00
bunnei
3f74518e19
Merge pull request #2232 from lioncash/transfer-memory 
core/hle/kernel: Split transfer memory handling out into its own class
 2019-03-24 16:00:23 -04:00
bunnei
1665b70cc6
Merge pull request #2221 from DarkLordZach/firmware-version 
set_sys: Implement GetFirmwareVersion(2) for libnx hosversion
 2019-03-23 13:48:29 -04:00
bunnei
6af322a347
Merge pull request #2280 from lioncash/nso 
loader/nso: Minor refactoring
 2019-03-23 13:46:09 -04:00
Lioncash
c0a01f3adc kernel/codeset: Make CodeSet's memory data member a regular std::vector 
The use of a shared_ptr is an implementation detail of the VMManager
itself when mapping memory. Because of that, we shouldn't require all
users of the CodeSet to have to allocate the shared_ptr ahead of time.
It's intended that CodeSet simply pass in the required direct data, and
that the memory manager takes care of it from that point on.

This means we just do the shared pointer allocation in a single place,
when loading modules, as opposed to in each loader.
 2019-03-22 18:43:46 -04:00
bunnei
819dd93257
Merge pull request #2279 from lioncash/cheat-global 
file_sys/cheat_engine: Remove use of global system accessors
 2019-03-22 18:41:44 -04:00
bunnei
e5893db3e6
Merge pull request #2256 from bunnei/gpu-vmm 
gpu: Rewrite MemoryManager based on the VMManager implementation.
 2019-03-22 18:41:12 -04:00
Lioncash
f3297d8cd1 loader/nso: Place translation unit specific functions into an anonymous namespace 
Makes it impossible to indirectly violate the ODR in some other
translation unit due to these existing.
 2019-03-22 15:25:53 -04:00
Lioncash
733cf179b8 file_sys/cheat_engine: Silence truncation and sign-conversion warnings 2019-03-22 14:43:41 -04:00
Lioncash
540235bb05 file_sys/cheat_engine: Remove use of global system accessors 
Instead, pass in the core timing instance and make the dependency
explicit in the interface.
 2019-03-22 14:43:37 -04:00
Lioncash
611f4666fd loader/nso: Clean up use of magic constants 
Now that the NSO header has the proper size, we can just use sizeof on
it instead of having magic constants.
 2019-03-22 14:39:17 -04:00
Lioncash
1cf90f4570 file_sys/patch_manager: Deduplicate NSO header 
This source file was utilizing its own version of the NSO header.
Instead of keeping this around, we can have the patch manager also use
the version of the header that we have defined in loader/nso.h
 2019-03-22 14:39:10 -04:00
Lioncash
90e27ea003 loader/nso: Fix definition of the NSO header struct 
The total struct itself is 0x100 (256) bytes in size, so we should be
providing that amount of data.

Without the data, this can result in omitted data from the final loaded
NSO file.
 2019-03-22 14:26:58 -04:00
Lioncash
ee49e1fcb6 file_sys/patch_manager: Remove two magic values 
These correspond to the NSOBuildHeader.
 2019-03-22 14:17:50 -04:00
bunnei
7b6d516faa
Merge pull request #2234 from lioncash/mutex 
core/hle/kernel: Make Mutex a per-process class.
 2019-03-21 22:18:36 -04:00
bunnei
b78e7b3454
Merge pull request #2274 from lioncash/include 
core/memory: Remove unnecessary includes
 2019-03-21 22:14:27 -04:00
bunnei
4d95adcac5
Merge pull request #2275 from lioncash/memflags 
kernel/vm_manager: Amend flag value for code data
 2019-03-21 21:43:15 -04:00
bunnei
e703772c83
Merge pull request #2276 from lioncash/am 
service/am: Add function table for IDebugFunctions
 2019-03-21 21:42:17 -04:00
bunnei
639f0c524d
Merge pull request #1933 from DarkLordZach/cheat-engine 
file_sys: Implement parser and interpreter for game memory cheats
 2019-03-21 21:41:59 -04:00
Lioncash
76f27d1f44 service/am: Add function table for IDebugFunctions 
We already have the service related stuff set up for this, however, it's
missing the function table.
 2019-03-21 15:58:03 -04:00
Lioncash
18918f5f2f kernel/vm_manager: Rename CodeStatic/CodeMutable to Code and CodeData respectively 
Makes it more evident that one is for actual code and one is for actual
data. Mutable and static are less than ideal terms here, because
read-only data is technically not mutable, but we were mapping it with
that label.
 2019-03-21 11:43:35 -04:00
Lioncash
56c80a2a21 kernel/vm_manager: Amend flag values for CodeMutable 
This should actually be using the data flags, rather than the code
flags.
 2019-03-21 11:23:14 -04:00
Lioncash
c221308a66 core/memory: Remove unnecessary includes 
In 93da8e0abf, the page table construct
was moved to the common library (which utilized these inclusions). Since
the move, nothing requires these headers to be included within the
memory header.
 2019-03-21 09:48:54 -04:00
bunnei
3e930304fe
Merge pull request #2090 from FearlessTobi/port-4599 
Port citra-emu/citra#4244 and citra-emu/citra#4599: Changes to BitField
 2019-03-20 23:44:20 -04:00
bunnei
52f36ea1c7
Merge pull request #2262 from lioncash/enum 
file_sys/content_archive: Amend name of Data_Unknown5 enum entry
 2019-03-20 23:13:32 -04:00
bunnei
e76f442a0e
Merge pull request #2268 from lioncash/codeset 
core/kernel: Migrate CodeSet to its own source files
 2019-03-20 22:37:58 -04:00
bunnei
3ae0de9b53 memory: Check that core is powered on before attempting to use GPU. 
- GPU will be released on shutdown, before pages are unmapped.
- On subsequent runs, current_page_table will be not nullptr, but GPU might not be valid yet.
 2019-03-20 22:36:03 -04:00
bunnei
22d3dfbcd4 gpu: Rewrite virtual memory manager using PageTable. 2019-03-20 22:36:02 -04:00
bunnei
241563d15c gpu: Move GPUVAddr definition to common_types. 2019-03-20 22:36:02 -04:00
bunnei
872a7bee72
Merge pull request #2267 from FernandoS27/fix-2238 
Fix crash caused by #2238.
 2019-03-20 21:36:55 -04:00
bunnei
723ad4512f
Merge pull request #2224 from lioncash/opus 
hwopus: Leverage multistream API for decoding regular Opus packets
 2019-03-20 21:33:37 -04:00
Lioncash
8f454a5c68 kernel/process: Make MapSegment lambda reference parameter const 
The segment itself isn't actually modified.
 2019-03-20 13:07:09 -04:00
Lioncash
1b6bd9d6df kernel: Move CodeSet structure to its own source files 
Given this is utilized by the loaders, this allows avoiding inclusion of
the kernel process definitions where avoidable.

This also keeps the loading format for all executable data separate from
the kernel objects.
 2019-03-20 13:07:04 -04:00
Fernando Sahmkow
8a320a6ee2 Fix crash caused by 2238. 2019-03-19 22:45:34 -04:00
Fernando Sahmkow
9c7319a4d4 Fix small bug that kept a thread as a condvar thread after being signalled. 2019-03-19 22:43:13 -04:00
Lioncash
1342c53e27 loader: Remove Linker class 
Given the class is now currently unused, it can be removed.
 2019-03-19 21:32:02 -04:00
Lioncash
ab00552118 loader: Remove Linker inheritance from NRO and NSO loaders 
Neither the NRO or NSO loaders actually make use of the functions or
members provided by the Linker interface, so we can just remove the
inheritance altogether.
 2019-03-19 21:31:59 -04:00
Fernando Sahmkow
acbdfdae64 Add CondVar Thread State. 2019-03-19 20:32:47 -04:00
Fernando Sahmkow
774f139e65 Small fixes to address_arbiter to better match the IDB. 2019-03-19 20:32:46 -04:00
Lioncash
b8c7072206 file_sys/content_archive: Amend name of Data_Unknown5 enum entry 
While we're at it, give each entry some documentation.
 2019-03-19 15:58:38 -04:00
bunnei
746167f11a
Merge pull request #2258 from lioncash/am 
service/am: Supply remaining missing IAudioController functions
 2019-03-18 22:20:36 -04:00
Lioncash
9f092554c2 fsp_srv: Unstub SetCurrentProcess 
This just acts as a basic setter for a given PID value and performs no
further checking, so we can just store the passed in value.
 2019-03-18 10:38:01 -04:00
Lioncash
26b809549b service/am: Add basic implementation of ChangeMainAppletMasterVolume 
All this does is supply a new volume level and a fade time in
nanoseconds for the volume transition to occur within.
 2019-03-18 09:18:34 -04:00
Lioncash
c07ebeac19 service/am: Unstub SetTransparentVolumeRate() 
Like the other volume setter, this mainly just sets a data member within
the service, nothing too special.
 2019-03-18 09:18:34 -04:00
Lioncash
ecd3afdc8e service/am: Unstub SetExpectedMasterVolume() 
This function passes in the desired main applet and library applet
volume levels. We can then just pass those values back within the
relevant volume getter functions, allowing us to unstub those as well.

The initial values for the library and main applet volumes differ. The
main applet volume is 0.25 by default, while the library applet volume
is initialized to 1.0 by default in the services themselves.
 2019-03-18 09:18:34 -04:00
bunnei
30f228a8c9
Merge pull request #2238 from lioncash/thread 
kernel/thread: Amend conditional test and assignment within UpdatePriority()
 2019-03-17 22:27:33 -04:00
bunnei
57ca1e3e69
Merge pull request #2252 from bunnei/move-page-table 
core: Move PageTable struct into Common.
 2019-03-17 14:42:57 -04:00
bunnei
9ad3b01d30
Merge pull request #2249 from lioncash/ipc 
ipc_helpers: Allow pushing and popping floating-point values
 2019-03-16 22:22:03 -04:00
bunnei
ed7a1e1443
Merge pull request #2245 from lioncash/unused-def 
kernel/thread: Actually remove the definition of ExitCurrentThread()
 2019-03-16 22:12:40 -04:00
bunnei
93da8e0abf core: Move PageTable struct into Common. 2019-03-16 22:05:40 -04:00
bunnei
bf41132aa9
Merge pull request #2243 from bunnei/mem-simplify-cache 
memory: Simplify rasterizer cache operations.
 2019-03-16 21:59:30 -04:00
bunnei
059465d496
Merge pull request #2129 from FernandoS27/cntpct 
Correct CNTPCT from using CPU Cycles to using Clock Cycles
 2019-03-16 21:58:59 -04:00
Lioncash
64444ff481 ipc_helpers: Allow pushing and popping floating-point values 
Certain values that are passed through the IPC buffer are actually
floating point values, not solely integral values.
 2019-03-16 14:05:03 -04:00
Lioncash
99f982dce2 kernel/thread: Actually remove the definition of ExitCurrentThread() 
This was intended to be removed in
51d7f6bffc, but I guess I forgot to
actually save the file like a dingus.
 2019-03-16 00:51:44 -04:00
bunnei
bdf2da4ee8
Merge pull request #2242 from lioncash/thread-fn 
kernel/thread: Remove WaitCurrentThread_Sleep() and ExitCurrentThread()
 2019-03-16 00:43:09 -04:00
bunnei
10118c71e0 memory: Simplify rasterizer cache operations. 2019-03-16 00:41:08 -04:00
Lioncash
51d7f6bffc kernel/thread: Move thread exiting logic from ExitCurrentThread to svcExitThread 
Puts the operation on global state in the same places as the rest of the
svc calls.
 2019-03-15 23:58:37 -04:00
Lioncash
c892cf01fa kernel/thread: Migrate WaitCurrentThread_Sleep into the Thread interface 
Rather than make a global accessor for this sort of thing. We can make
it a part of the thread interface itself. This allows getting rid of a
hidden global accessor in the kernel code.
 2019-03-15 23:58:31 -04:00
Lioncash
db47d7e471 kernel/thread: Expand documentation of nominal_priority and current_priority 
Aims to disambiguate why each priority instance exists a little bit.
While we're at it, also add an explanatory comment to UpdatePriority().
 2019-03-15 23:02:14 -04:00
Lioncash
e0d1f11968 kernel/thread: Make bracing consistent within UpdatePriority() 2019-03-15 23:02:10 -04:00
Lioncash
39483b92b7 kernel/thread: Amend condition within UpdatePriority() 
This condition was checking against the nominal thread priority, whereas
the kernel itself checks against the current priority instead. We were
also assigning the nominal priority, when we should be assigning
current_priority, which takes priority inheritance into account.

This can lead to the incorrect priority being assigned to a thread.

Given we recursively update the relevant threads, we don't need to go
through the whole mutex waiter list. This matches what the kernel does
as well (only accessing the first entry within the waiting list).
 2019-03-15 23:01:43 -04:00
Lioncash
0b78cfcc53 kernel/thread: Maintain priority ordering of added mutex waiting threads 
The kernel keeps the internal waiting list ordered by priority. This is
trivial to do with std::find_if followed by an insertion.
 2019-03-15 23:01:39 -04:00
Dimitri A
0e7ad1c367 gdbstub: Fix some bugs in IsMemoryBreak() and ServeBreak. Add workaround to let watchpoints break into GDB. (#4651) 
* gdbstub: fix IsMemoryBreak() returning false while connected to client

As a result, the only existing codepath for a memory watchpoint hit to break into GDB (InterpeterMainLoop, GDB_BP_CHECK, ARMul_State::RecordBreak) is finally taken,
which exposes incorrect logic* in both RecordBreak and ServeBreak.

* a blank BreakpointAddress structure is passed, which sets r15 (PC) to NULL

* gdbstub: DynCom: default-initialize two members/vars used in conditionals

* gdbstub: DynCom: don't record memory watchpoint hits via RecordBreak()

For now, instead check for GDBStub::IsMemoryBreak() in InterpreterMainLoop and ServeBreak.

Fixes PC being set to a stale/unhit breakpoint address (often zero) when a memory watchpoint (rwatch, watch, awatch) is handled in ServeBreak() and generates a GDB trap.

Reasons for removing a call to RecordBreak() for memory watchpoints:
* The``breakpoint_data`` we pass is typed Execute or None. It describes the predicted next code breakpoint hit relative to PC;

* GDBStub::IsMemoryBreak() returns true if a recent Read/Write operation hit a watchpoint. It doesn't specify which in return, nor does it trace it anywhere. Thus, the only data we could give RecordBreak() is a placeholder BreakpointAddress at offset NULL and type Access. I found the idea silly, compared to simply relying on GDBStub::IsMemoryBreak().

There is currently no measure in the code that remembers the addresses (and types) of any watchpoints that were hit by an instruction, in order to send them to GDB as "extended stop information."
I'm considering an implementation for this.

* gdbstub: Change an ASSERT to DEBUG_ASSERT

I have never seen the (Reg[15] == last_bkpt.address) assert fail in practice, even after several weeks of (locally) developping various branches around GDB.  Only leave it inside Debug builds.
 2019-03-15 16:31:06 +01:00
bunnei
2eaf6c41a4 gpu: Use host address for caching instead of guest address. 2019-03-14 22:34:42 -04:00
Lioncash
d71cad6ed0 core/hle/kernel/mutex: Remove usages of global system accessors 
Removes the use of global system accessors, and instead uses the
explicit interface provided.
 2019-03-14 20:55:52 -04:00
Lioncash
555cd26ec2 core/hle/kernel: Make Mutex a per-process class. 
Makes it an instantiable class like it is in the actual kernel. This
will also allow removing reliance on global accessors in a following
change, now that we can encapsulate a reference to the system instance
in the class.
 2019-03-14 20:55:52 -04:00
bunnei
2d9546848e
Merge pull request #2230 from lioncash/global 
kernel/process: Remove use of global system accessors
 2019-03-14 20:42:46 -04:00
bunnei
e7850a7f11
Merge pull request #2226 from lioncash/private 
kernel/server_port: Make data members private
 2019-03-13 14:44:21 -04:00
bunnei
c1ea6a39a0
Merge pull request #2223 from lioncash/error 
core/hle/result: Tidy up the base error code result header.
 2019-03-13 14:43:14 -04:00
bunnei
e8a21f5276
Merge pull request #2166 from lioncash/vi-init-service 
service/vi: Unstub GetDisplayService
 2019-03-13 10:01:54 -04:00
Lioncash
5379063108 core/hle/kernel/svc: Implement svcUnmapTransferMemory 
Similarly, like svcMapTransferMemory, we can also implement
svcUnmapTransferMemory fairly trivially as well.
 2019-03-13 06:04:49 -04:00
Lioncash
567134f874 core/hle/kernel/svc: Implement svcMapTransferMemory 
Now that transfer memory handling is separated from shared memory, we
can implement svcMapTransferMemory pretty trivially.
 2019-03-13 06:04:49 -04:00
Lioncash
cb198d7985 core/hle/kernel: Split transfer memory handling out into its own class 
Within the kernel, shared memory and transfer memory facilities exist as
completely different kernel objects. They also have different validity
checking as well. Therefore, we shouldn't be treating the two as the
same kind of memory.

They also differ in terms of their behavioral aspect as well. Shared
memory is intended for sharing memory between processes, while transfer
memory is intended to be for transferring memory to other processes.

This breaks out the handling for transfer memory into its own class and
treats it as its own kernel object. This is also important when we
consider resource limits as well. Particularly because transfer memory
is limited by the resource limit value set for it.

While we currently don't handle resource limit testing against objects
yet (but we do allow setting them), this will make implementing that
behavior much easier in the future, as we don't need to distinguish
between shared memory and transfer memory allocations in the same place.
 2019-03-13 06:04:44 -04:00
Lioncash
6eddb60db0 kernel/process: Remove use of global system accessors 
Now that we pass in a reference to the system instance, we can utilize
it to eliminate the global accessors in Process-related code.
 2019-03-12 19:03:28 -04:00
bunnei
3bfd199497
Merge pull request #2211 from lioncash/arbiter 
kernel: Make the address arbiter instance per-process
 2019-03-12 17:54:48 -04:00
Zach Hilman
cd2921a047 set_sys: Move constants to anonymous namespace 2019-03-11 11:16:35 -04:00
Lioncash
aa44eb639b kernel/server_port: Make data members private 
With this, all kernel objects finally have all of their data members
behind an interface, making it nicer to reason about interactions with
other code (as external code no longer has the freedom to totally alter
internals and potentially messing up invariants).
 2019-03-11 10:41:05 -04:00
Lioncash
7ad3d4e49c hwopus: Leverage multistream API for decoding regular Opus packets 
After doing a little more reading up on the Opus codec, it turns out
that the multistream API that is part of libopus can handle regular
packets. Regular packets are just a degenerate case of multistream Opus
packets, and all that's necessary is to pass the number of streams as 1
and  provide a basic channel mapping, then everything works fine for
that case.

This allows us to get rid of the need to use both APIs in the future
when implementing multistream variants in a follow-up PR, greatly
simplifying the code that needs to be written.
 2019-03-11 07:06:18 -04:00
Zach Hilman
debc7442f2 set_sys: Use official nintendo version string 2019-03-10 19:54:13 -04:00
Zach Hilman
73f2ee5484 system_version: Correct sizes on VectorVfsFile construction 2019-03-10 19:16:17 -04:00
Zach Hilman
597c00698d set_sys: Use correct error codes in GetFirmwareVersion* 2019-03-10 19:09:23 -04:00
Lioncash
0c28ab92e6 core/hle/result: Remove now-unnecessary manually defined copy assignment operator 
Previously this was required, as BitField wasn't trivially copyable.
BitField has since been made trivially copyable, so now this isn't
required anymore.
 2019-03-10 18:34:20 -04:00
Lioncash
3f602dde0f core/hle/result: Amend error in comment description for ResultCode 
Gets rid of another holdover from Citra, and describes the OS on the
Switch instead.
 2019-03-10 18:29:31 -04:00
Lioncash
f7ec0bcfc2 core/hle/result: Remove now-unused constructor for ResultCode 
Now that the final stray ErrorDescription member was relocated, we can
finally remove it and its relevant constructor in the ResultCode union.
 2019-03-10 18:26:12 -04:00
Lioncash
d870cc5ad7 core/hle/result: Relocate IPC error code to ipc_helpers 
Relocates the error code to where it's most related, similar to how all
the other error codes are. Previously we were including a non-generic
error in the main result code header.
 2019-03-10 18:23:42 -04:00
Lioncash
8603f0f9b1 service/service: Remove unncessary calls to c_str() 
These can just be passed regularly, now that we use fmt instead of our
old logging system.

While we're at it, make the parameters to MakeFunctionString
std::string_views.
 2019-03-10 18:00:57 -04:00
bunnei
0aa824b12f
Merge pull request #2207 from lioncash/hwopus 
service/audio/hwopus: Move decoder state to its own class
 2019-03-10 17:32:39 -04:00
bunnei
037d9bdde3
Merge pull request #2193 from lioncash/global 
kernel/scheduler: Pass in system instance in constructor
 2019-03-10 17:29:01 -04:00
Zach Hilman
ed82bb968a set_sys: Implement GetFirmwareVersion(2) for libnx hosversion 
Uses the synthesized system archive 9 (SystemVersion) and reports v5.1.0-0.0
 2019-03-10 16:51:42 -04:00
Hexagon12
e6f652ae12 clang fix 2019-03-09 16:42:56 +02:00
Hexagon12
6ce8de4b5f Log 2 new setting values 2019-03-09 14:58:15 +02:00
bunnei
9909d40530
Merge pull request #2210 from lioncash/optional 
kernel/hle_ipc: Convert std::shared_ptr IPC header instances to std::optional
 2019-03-08 16:35:57 -05:00
Lioncash
fbb82e61e3 kernel/hle_ipc: Convert std::shared_ptr IPC header instances to std::optional 
There's no real need to use a shared lifetime here, since we don't
actually expose them to anything else. This is also kind of an
unnecessary use of the heap given the objects themselves are so small;
small enough, in fact that changing over to optionals actually reduces
the overall size of the HLERequestContext struct (818 bytes to 808
bytes).
 2019-03-07 23:34:37 -05:00
Lioncash
8e510d5afa kernel: Make the address arbiter instance per-process 
Now that we have the address arbiter extracted to its own class, we can
fix an innaccuracy with the kernel. Said inaccuracy being that there
isn't only one address arbiter. Each process instance contains its own
AddressArbiter instance in the actual kernel.

This fixes that and gets rid of another long-standing issue that could
arise when attempting to create more than one process.
 2019-03-07 23:27:51 -05:00
Lioncash
b7f331afa3 kernel/svc: Move address arbiter signaling behind a unified API function 
Similar to how WaitForAddress was isolated to its own function, we can
also move the necessary conditional checking into the address arbiter
class itself, allowing us to hide the implementation details of it from
public use.
 2019-03-07 23:27:47 -05:00
Lioncash
0209de123b kernel/svc: Move address arbiter waiting behind a unified API function 
Rather than let the service call itself work out which function is the
proper one to call, we can make that a behavior of the arbiter itself,
so we don't need to directly expose those implementation details.
 2019-03-07 23:27:20 -05:00
bunnei
d26ee6e01e
Merge pull request #2195 from lioncash/shared-global 
kernel/shared_memory: Get rid of the use of global accessor functions within Create()
 2019-03-07 17:26:11 -05:00
bunnei
c63a0e88b7
Merge pull request #2202 from lioncash/port-priv 
kernel/client_session, kernel/server_session: Make data members private
 2019-03-07 15:31:26 -05:00
bunnei
d9e9e71aec
Merge pull request #2206 from lioncash/audio-stop 
service/audio/audout_u: Only actually stop the audio stream in StopAudioOut if the stream is playing
 2019-03-07 10:47:59 -05:00
bunnei
4f352833a5
Merge pull request #2055 from bunnei/gpu-thread 
Asynchronous GPU command processing
 2019-03-07 10:41:53 -05:00
Lioncash
d03ae881fd service/audio/hwopus: Move decoder state to its own class 
Moves the non-multistream specific state to its own class. This will be
necessary to support the multistream variants of opus decoding.
 2019-03-07 07:47:09 -05:00
Lioncash
960057cba0 service/audio/hwopus: Provide a name for the second word of OpusPacketHeader 
This indicates the entropy coder's final range.
 2019-03-07 05:48:35 -05:00
Lioncash
d41d85766f service/audio/hwopus: Move Opus packet header out of the IHardwareOpusDecoderManager 
This will be utilized by more than just that class in the future. This
also renames it from OpusHeader to OpusPacketHeader to be more specific
about what kind of header it is.
 2019-03-07 05:37:08 -05:00
Lioncash
3293877456 service/audio/hwopus: Enclose internals in an anonymous namespace 
Makes it impossible to violate the ODR, as well as providing a place for
future changes.
 2019-03-07 05:32:42 -05:00
Lioncash
64e7524f36 service/audio/audout_u: Only actually stop the audio stream in StopAudioOut if the stream is playing 
The service itself only does further actions if the stream is playing.
If the stream is already stopped, then it just exits successfully.
 2019-03-07 03:39:01 -05:00
bunnei
ed0bdcc638
Merge pull request #2197 from lioncash/include 
core/hle/ipc: Remove unnecessary includes
 2019-03-06 21:55:16 -05:00
bunnei
aaa373585c gpu: Refactor a/synchronous implementations into their own classes. 2019-03-06 21:48:57 -05:00